Fix nuget package generation

* Add support for binary user properties in MQTT 5.0

* Optimize byte array reversal in SubscriptionTopicHashTests

* Use InvariantCulture for topic string conversion in Load_Tests

* switched to `Microsoft.Testing.Platform`

* Refactor CI workflow to separate signed and unsigned package builds

* Add condition to sign job to prevent execution on external pull requests

* Remove fallback to value as string in MqttUserProperty

* Refactor MqttUserProperty handling to use byte arrays for improved performance and add deprecation warnings for legacy methods

.github/workflows/ci.yml

@@ -3,7 +3,7 @@ name: CI
 on: [push, pull_request]
 
 env:
-  VERSION: "5.0.0.${{github.run_number}}"
+  VERSION: "5.1.0.${{github.run_number}}"
   PACKAGE_SUFFIX: ""
 
 jobs:
@@ -17,11 +17,25 @@ jobs:
         with:
           dotnet-version: |
             8.0.x
+            10.0.x
 
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Build package
+      - name: Load strong name certificate
+        if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }}
+        run: |
+          echo "$SNC_BASE64" | base64 --decode > "${{ github.workspace }}/certificate.snk"
+        shell: bash
+        env:
+          SNC_BASE64: ${{ secrets.SNC_BASE64 }}
+
+      - name: Build package (signed)
+        if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }}
+        run: dotnet build MQTTnet.sln --configuration Release /p:FileVersion=${{ env.VERSION }} /p:AssemblyVersion=${{ env.VERSION }} /p:PackageVersion=${{ env.VERSION }}${{ env.PACKAGE_SUFFIX }} /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=${{ github.workspace }}/certificate.snk
+
+      - name: Build package (unsigned)
+        if: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository }}
         run: dotnet build MQTTnet.sln --configuration Release /p:FileVersion=${{ env.VERSION }} /p:AssemblyVersion=${{ env.VERSION }} /p:PackageVersion=${{ env.VERSION }}${{ env.PACKAGE_SUFFIX }}
 
       - name: Upload nuget packages
@@ -41,24 +55,19 @@ jobs:
         with:
           dotnet-version: |
             8.0.x
+            10.0.x
 
       - name: Checkout code
         uses: actions/checkout@v4
 
       - name: Execute tests
-        run: dotnet test --framework net8.0 Source/MQTTnet.Tests/MQTTnet.Tests.csproj
+        run: dotnet test --framework net10.0 --configuration Release --project Source/MQTTnet.Tests/MQTTnet.Tests.csproj
 
   sign:
     needs: build
     runs-on: windows-latest # Code signing must run on a Windows agent for Authenticode signing (dll/exe)
-    if: github.repository == 'dotnet/MQTTnet'
+    if: github.repository == 'dotnet/MQTTnet' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
     steps:
-      - name: Setup .NET SDK
-        uses: actions/setup-dotnet@v4
-        with:
-          dotnet-version: |
-            6.0.x
-
       - name: Download nuget packages
         uses: actions/download-artifact@v4
         with:
@@ -66,7 +75,7 @@ jobs:
           path: nugets
 
       - name: Install sign CLI tool
-        run: dotnet tool install --tool-path . sign --version 0.9.0-beta.23127.3
+        run: dotnet tool install --tool-path . sign --version 0.9.1-beta.25379.1
 
       - name: Sign nugets
         shell: pwsh
@@ -107,7 +116,7 @@ jobs:
         run: dotnet nuget push ${{ github.workspace }}/nugets/**/*.nupkg -k ${{ secrets.MYGET_API_KEY }} -s https://www.myget.org/F/mqttnet/api/v3/index.json --skip-duplicate
 
   publish-nuget:
-    # Tag schema is 'v5.0.0-rc' etc.
+    # Tag schema is 'v5.1.0-rc' etc.
     if: startsWith(github.ref, 'refs/tags/v')
     needs: [sign, test]
     runs-on: ubuntu-latest

Directory.Build.props

@@ -0,0 +1,34 @@
+<Project>
+    <PropertyGroup>
+        <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
+        <Product>MQTTnet</Product>
+        <Authors>The contributors of MQTTnet</Authors>
+        <Company>The contributors of MQTTnet</Company>
+        <Copyright>Copyright (c) .NET Foundation and Contributors</Copyright>
+
+        <DelaySign>false</DelaySign>
+        <SignAssembly>false</SignAssembly>
+        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+        <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
+        <ImplicitUsings>enable</ImplicitUsings>
+        <Nullable>disable</Nullable>
+
+        <NeutralLanguage>en-US</NeutralLanguage>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+        <NoWarn>1591;NETSDK1138;NU1803;NU1901;NU1902</NoWarn>
+
+        <NuGetAuditMode>all</NuGetAuditMode>
+        <NuGetAudit>true</NuGetAudit>
+        <NuGetAuditLevel>low</NuGetAuditLevel>
+
+        <EnableNETAnalyzers>true</EnableNETAnalyzers>
+        <AnalysisLevel>latest</AnalysisLevel>
+        <AnalysisMode>recommended</AnalysisMode>
+        <AnalysisModeStyle>default</AnalysisModeStyle>
+    </PropertyGroup>
+
+    <PropertyGroup Condition="'$(GITHUB_ACTIONS)'=='true'">
+        <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+    </PropertyGroup>
+
+</Project>

Directory.Build.targets

@@ -0,0 +1,24 @@
+<Project>
+
+    <PropertyGroup Condition="'$(GeneratePackageOnBuild)'=='true'">
+        <PackageLicenseFile>LICENSE</PackageLicenseFile>
+        <PackageIcon>nuget.png</PackageIcon>
+        <PackageProjectUrl>https://github.com/dotnet/MQTTnet</PackageProjectUrl>
+        <RepositoryUrl>https://github.com/dotnet/MQTTnet.git</RepositoryUrl>
+        <RepositoryType>git</RepositoryType>
+        <IncludeSymbols>true</IncludeSymbols>
+        <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+        <PublishRepositoryUrl>true</PublishRepositoryUrl>
+        <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    </PropertyGroup>
+
+    <ItemGroup Condition="'$(GeneratePackageOnBuild)'=='true'">
+        <None Include="README.md" Pack="true" PackagePath="" Condition="Exists('README.md')" />
+        <None Include="..\..\Images\nuget.png" Pack="true" PackagePath="" />
+        <None Include="..\..\LICENSE" Pack="true" PackagePath="" />
+    </ItemGroup>
+
+    <ItemGroup Condition="'$(IncludeSymbols)'=='true'">
+        <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
+    </ItemGroup>
+</Project>

MQTTnet.sln

@@ -7,11 +7,13 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MQTTnet", "Source\MQTTnet\M
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{B3F60ECB-45BA-4C66-8903-8BB89CA67998}"
 	ProjectSection(SolutionItems) = preProject
+		.github\workflows\ci.yml = .github\workflows\ci.yml
 		CODE-OF-CONDUCT.md = CODE-OF-CONDUCT.md
+		Directory.Build.props = Directory.Build.props
 		LICENSE = LICENSE
 		README.md = README.md
 		Source\ReleaseNotes.md = Source\ReleaseNotes.md
-		.github\workflows\ci.yml = .github\workflows\ci.yml
+		Directory.Build.targets = Directory.Build.targets
 	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MQTTnet.AspNetCore", "Source\MQTTnet.AspnetCore\MQTTnet.AspNetCore.csproj", "{F10C4060-F7EE-4A83-919F-FF723E72F94A}"
@@ -85,6 +87,4 @@ Global
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {07536672-5CBC-4BE3-ACE0-708A431A7894}
 	EndGlobalSection
-	GlobalSection(NestedProjects) = preSolution
-	EndGlobalSection
 EndGlobal

MQTTnet.sln.DotSettings

@@ -1,4 +1,8 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ConvertIfStatementToSwitchStatement/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=InconsistentNaming/@EntryIndexedValue">SUGGESTION</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UncatchableException/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnthrowableException/@EntryIndexedValue">DO_NOT_SHOW</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_FOR/@EntryValue">Required</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_FOREACH/@EntryValue">Required</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/BRACES_FOR_IFELSE/@EntryValue">Required</s:String>

README.md

@@ -3,9 +3,9 @@
 <br/>
 </p>
 
-[![NuGet Badge](https://buildstats.info/nuget/MQTTnet)](https://www.nuget.org/packages/MQTTnet)
+[![NuGet Badge](https://img.shields.io/nuget/dt/MQTTnet)](https://www.nuget.org/packages/MQTTnet)
 [![CI](https://github.com/dotnet/MQTTnet/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/dotnet/MQTTnet/actions/workflows/ci.yml)
-[![MyGet](https://img.shields.io/myget/mqttnet/v/mqttnet?color=orange&label=MyGet-Preview)](https://www.myget.org/feed/mqttnet/package/nuget/MQTTnet)
+[![MyGet](https://img.shields.io/myget/mqttnet/v/mqttnet?color=orange&label=preview)](https://www.myget.org/feed/mqttnet/package/nuget/MQTTnet)
 ![Size](https://img.shields.io/github/repo-size/dotnet/MQTTnet.svg)
 [![Join the chat at https://gitter.im/MQTTnet/community](https://badges.gitter.im/MQTTnet/community.svg)](https://gitter.im/MQTTnet/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://raw.githubusercontent.com/dotnet/MQTTnet/master/LICENSE)

Samples/Client/Client_Connection_Samples.cs

@@ -413,7 +413,7 @@ m/XriWr/Cq4h/JfB7NTsezVslgkBaoU=
             if (e.ClientWasConnected)
             {
                 // Use the current options as the new options.
-                await mqttClient.ConnectAsync(mqttClient.Options);
+                await mqttClient.ConnectAsync(mqttClientOptions);
             }
         };
 
@@ -490,7 +490,7 @@ m/XriWr/Cq4h/JfB7NTsezVslgkBaoU=
         }
     }
 
-    class SampleClientKerberosAuthenticationHandler : IMqttEnhancedAuthenticationHandler
+    sealed class SampleClientKerberosAuthenticationHandler : IMqttEnhancedAuthenticationHandler
     {
         public async Task HandleEnhancedAuthenticationAsync(MqttEnhancedAuthenticationEventArgs eventArgs)
         {

Samples/Client/Client_Publish_Samples.cs

@@ -6,6 +6,9 @@
 // ReSharper disable UnusedMember.Global
 // ReSharper disable InconsistentNaming
 
+using System;
+using System.Text;
+
 namespace MQTTnet.Samples.Client;
 
 public static class Client_Publish_Samples
@@ -23,25 +26,23 @@ public static class Client_Publish_Samples
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            var mqttClientOptions = new MqttClientOptionsBuilder()
-                .WithTcpServer("broker.hivemq.com")
-                .Build();
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder()
+            .WithTcpServer("broker.hivemq.com")
+            .Build();
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            var applicationMessage = new MqttApplicationMessageBuilder()
-                .WithTopic("samples/temperature/living_room")
-                .WithPayload("19.5")
-                .Build();
+        var applicationMessage = new MqttApplicationMessageBuilder()
+            .WithTopic("samples/temperature/living_room")
+            .WithPayload("19.5")
+            .Build();
 
-            await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
+        await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
 
-            await mqttClient.DisconnectAsync();
+        await mqttClient.DisconnectAsync();
 
-            Console.WriteLine("MQTT application message is published.");
-        }
+        Console.WriteLine("MQTT application message is published.");
     }
 
     public static async Task Publish_Multiple_Application_Messages()
@@ -54,38 +55,53 @@ public static class Client_Publish_Samples
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            var mqttClientOptions = new MqttClientOptionsBuilder()
-                .WithTcpServer("broker.hivemq.com")
-                .Build();
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder()
+            .WithTcpServer("broker.hivemq.com")
+            .Build();
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            var applicationMessage = new MqttApplicationMessageBuilder()
-                .WithTopic("samples/temperature/living_room")
-                .WithPayload("19.5")
-                .Build();
+        var applicationMessage = new MqttApplicationMessageBuilder()
+            .WithTopic("samples/temperature/living_room")
+            .WithPayload("19.5")
+            .Build();
 
-            await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
+        await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
 
-            applicationMessage = new MqttApplicationMessageBuilder()
-                .WithTopic("samples/temperature/living_room")
-                .WithPayload("20.0")
-                .Build();
+        applicationMessage = new MqttApplicationMessageBuilder()
+            .WithTopic("samples/temperature/living_room")
+            .WithPayload("20.0")
+            .Build();
 
-            await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
+        await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
 
-            applicationMessage = new MqttApplicationMessageBuilder()
-                .WithTopic("samples/temperature/living_room")
-                .WithPayload("21.0")
-                .Build();
+        applicationMessage = new MqttApplicationMessageBuilder()
+            .WithTopic("samples/temperature/living_room")
+            .WithPayload("21.0")
+            .Build();
 
-            await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
+        await mqttClient.PublishAsync(applicationMessage, CancellationToken.None);
 
-            await mqttClient.DisconnectAsync();
+        await mqttClient.DisconnectAsync();
 
-            Console.WriteLine("MQTT application message is published.");
-        }
+        Console.WriteLine("MQTT application message is published.");
+    }
+
+    public static MqttApplicationMessage Create_Message_With_Binary_User_Property()
+    {
+        /*
+         * MQTT v5 user properties are encoded as UTF-8 strings. When the UTF-8 payload is already available
+         * as a byte buffer, the builder APIs can avoid creating intermediate strings.
+         */
+
+        var encodedValue = Encoding.UTF8.GetBytes("sensor-01");
+
+        return new MqttApplicationMessageBuilder()
+            .WithTopic("samples/metadata/binary")
+            .WithUserProperty("client-id", encodedValue.AsMemory())
+            .WithUserProperty("checksum", new ArraySegment<byte>(encodedValue))
+            .WithPayload("metadata")
+            .Build();
     }
 }

Samples/Client/Client_Subscribe_Samples.cs

@@ -7,7 +7,7 @@
 // ReSharper disable InconsistentNaming
 // ReSharper disable UnusedMember.Local
 
-using MQTTnet.Extensions.TopicTemplate;
+using System.Text;
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 using MQTTnet.Samples.Helpers;
@@ -16,8 +16,6 @@ namespace MQTTnet.Samples.Client;
 
 public static class Client_Subscribe_Samples
 {
-    static readonly MqttTopicTemplate sampleTemplate = new("mqttnet/samples/topic/{id}");
-
     public static async Task Handle_Received_Application_Message()
     {
         /*
@@ -26,72 +24,68 @@ public static class Client_Subscribe_Samples
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+
+        // Setup message handling before connecting so that queued messages
+        // are also handled properly. When there is no event handler attached all
+        // received messages get lost.
+        mqttClient.ApplicationMessageReceivedAsync += e =>
         {
-            var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+            Console.WriteLine("Received application message.");
+            e.DumpToConsole();
 
-            // Setup message handling before connecting so that queued messages
-            // are also handled properly. When there is no event handler attached all
-            // received messages get lost.
-            mqttClient.ApplicationMessageReceivedAsync += e =>
-            {
-                Console.WriteLine("Received application message.");
-                e.DumpToConsole();
+            return Task.CompletedTask;
+        };
 
-                return Task.CompletedTask;
-            };
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicFilter("mqttnet/samples/topic/2").Build();
 
-            var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicTemplate(sampleTemplate.WithParameter("id", "2")).Build();
+        await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
 
-            await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
+        Console.WriteLine("MQTT client subscribed to topic.");
 
-            Console.WriteLine("MQTT client subscribed to topic.");
-
-            Console.WriteLine("Press enter to exit.");
-            Console.ReadLine();
-        }
+        Console.WriteLine("Press enter to exit.");
+        Console.ReadLine();
     }
 
     public static async Task Send_Responses()
     {
         /*
-         * This sample subscribes to a topic and sends a response to the broker. This requires at least QoS level 1 to work!
+         * This sample subscribes to a topic and sends a detailed response to the client. This requires at least QoS level 1 to work!
          */
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        mqttClient.ApplicationMessageReceivedAsync += delegate(MqttApplicationMessageReceivedEventArgs args)
         {
-            mqttClient.ApplicationMessageReceivedAsync += delegate(MqttApplicationMessageReceivedEventArgs args)
-            {
-                // Do some work with the message...
+            // Do some work with the message...
 
-                // Now respond to the broker with a reason code other than success.
-                args.ReasonCode = MqttApplicationMessageReceivedReasonCode.ImplementationSpecificError;
-                args.ResponseReasonString = "That did not work!";
+            // Now respond to the broker with a reason code other than success.
+            args.ReasonCode = MqttApplicationMessageReceivedReasonCode.ImplementationSpecificError;
+            args.ResponseReasonString = "That did not work!";
 
-                // User properties require MQTT v5!
-                args.ResponseUserProperties.Add(new MqttUserProperty("My", "Data"));
+            // User properties require MQTT v5!
+            args.ResponseUserProperties.Add(new MqttUserProperty("My", Encoding.UTF8.GetBytes("Data")));
 
-                // Now the broker will resend the message again.
-                return Task.CompletedTask;
-            };
+            // Now the broker will resend the message again.
+            return Task.CompletedTask;
+        };
 
-            var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+        var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicTemplate(sampleTemplate.WithParameter("id", "1")).Build();
+        var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicFilter("topic/test").Build();
 
-            var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
+        var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
 
-            Console.WriteLine("MQTT client subscribed to topic.");
+        Console.WriteLine("MQTT client subscribed to topic.");
 
-            // The response contains additional data sent by the server after subscribing.
-            response.DumpToConsole();
-        }
+        // The response contains additional data sent by the server after subscribing.
+        response.DumpToConsole();
     }
 
     public static async Task Subscribe_Multiple_Topics()
@@ -102,27 +96,26 @@ public static class Client_Subscribe_Samples
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            // Create the subscribe options including several topics with different options.
-            // It is also possible to all of these topics using a dedicated call of _SubscribeAsync_ per topic.
-            var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder()
-                .WithTopicTemplate(sampleTemplate.WithParameter("id", "1"))
-                .WithTopicTemplate(sampleTemplate.WithParameter("id", "2"), noLocal: true)
-                .WithTopicTemplate(sampleTemplate.WithParameter("id", "3"), retainHandling: MqttRetainHandling.SendAtSubscribe)
-                .Build();
+        // Create the subscribe options including several topics with different options.
+        // It is also possible to all of these topics using a dedicated call of _SubscribeAsync_ per topic.
+        var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder()
+            .WithTopicFilter(t => t.WithTopic("topic/1").WithAtLeastOnceQoS())
+            .WithTopicFilter(t => t.WithTopic("topic/2").WithAtMostOnceQoS())
+            .WithTopicFilter(t => t.WithTopic("topic/3").WithNoLocal())
+            .WithTopicFilter(t => t.WithRetainHandling(MqttRetainHandling.SendAtSubscribe))
+            .Build();
 
-            var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
+        var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
 
-            Console.WriteLine("MQTT client subscribed to topics.");
+        Console.WriteLine("MQTT client subscribed to topics.");
 
-            // The response contains additional data sent by the server after subscribing.
-            response.DumpToConsole();
-        }
+        // The response contains additional data sent by the server after subscribing.
+        response.DumpToConsole();
     }
 
     public static async Task Subscribe_Topic()
@@ -133,24 +126,24 @@ public static class Client_Subscribe_Samples
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicTemplate(sampleTemplate.WithParameter("id", "1")).Build();
+        var topicFilter = mqttFactory.CreateTopicFilterBuilder().WithTopic("mqttnet/samples/topic/2").WithAtLeastOnceQoS();
 
-            var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
+        var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicFilter(topicFilter).Build();
 
-            Console.WriteLine("MQTT client subscribed to topic.");
+        var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
 
-            // The response contains additional data sent by the server after subscribing.
-            response.DumpToConsole();
-        }
+        Console.WriteLine("MQTT client subscribed to topic.");
+
+        // The response contains additional data sent by the server after subscribing.
+        response.DumpToConsole();
     }
 
-    static void ConcurrentProcessingDisableAutoAcknowledge(CancellationToken shutdownToken, IMqttClient mqttClient)
+    static void ConcurrentProcessingDisableAutoAcknowledge(IMqttClient mqttClient, CancellationToken shutdownToken)
     {
         /*
          * This sample shows how to achieve concurrent processing and not have message AutoAcknowledged
@@ -178,7 +171,7 @@ public static class Client_Subscribe_Samples
         };
     }
 
-    static void ConcurrentProcessingWithLimit(CancellationToken shutdownToken, IMqttClient mqttClient)
+    static void ConcurrentProcessingWithLimit(IMqttClient mqttClient, CancellationToken shutdownToken)
     {
         /*
          * This sample shows how to achieve concurrent processing, with:

Samples/Client/Client_Subscribe_TopicTemplate_Samples.cs

@@ -0,0 +1,75 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using MQTTnet.Extensions.TopicTemplate;
+using MQTTnet.Protocol;
+using MQTTnet.Samples.Helpers;
+
+// ReSharper disable UnusedType.Global
+// ReSharper disable UnusedMember.Global
+// ReSharper disable InconsistentNaming
+// ReSharper disable UnusedMember.Local
+
+namespace MQTTnet.Samples.Client;
+
+public static class Client_Subscribe_TopicTemplate_Samples
+{
+    static readonly MqttTopicTemplate SampleTemplate = new("mqttnet/samples/topic/{id}");
+
+    public static async Task Subscribe_Multiple_Topics_With_Template()
+    {
+        /*
+         * This sample subscribes to several topics in a single request.
+         *
+         * This sample requires the nuget 'MQTTnet.Extensions.TopicTemplate'.
+         */
+
+        var mqttFactory = new MqttClientFactory();
+
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+
+        // Create the subscribe options including several topics with different options.
+        // It is also possible to all of these topics using a dedicated call of _SubscribeAsync_ per topic.
+        var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder()
+            .WithTopicTemplate(SampleTemplate.WithParameter("id", "1"))
+            .WithTopicTemplate(SampleTemplate.WithParameter("id", "2"), noLocal: true)
+            .WithTopicTemplate(SampleTemplate.WithParameter("id", "3"), retainHandling: MqttRetainHandling.SendAtSubscribe)
+            .Build();
+
+        var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
+
+        Console.WriteLine("MQTT client subscribed to topics.");
+
+        // The response contains additional data sent by the server after subscribing.
+        response.DumpToConsole();
+    }
+
+    public static async Task Subscribe_Topic_With_Template()
+    {
+        /*
+         * This sample subscribes to a topic.
+         *
+         * This sample requires the nuget 'MQTTnet.Extensions.TopicTemplate'.
+         */
+
+        var mqttFactory = new MqttClientFactory();
+
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder().WithTcpServer("broker.hivemq.com").Build();
+
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+
+        var mqttSubscribeOptions = mqttFactory.CreateSubscribeOptionsBuilder().WithTopicTemplate(SampleTemplate.WithParameter("id", "1")).Build();
+
+        var response = await mqttClient.SubscribeAsync(mqttSubscribeOptions, CancellationToken.None);
+
+        Console.WriteLine("MQTT client subscribed to topic.");
+
+        // The response contains additional data sent by the server after subscribing.
+        response.DumpToConsole();
+    }
+}

Samples/Diagnostics/Logger_Samples.cs

@@ -6,6 +6,7 @@
 // ReSharper disable UnusedMember.Global
 // ReSharper disable InconsistentNaming
 
+using System.Globalization;
 using System.Text;
 using MQTTnet.Diagnostics.Logger;
 
@@ -26,17 +27,15 @@ public static class Logger_Samples
             .WithTcpServer("broker.hivemq.com")
             .Build();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            Console.WriteLine("MQTT client is connected.");
+        Console.WriteLine("MQTT client is connected.");
 
-            var mqttClientDisconnectOptions = mqttFactory.CreateClientDisconnectOptionsBuilder()
-                .Build();
+        var mqttClientDisconnectOptions = mqttFactory.CreateClientDisconnectOptionsBuilder()
+            .Build();
 
-            await mqttClient.DisconnectAsync(mqttClientDisconnectOptions, CancellationToken.None);
-        }
+        await mqttClient.DisconnectAsync(mqttClientDisconnectOptions, CancellationToken.None);
     }
 
     public static async Task Use_Event_Logger()
@@ -50,10 +49,10 @@ public static class Logger_Samples
         // The logger ID is optional but can be set do distinguish different logger instances.
         var mqttEventLogger = new MqttNetEventLogger("MyCustomLogger");
 
-        mqttEventLogger.LogMessagePublished += (sender, args) =>
+        mqttEventLogger.LogMessagePublished += (_, args) =>
         {
             var output = new StringBuilder();
-            output.AppendLine($">> [{args.LogMessage.Timestamp:O}] [{args.LogMessage.ThreadId}] [{args.LogMessage.Source}] [{args.LogMessage.Level}]: {args.LogMessage.Message}");
+            output.AppendLine(CultureInfo.InvariantCulture, $">> [{args.LogMessage.Timestamp:O}] [{args.LogMessage.ThreadId}] [{args.LogMessage.Source}] [{args.LogMessage.Level}]: {args.LogMessage.Message}");
             if (args.LogMessage.Exception != null)
             {
                 output.AppendLine(args.LogMessage.Exception.ToString());
@@ -68,17 +67,15 @@ public static class Logger_Samples
             .WithTcpServer("broker.hivemq.com")
             .Build();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            Console.WriteLine("MQTT client is connected.");
+        Console.WriteLine("MQTT client is connected.");
 
-            var mqttClientDisconnectOptions = mqttFactory.CreateClientDisconnectOptionsBuilder()
-                .Build();
+        var mqttClientDisconnectOptions = mqttFactory.CreateClientDisconnectOptionsBuilder()
+            .Build();
 
-            await mqttClient.DisconnectAsync(mqttClientDisconnectOptions, CancellationToken.None);
-        }
+        await mqttClient.DisconnectAsync(mqttClientDisconnectOptions, CancellationToken.None);
     }
 
     sealed class MyLogger : IMqttNetLogger

Samples/Diagnostics/PackageInspection_Samples.cs

@@ -20,23 +20,21 @@ public static class PackageInspection_Samples
 
         var mqttFactory = new MqttClientFactory();
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
-        {
-            var mqttClientOptions = mqttFactory.CreateClientOptionsBuilder()
-                .WithTcpServer("broker.hivemq.com")
-                .Build();
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = mqttFactory.CreateClientOptionsBuilder()
+            .WithTcpServer("broker.hivemq.com")
+            .Build();
 
-            mqttClient.InspectPacketAsync += OnInspectPacket;
+        mqttClient.InspectPacketAsync += OnInspectPacket;
 
-            await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
+        await mqttClient.ConnectAsync(mqttClientOptions, CancellationToken.None);
 
-            Console.WriteLine("MQTT client is connected.");
+        Console.WriteLine("MQTT client is connected.");
 
-            var mqttClientDisconnectOptions = mqttFactory.CreateClientDisconnectOptionsBuilder()
-                .Build();
+        var mqttClientDisconnectOptions = mqttFactory.CreateClientDisconnectOptionsBuilder()
+            .Build();
 
-            await mqttClient.DisconnectAsync(mqttClientDisconnectOptions, CancellationToken.None);
-        }
+        await mqttClient.DisconnectAsync(mqttClientDisconnectOptions, CancellationToken.None);
     }
 
     static Task OnInspectPacket(InspectMqttPacketEventArgs eventArgs)

Samples/Helpers/ObjectExtensions.cs

@@ -8,17 +8,19 @@ namespace MQTTnet.Samples.Helpers;
 
 internal static class ObjectExtensions
 {
+    static readonly JsonSerializerOptions SerializerOptions = new()
+    {
+        WriteIndented = true
+    };
+
     public static TObject DumpToConsole<TObject>(this TObject @object)
     {
         var output = "NULL";
         if (@object != null)
         {
-            output = JsonSerializer.Serialize(@object, new JsonSerializerOptions
-            {
-                WriteIndented = true
-            });
+            output = JsonSerializer.Serialize(@object, SerializerOptions);
         }
-        
+
         Console.WriteLine($"[{@object?.GetType().Name}]:\r\n{output}");
         return @object;
     }

Samples/MQTTnet.Samples.csproj

@@ -2,19 +2,10 @@
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net8.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <IsPackable>false</IsPackable>
-        <DisableImplicitAspNetCoreAnalyzers>true</DisableImplicitAspNetCoreAnalyzers>
-        <EnableNETAnalyzers>false</EnableNETAnalyzers>
-        <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
-        <NoWarn>1591;NETSDK1138;NU1803;NU1901;NU1902</NoWarn>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-        <NuGetAuditMode>all</NuGetAuditMode>
-        <NuGetAudit>true</NuGetAudit>
-        <NuGetAuditLevel>low</NuGetAuditLevel>
-        <AnalysisLevel>latest-Recommended</AnalysisLevel>
+        <NoWarn>$(NoWarn);CA1707</NoWarn>
     </PropertyGroup>
 
     <ItemGroup>

Samples/Program.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System.Globalization;
 using System.Reflection;
 
 Console.BackgroundColor = ConsoleColor.White;
@@ -28,7 +29,7 @@ Console.Write("Please choose sample class (press Enter to continue): ");
 Console.ResetColor();
 
 var input = Console.ReadLine();
-var selectedIndex = int.Parse(input ?? "0");
+var selectedIndex = int.Parse(input ?? "0", CultureInfo.InvariantCulture);
 var selectedSampleClass = sampleClasses[selectedIndex];
 var sampleMethods = selectedSampleClass.GetMethods(BindingFlags.Static | BindingFlags.Public).OrderBy(m => m.Name).ToList();
 
@@ -45,7 +46,7 @@ Console.Write("Please choose sample (press Enter to continue): ");
 Console.ResetColor();
 
 input = Console.ReadLine();
-selectedIndex = int.Parse(input ?? "0");
+selectedIndex = int.Parse(input ?? "0", CultureInfo.InvariantCulture);
 var selectedSampleMethod = sampleMethods[selectedIndex];
 
 Console.WriteLine();
@@ -58,7 +59,7 @@ try
 {
     if (selectedSampleMethod.Invoke(null, null) is Task task)
     {
-        await task;    
+        await task;
     }
 }
 catch (Exception exception)

Samples/RpcClient/RpcClient_Samples.cs

@@ -26,23 +26,21 @@ public static class RpcClient_Samples
         // The RPC client is an addon for the existing client. So we need a regular client
         // which is wrapped later.
 
-        using (var mqttClient = mqttFactory.CreateMqttClient())
+        using var mqttClient = mqttFactory.CreateMqttClient();
+        var mqttClientOptions = new MqttClientOptionsBuilder()
+            .WithTcpServer("broker.hivemq.com")
+            .Build();
+
+        await mqttClient.ConnectAsync(mqttClientOptions);
+
+        using (var mqttRpcClient = mqttFactory.CreateMqttRpcClient(mqttClient))
         {
-            var mqttClientOptions = new MqttClientOptionsBuilder()
-                .WithTcpServer("broker.hivemq.com")
-                .Build();
-
-            await mqttClient.ConnectAsync(mqttClientOptions);
-
-            using (var mqttRpcClient = mqttFactory.CreateMqttRpcClient(mqttClient))
-            {
-                // Access to a fully featured application message is not supported for RPC calls!
-                // The method will throw an exception when the response was not received in time.
-                await mqttRpcClient.ExecuteAsync(TimeSpan.FromSeconds(2), "ping", "", MqttQualityOfServiceLevel.AtMostOnce);
-            }
-
-            Console.WriteLine("The RPC call was successful.");
+            // Access to a fully featured application message is not supported for RPC calls!
+            // The method will throw an exception when the response was not received in time.
+            await mqttRpcClient.ExecuteAsync(TimeSpan.FromSeconds(2), "ping", "", MqttQualityOfServiceLevel.AtMostOnce);
         }
+
+        Console.WriteLine("The RPC call was successful.");
     }
 
     /*

Samples/Server/Server_ASP_NET_Samples.cs

@@ -8,6 +8,7 @@
 // ReSharper disable EmptyConstructor
 // ReSharper disable MemberCanBeMadeStatic.Local
 
+using System.Diagnostics.CodeAnalysis;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.DependencyInjection;
@@ -52,14 +53,14 @@ public static class Server_ASP_NET_Samples
             // Inject other services via constructor.
         }
 
-        public Task OnClientConnected(ClientConnectedEventArgs eventArgs)
+        public static Task OnClientConnected(ClientConnectedEventArgs eventArgs)
         {
             Console.WriteLine($"Client '{eventArgs.ClientId}' connected.");
             return Task.CompletedTask;
         }
 
 
-        public Task ValidateConnection(ValidatingConnectionEventArgs eventArgs)
+        public static Task ValidateConnection(ValidatingConnectionEventArgs eventArgs)
         {
             Console.WriteLine($"Client '{eventArgs.ClientId}' wants to connect. Accepting!");
             return Task.CompletedTask;
@@ -68,6 +69,7 @@ public static class Server_ASP_NET_Samples
 
     sealed class Startup
     {
+        [SuppressMessage("Performance", "CA1822:Mark members as static")]
         public void Configure(IApplicationBuilder app, IWebHostEnvironment environment, MqttController mqttController)
         {
             app.UseRouting();
@@ -88,11 +90,12 @@ public static class Server_ASP_NET_Samples
                      * Attach event handlers etc. if required.
                      */
 
-                    server.ValidatingConnectionAsync += mqttController.ValidateConnection;
-                    server.ClientConnectedAsync += mqttController.OnClientConnected;
+                    server.ValidatingConnectionAsync += MqttController.ValidateConnection;
+                    server.ClientConnectedAsync += MqttController.OnClientConnected;
                 });
         }
 
+        [SuppressMessage("Performance", "CA1822:Mark members as static")]
         public void ConfigureServices(IServiceCollection services)
         {
             services.AddHostedMqttServer(

Samples/Server/Server_Diagnostics_Samples.cs

@@ -25,28 +25,26 @@ public static class Server_Diagnostics_Samples
         var mqttServerFactory = new MqttServerFactory();
         var mqttServerOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();
 
-        using (var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions))
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        // Attach the event handler.
+        mqttServer.ClientAcknowledgedPublishPacketAsync += e =>
         {
-            // Attach the event handler.
-            mqttServer.ClientAcknowledgedPublishPacketAsync += e =>
-            {
-                Console.WriteLine($"Client '{e.ClientId}' acknowledged packet {e.PublishPacket.PacketIdentifier} with topic '{e.PublishPacket.Topic}'");
+            Console.WriteLine($"Client '{e.ClientId}' acknowledged packet {e.PublishPacket.PacketIdentifier} with topic '{e.PublishPacket.Topic}'");
 
-                // It is also possible to read additional data from the client response. This requires casting the response packet.
-                var qos1AcknowledgePacket = e.AcknowledgePacket as MqttPubAckPacket;
-                Console.WriteLine($"QoS 1 reason code: {qos1AcknowledgePacket?.ReasonCode}");
+            // It is also possible to read additional data from the client response. This requires casting the response packet.
+            var qos1AcknowledgePacket = e.AcknowledgePacket as MqttPubAckPacket;
+            Console.WriteLine($"QoS 1 reason code: {qos1AcknowledgePacket?.ReasonCode}");
 
-                var qos2AcknowledgePacket = e.AcknowledgePacket as MqttPubCompPacket;
-                Console.WriteLine($"QoS 2 reason code: {qos1AcknowledgePacket?.ReasonCode}");
-                return CompletedTask.Instance;
-            };
+            var qos2AcknowledgePacket = e.AcknowledgePacket as MqttPubCompPacket;
+            Console.WriteLine($"QoS 2 reason code: {qos2AcknowledgePacket?.ReasonCode}");
+            return CompletedTask.Instance;
+        };
 
-            await mqttServer.StartAsync();
+        await mqttServer.StartAsync();
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
 
-            await mqttServer.StopAsync();
-        }
+        await mqttServer.StopAsync();
     }
 }

Samples/Server/Server_Intercepting_Samples.cs

@@ -9,6 +9,7 @@
 // ReSharper disable MemberCanBeMadeStatic.Local
 
 using MQTTnet.Internal;
+using MQTTnet.Protocol;
 using MQTTnet.Server;
 
 namespace MQTTnet.Samples.Server;
@@ -25,23 +26,49 @@ public static class Server_Intercepting_Samples
         var mqttServerFactory = new MqttServerFactory();
         var mqttServerOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();
 
-        using (var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions))
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        mqttServer.InterceptingPublishAsync += args =>
         {
-            mqttServer.InterceptingPublishAsync += args =>
+            // Here we only change the topic of the received application message.
+            // but also changing the payload etc. is required. Changing the QoS after
+            // transmitting is not supported and makes no sense at all.
+            args.ApplicationMessage.Topic += "/manipulated";
+
+            return CompletedTask.Instance;
+        };
+
+        await mqttServer.StartAsync();
+
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
+        await mqttServer.StopAsync();
+    }
+
+    public static async Task Intercept_Subscription()
+    {
+        /*
+         * This sample starts a simple MQTT server which does not allow to subscribe to '#'
+         * Start the server and try to subscribe to '#' with a client of choice.
+         */
+
+        var mqttServerFactory = new MqttServerFactory();
+        var mqttServerOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();
+
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        mqttServer.InterceptingSubscriptionAsync += args =>
+        {
+            if (args.TopicFilter.Topic.Equals("#", StringComparison.Ordinal))
             {
-                // Here we only change the topic of the received application message.
-                // but also changing the payload etc. is required. Changing the QoS after
-                // transmitting is not supported and makes no sense at all.
-                args.ApplicationMessage.Topic += "/manipulated";
+                args.Response.ReasonCode = MqttSubscribeReasonCode.NotAuthorized;
+            }
 
-                return CompletedTask.Instance;
-            };
+            return CompletedTask.Instance;
+        };
 
-            await mqttServer.StartAsync();
+        await mqttServer.StartAsync();
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
-            await mqttServer.StopAsync();
-        }
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
+        await mqttServer.StopAsync();
     }
 }

Samples/Server/Server_Retained_Messages_Samples.cs

@@ -29,64 +29,62 @@ public static class Server_Retained_Messages_Samples
         // Due to security reasons the "default" endpoint (which is unencrypted) is not enabled by default!
         var mqttServerOptions = mqttServerFactory.CreateServerOptionsBuilder().WithDefaultEndpoint().Build();
 
-        using (var server = mqttServerFactory.CreateMqttServer(mqttServerOptions))
+        using var server = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        // Make sure that the server will load the retained messages.
+        server.LoadingRetainedMessageAsync += async eventArgs =>
         {
-            // Make sure that the server will load the retained messages.
-            server.LoadingRetainedMessageAsync += async eventArgs =>
+            try
             {
-                try
-                {
-                    var models = await JsonSerializer.DeserializeAsync<List<MqttRetainedMessageModel>>(File.OpenRead(storePath)) ?? new List<MqttRetainedMessageModel>();
-                    var retainedMessages = models.Select(m => m.ToApplicationMessage()).ToList();
+                var models = await JsonSerializer.DeserializeAsync<List<MqttRetainedMessageModel>>(File.OpenRead(storePath)) ?? new List<MqttRetainedMessageModel>();
+                var retainedMessages = models.Select(m => m.ToApplicationMessage()).ToList();
 
-                    eventArgs.LoadedRetainedMessages = retainedMessages;
-                    Console.WriteLine("Retained messages loaded.");
-                }
-                catch (FileNotFoundException)
-                {
-                    // Ignore because nothing is stored yet.
-                    Console.WriteLine("No retained messages stored yet.");
-                }
-                catch (Exception exception)
-                {
-                    Console.WriteLine(exception);
-                }
-            };
-
-            // Make sure to persist the changed retained messages.
-            server.RetainedMessageChangedAsync += async eventArgs =>
+                eventArgs.LoadedRetainedMessages = retainedMessages;
+                Console.WriteLine("Retained messages loaded.");
+            }
+            catch (FileNotFoundException)
             {
-                try
-                {
-                    // This sample uses the property _StoredRetainedMessages_ which will contain all(!) retained messages.
-                    // The event args also contain the affected retained message (property ChangedRetainedMessage). This can be
-                    // used to write all retained messages to dedicated files etc. Then all files must be loaded and a full list
-                    // of retained messages must be provided in the loaded event.
-
-                    var models = eventArgs.StoredRetainedMessages.Select(MqttRetainedMessageModel.Create);
-
-                    var buffer = JsonSerializer.SerializeToUtf8Bytes(models);
-                    await File.WriteAllBytesAsync(storePath, buffer);
-                    Console.WriteLine("Retained messages saved.");
-                }
-                catch (Exception exception)
-                {
-                    Console.WriteLine(exception);
-                }
-            };
-
-            // Make sure to clear the retained messages when they are all deleted via API.
-            server.RetainedMessagesClearedAsync += _ =>
+                // Ignore because nothing is stored yet.
+                Console.WriteLine("No retained messages stored yet.");
+            }
+            catch (Exception exception)
             {
-                File.Delete(storePath);
-                return Task.CompletedTask;
-            };
+                Console.WriteLine(exception);
+            }
+        };
 
-            await server.StartAsync();
+        // Make sure to persist the changed retained messages.
+        server.RetainedMessageChangedAsync += async eventArgs =>
+        {
+            try
+            {
+                // This sample uses the property _StoredRetainedMessages_ which will contain all(!) retained messages.
+                // The event args also contain the affected retained message (property ChangedRetainedMessage). This can be
+                // used to write all retained messages to dedicated files etc. Then all files must be loaded and a full list
+                // of retained messages must be provided in the loaded event.
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
-        }
+                var models = eventArgs.StoredRetainedMessages.Select(MqttRetainedMessageModel.Create);
+
+                var buffer = JsonSerializer.SerializeToUtf8Bytes(models);
+                await File.WriteAllBytesAsync(storePath, buffer);
+                Console.WriteLine("Retained messages saved.");
+            }
+            catch (Exception exception)
+            {
+                Console.WriteLine(exception);
+            }
+        };
+
+        // Make sure to clear the retained messages when they are all deleted via API.
+        server.RetainedMessagesClearedAsync += _ =>
+        {
+            File.Delete(storePath);
+            return Task.CompletedTask;
+        };
+
+        await server.StartAsync();
+
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
     }
 
     sealed class MqttRetainedMessageModel

Samples/Server/Server_Simple_Samples.cs

@@ -6,6 +6,7 @@
 // ReSharper disable UnusedMember.Global
 // ReSharper disable InconsistentNaming
 
+using System.Globalization;
 using MQTTnet.Diagnostics.Logger;
 using MQTTnet.Protocol;
 using MQTTnet.Server;
@@ -22,17 +23,15 @@ public static class Server_Simple_Samples
          * See _Run_Minimal_Server_ for more information.
          */
 
-        using (var mqttServer = await StartMqttServer())
-        {
-            // Let the client connect.
-            await Task.Delay(TimeSpan.FromSeconds(5));
+        using var mqttServer = await StartMqttServer();
+        // Let the client connect.
+        await Task.Delay(TimeSpan.FromSeconds(5));
 
-            // Now disconnect the client (if connected).
-            var affectedClient = (await mqttServer.GetClientsAsync()).FirstOrDefault(c => c.Id == "MyClient");
-            if (affectedClient != null)
-            {
-                await affectedClient.DisconnectAsync();
-            }
+        // Now disconnect the client (if connected).
+        var affectedClient = (await mqttServer.GetClientsAsync()).FirstOrDefault(c => c.Id == "MyClient");
+        if (affectedClient != null)
+        {
+            await affectedClient.DisconnectAsync();
         }
     }
 
@@ -44,18 +43,16 @@ public static class Server_Simple_Samples
          * See _Run_Minimal_Server_ for more information.
          */
 
-        using (var mqttServer = await StartMqttServer())
-        {
-            // Create a new message using the builder as usual.
-            var message = new MqttApplicationMessageBuilder().WithTopic("HelloWorld").WithPayload("Test").Build();
+        using var mqttServer = await StartMqttServer();
+        // Create a new message using the builder as usual.
+        var message = new MqttApplicationMessageBuilder().WithTopic("HelloWorld").WithPayload("Test").Build();
 
-            // Now inject the new message at the broker.
-            await mqttServer.InjectApplicationMessage(
-                new InjectedMqttApplicationMessage(message)
-                {
-                    SenderClientId = "SenderClientId"
-                });
-        }
+        // Now inject the new message at the broker.
+        await mqttServer.InjectApplicationMessage(
+            new InjectedMqttApplicationMessage(message)
+            {
+                SenderClientId = "SenderClientId"
+            });
     }
 
     public static async Task Run_Minimal_Server()
@@ -77,16 +74,14 @@ public static class Server_Simple_Samples
         //     .WithDefaultEndpointPort(1234)
         //     .Build();
 
-        using (var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions))
-        {
-            await mqttServer.StartAsync();
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        await mqttServer.StartAsync();
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
 
-            // Stop and dispose the MQTT server if it is no longer needed!
-            await mqttServer.StopAsync();
-        }
+        // Stop and dispose the MQTT server if it is no longer needed!
+        await mqttServer.StopAsync();
     }
 
     public static async Task Run_Server_With_Logging()
@@ -103,16 +98,14 @@ public static class Server_Simple_Samples
 
         var mqttServerOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();
 
-        using (var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions))
-        {
-            await mqttServer.StartAsync();
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        await mqttServer.StartAsync();
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
 
-            // Stop and dispose the MQTT server if it is no longer needed!
-            await mqttServer.StopAsync();
-        }
+        // Stop and dispose the MQTT server if it is no longer needed!
+        await mqttServer.StopAsync();
     }
 
     public static async Task Validating_Connections()
@@ -127,37 +120,35 @@ public static class Server_Simple_Samples
 
         var mqttServerOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();
 
-        using (var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions))
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        // Setup connection validation before starting the server so that there is
+        // no change to connect without valid credentials.
+        mqttServer.ValidatingConnectionAsync += e =>
         {
-            // Setup connection validation before starting the server so that there is
-            // no change to connect without valid credentials.
-            mqttServer.ValidatingConnectionAsync += e =>
+            if (e.ClientId != "ValidClientId")
             {
-                if (e.ClientId != "ValidClientId")
-                {
-                    e.ReasonCode = MqttConnectReasonCode.ClientIdentifierNotValid;
-                }
+                e.ReasonCode = MqttConnectReasonCode.ClientIdentifierNotValid;
+            }
 
-                if (e.UserName != "ValidUser")
-                {
-                    e.ReasonCode = MqttConnectReasonCode.BadUserNameOrPassword;
-                }
+            if (e.UserName != "ValidUser")
+            {
+                e.ReasonCode = MqttConnectReasonCode.BadUserNameOrPassword;
+            }
 
-                if (e.Password != "SecretPassword")
-                {
-                    e.ReasonCode = MqttConnectReasonCode.BadUserNameOrPassword;
-                }
+            if (e.Password != "SecretPassword")
+            {
+                e.ReasonCode = MqttConnectReasonCode.BadUserNameOrPassword;
+            }
 
-                return Task.CompletedTask;
-            };
+            return Task.CompletedTask;
+        };
 
-            await mqttServer.StartAsync();
+        await mqttServer.StartAsync();
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
 
-            await mqttServer.StopAsync();
-        }
+        await mqttServer.StopAsync();
     }
 
     static async Task<MqttServer> StartMqttServer()
@@ -171,7 +162,7 @@ public static class Server_Simple_Samples
         return server;
     }
 
-    class ConsoleLogger : IMqttNetLogger
+    sealed class ConsoleLogger : IMqttNetLogger
     {
         readonly object _consoleSyncRoot = new();
 
@@ -201,7 +192,7 @@ public static class Server_Simple_Samples
 
             if (parameters?.Length > 0)
             {
-                message = string.Format(message, parameters);
+                message = string.Format(CultureInfo.InvariantCulture, message, parameters);
             }
 
             lock (_consoleSyncRoot)

Samples/Server/Server_TLS_Samples.cs

@@ -31,16 +31,14 @@ public static class Server_TLS_Samples
 
         var mqttServerOptions = new MqttServerOptionsBuilder().WithEncryptionCertificate(certificate).WithEncryptedEndpoint().Build();
 
-        using (var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions))
-        {
-            await mqttServer.StartAsync();
+        using var mqttServer = mqttServerFactory.CreateMqttServer(mqttServerOptions);
+        await mqttServer.StartAsync();
 
-            Console.WriteLine("Press Enter to exit.");
-            Console.ReadLine();
+        Console.WriteLine("Press Enter to exit.");
+        Console.ReadLine();
 
-            // Stop and dispose the MQTT server if it is no longer needed!
-            await mqttServer.StopAsync();
-        }
+        // Stop and dispose the MQTT server if it is no longer needed!
+        await mqttServer.StopAsync();
     }
 
     static X509Certificate2 CreateSelfSignedCertificate(string oid)
@@ -50,26 +48,24 @@ public static class Server_TLS_Samples
         sanBuilder.AddIpAddress(IPAddress.IPv6Loopback);
         sanBuilder.AddDnsName("localhost");
 
-        using (var rsa = RSA.Create())
-        {
-            var certRequest = new CertificateRequest("CN=localhost", rsa, HashAlgorithmName.SHA512, RSASignaturePadding.Pkcs1);
+        using var rsa = RSA.Create();
+        var certRequest = new CertificateRequest("CN=localhost", rsa, HashAlgorithmName.SHA512, RSASignaturePadding.Pkcs1);
 
-            certRequest.CertificateExtensions.Add(
-                new X509KeyUsageExtension(X509KeyUsageFlags.DataEncipherment | X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature, false));
+        certRequest.CertificateExtensions.Add(
+            new X509KeyUsageExtension(X509KeyUsageFlags.DataEncipherment | X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature, false));
 
-            certRequest.CertificateExtensions.Add(new X509EnhancedKeyUsageExtension(new OidCollection { new(oid) }, false));
+        certRequest.CertificateExtensions.Add(new X509EnhancedKeyUsageExtension(new OidCollection { new(oid) }, false));
 
-            certRequest.CertificateExtensions.Add(sanBuilder.Build());
+        certRequest.CertificateExtensions.Add(sanBuilder.Build());
 
-            using (var certificate = certRequest.CreateSelfSigned(DateTimeOffset.Now.AddMinutes(-10), DateTimeOffset.Now.AddMinutes(10)))
-            {
-                var pfxCertificate = new X509Certificate2(
-                    certificate.Export(X509ContentType.Pfx),
-                    (string)null!,
-                    X509KeyStorageFlags.MachineKeySet | X509KeyStorageFlags.Exportable);
+        using var certificate = certRequest.CreateSelfSigned(DateTimeOffset.Now.AddMinutes(-10), DateTimeOffset.Now.AddMinutes(10));
+#pragma warning disable SYSLIB0057
+        var pfxCertificate = new X509Certificate2(
+            certificate.Export(X509ContentType.Pfx),
+            (string)null!,
+            X509KeyStorageFlags.MachineKeySet | X509KeyStorageFlags.Exportable);
+#pragma warning restore SYSLIB0057
 
-                return pfxCertificate;
-            }
-        }
+        return pfxCertificate;
     }
 }

Source/MQTTnet.AspTestApp/MQTTnet.AspTestApp.csproj

@@ -1,19 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
     <PropertyGroup>
-        <TargetFramework>net8.0</TargetFramework>
         <Nullable>enable</Nullable>
         <ImplicitUsings>enable</ImplicitUsings>
         <IsPackable>false</IsPackable>
-        <DisableImplicitAspNetCoreAnalyzers>true</DisableImplicitAspNetCoreAnalyzers>
-        <EnableNETAnalyzers>false</EnableNETAnalyzers>
-        <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
-        <NoWarn>1591;NETSDK1138;NU1803;NU1901;NU1902</NoWarn>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-        <NuGetAuditMode>all</NuGetAuditMode>
-        <NuGetAudit>true</NuGetAudit>
-        <NuGetAuditLevel>low</NuGetAuditLevel>
-        <AnalysisLevel>latest-Recommended</AnalysisLevel>
+        <NoWarn>$(NoWarn);CA1707</NoWarn>
     </PropertyGroup>
 
     <ItemGroup>

Source/MQTTnet.AspTestApp/Pages/Index.cshtml.cs

@@ -4,20 +4,22 @@
 
 using Microsoft.AspNetCore.Mvc.RazorPages;
 
-namespace MQTTnet.AspTestApp.Pages
+namespace MQTTnet.AspTestApp.Pages;
+
+public partial class IndexModel : PageModel
 {
-    public class IndexModel : PageModel
+    readonly ILogger<IndexModel> _logger;
+
+    public IndexModel(ILogger<IndexModel> logger)
     {
-        private readonly ILogger<IndexModel> _logger;
-
-        public IndexModel(ILogger<IndexModel> logger)
-        {
-            _logger = logger;
-        }
-
-        public void OnGet()
-        {
-
-        }
+        _logger = logger;
     }
+
+    public void OnGet()
+    {
+        LogOnGet();
+    }
+
+    [LoggerMessage(Level = LogLevel.Information, Message = "OnGet")]
+    private partial void LogOnGet();
 }

Source/MQTTnet.AspnetCore/ApplicationBuilderExtensions.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
 using MQTTnet.Server;
@@ -33,10 +32,8 @@ public static class ApplicationBuilderExtensions
                 }
 
                 var adapter = app.ApplicationServices.GetRequiredService<MqttWebSocketServerAdapter>();
-                using (var webSocket = await context.WebSockets.AcceptWebSocketAsync(subProtocol).ConfigureAwait(false))
-                {
-                    await adapter.RunWebSocketConnectionAsync(webSocket, context);
-                }
+                using var webSocket = await context.WebSockets.AcceptWebSocketAsync(subProtocol).ConfigureAwait(false);
+                await adapter.RunWebSocketConnectionAsync(webSocket, context);
             });
 
         return app;

Source/MQTTnet.AspnetCore/AspNetMqttServerOptionsBuilder.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using MQTTnet.Server;
 
 namespace MQTTnet.AspNetCore;

Source/MQTTnet.AspnetCore/BufferExtensions.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Runtime.InteropServices;
 
 namespace MQTTnet.AspNetCore;

Source/MQTTnet.AspnetCore/ConnectionBuilderExtensions.cs

@@ -4,13 +4,12 @@
 
 using Microsoft.AspNetCore.Connections;
 
-namespace MQTTnet.AspNetCore
+namespace MQTTnet.AspNetCore;
+
+public static class ConnectionBuilderExtensions
 {
-    public static class ConnectionBuilderExtensions
+    public static IConnectionBuilder UseMqtt(this IConnectionBuilder builder)
     {
-        public static IConnectionBuilder UseMqtt(this IConnectionBuilder builder)
-        {
-            return builder.UseConnectionHandler<MqttConnectionHandler>();
-        }
+        return builder.UseConnectionHandler<MqttConnectionHandler>();
     }
-}
+}

Source/MQTTnet.AspnetCore/EndpointRouterExtensions.cs

@@ -2,23 +2,20 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Routing;
 
-namespace MQTTnet.AspNetCore
+namespace MQTTnet.AspNetCore;
+
+public static class EndpointRouterExtensions
 {
-    public static class EndpointRouterExtensions
+    public static void MapMqtt(this IEndpointRouteBuilder endpoints, string pattern)
     {
-        public static void MapMqtt(this IEndpointRouteBuilder endpoints, string pattern)
+        ArgumentNullException.ThrowIfNull(endpoints);
+
+        endpoints.MapConnectionHandler<MqttConnectionHandler>(pattern, options =>
         {
-            ArgumentNullException.ThrowIfNull(endpoints);
-
-            endpoints.MapConnectionHandler<MqttConnectionHandler>(pattern, options =>
-            {
-                options.WebSockets.SubProtocolSelector = MqttSubProtocolSelector.SelectSubProtocol;
-            });
-        }
+            options.WebSockets.SubProtocolSelector = MqttSubProtocolSelector.SelectSubProtocol;
+        });
     }
-}
-
+}

Source/MQTTnet.AspnetCore/MQTTnet.AspNetCore.csproj

@@ -1,60 +1,23 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net8.0</TargetFramework>
         <AssemblyName>MQTTnet.AspNetCore</AssemblyName>
         <RootNamespace>MQTTnet.AspNetCore</RootNamespace>
-        <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-        <Company>The contributors of MQTTnet</Company>
-        <Product>MQTTnet</Product>
+        <IsAotCompatible>true</IsAotCompatible>
+
+        <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <Description>MQTTnet is a high performance .NET library for MQTT based communication. It provides a MQTT client and a MQTT server (broker) and supports v3.1.0, v3.1.1 and v5.0.0 of the MQTT protocol.</Description>
-        <Authors>The contributors of MQTTnet</Authors>
         <PackageId>MQTTnet.AspNetCore</PackageId>
-        <SignAssembly>false</SignAssembly>
-        <DelaySign>false</DelaySign>
-        <PublishRepositoryUrl>true</PublishRepositoryUrl>
-        <IncludeSymbols>true</IncludeSymbols>
-        <SymbolPackageFormat>snupkg</SymbolPackageFormat>
-        <Copyright>Copyright (c) .NET Foundation and Contributors</Copyright>
-        <PackageProjectUrl>https://github.com/dotnet/MQTTnet</PackageProjectUrl>
-        <RepositoryUrl>https://github.com/dotnet/MQTTnet.git</RepositoryUrl>
-        <RepositoryType>git</RepositoryType>
         <PackageTags>MQTT Message Queue Telemetry Transport MQTTClient MQTTServer Server MQTTBroker Broker NETStandard IoT InternetOfThings Messaging Hardware Arduino Sensor Actuator M2M ESP Smart Home Cities Automation Xamarin Blazor</PackageTags>
-        <NeutralLanguage>en-US</NeutralLanguage>
-        <EnableNETAnalyzers>false</EnableNETAnalyzers>
-        <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
-        <PackageIcon>nuget.png</PackageIcon>
-        <EmbedUntrackedSources>true</EmbedUntrackedSources>
-        <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
-        <PackageLicenseExpression>MIT</PackageLicenseExpression>
         <PackageReleaseNotes>For release notes please go to MQTTnet release notes (https://www.nuget.org/packages/MQTTnet/).</PackageReleaseNotes>
-        <DisableImplicitAspNetCoreAnalyzers>true</DisableImplicitAspNetCoreAnalyzers>
-        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
-        <NoWarn>1591;NETSDK1138;NU1803;NU1901;NU1902</NoWarn>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-        <NuGetAuditMode>all</NuGetAuditMode>
-        <NuGetAudit>true</NuGetAudit>
-        <NuGetAuditLevel>low</NuGetAuditLevel>
-        <NuGetAuditLevel>low</NuGetAuditLevel>
-        <AnalysisLevel>latest-Recommended</AnalysisLevel>
     </PropertyGroup>
 
     <ItemGroup>
-        <None Include="..\..\Images\nuget.png">
-            <Pack>True</Pack>
-            <PackagePath>\</PackagePath>
-        </None>
-    </ItemGroup>
-
-    <ItemGroup>
-        <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
         <FrameworkReference Include="Microsoft.AspNetCore.App"/>
     </ItemGroup>
 
-    <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release'">
-    </PropertyGroup>
-
     <ItemGroup>
         <ProjectReference Include="..\MQTTnet.Server\MQTTnet.Server.csproj"/>
         <ProjectReference Include="..\MQTTnet\MQTTnet.csproj"/>

Source/MQTTnet.AspnetCore/MqttClientConnectionContextFactory.cs

@@ -2,33 +2,31 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using MQTTnet.Adapter;
 using MQTTnet.Diagnostics.Logger;
 using MQTTnet.Formatter;
 
-namespace MQTTnet.AspNetCore
+namespace MQTTnet.AspNetCore;
+
+public sealed class MqttClientConnectionContextFactory : IMqttClientAdapterFactory
 {
-    public sealed class MqttClientConnectionContextFactory : IMqttClientAdapterFactory
+    public IMqttChannelAdapter CreateClientAdapter(MqttClientOptions options, MqttPacketInspector packetInspector, IMqttNetLogger logger)
     {
-        public IMqttChannelAdapter CreateClientAdapter(MqttClientOptions options, MqttPacketInspector packetInspector, IMqttNetLogger logger)
+        ArgumentNullException.ThrowIfNull(options);
+
+        switch (options.ChannelOptions)
         {
-            if (options == null) throw new ArgumentNullException(nameof(options));
-
-            switch (options.ChannelOptions)
+            case MqttClientTcpOptions tcpOptions:
             {
-                case MqttClientTcpOptions tcpOptions:
-                    {
-                        var tcpConnection = new SocketConnection(tcpOptions.RemoteEndpoint);
+                var tcpConnection = new SocketConnection(tcpOptions.RemoteEndpoint);
 
-                        var formatter = new MqttPacketFormatterAdapter(options.ProtocolVersion, new MqttBufferWriter(4096, 65535));
-                        return new MqttConnectionContext(formatter, tcpConnection);
-                    }
-                default:
-                    {
-                        throw new NotSupportedException();
-                    }
+                var formatter = new MqttPacketFormatterAdapter(options.ProtocolVersion, new MqttBufferWriter(4096, 65535));
+                return new MqttConnectionContext(formatter, tcpConnection);
+            }
+            default:
+            {
+                throw new NotSupportedException();
             }
         }
     }
-}
+}

Source/MQTTnet.AspnetCore/MqttConnectionContext.cs

@@ -2,13 +2,10 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Buffers;
 using System.IO.Pipelines;
 using System.Net;
 using System.Security.Cryptography.X509Certificates;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Connections;
 using Microsoft.AspNetCore.Http.Connections.Features;
 using Microsoft.AspNetCore.Http.Features;
@@ -61,27 +58,6 @@ public sealed class MqttConnectionContext : IMqttChannelAdapter
         }
     }
 
-    public EndPoint RemoteEndPoint
-    {
-        get
-        {
-            // mqtt over tcp
-            if (_connection.RemoteEndPoint != null)
-            {
-                return _connection.RemoteEndPoint;
-            }
-
-            // mqtt over websocket
-            var httpFeature = _connection.Features.Get<IHttpConnectionFeature>();
-            if (httpFeature?.RemoteIpAddress != null)
-            {
-                return new IPEndPoint(httpFeature.RemoteIpAddress, httpFeature.RemotePort);
-            }
-
-            return null;
-        }
-    }
-
     public bool IsSecureConnection
     {
         get
@@ -104,8 +80,50 @@ public sealed class MqttConnectionContext : IMqttChannelAdapter
         }
     }
 
+    public EndPoint LocalEndPoint
+    {
+        get
+        {
+            // mqtt over tcp
+            if (_connection.LocalEndPoint != null)
+            {
+                return _connection.LocalEndPoint;
+            }
+
+            // mqtt over websocket
+            var httpFeature = _connection.Features.Get<IHttpConnectionFeature>();
+            if (httpFeature?.LocalIpAddress != null)
+            {
+                return new IPEndPoint(httpFeature.LocalIpAddress, httpFeature.LocalPort);
+            }
+
+            return null;
+        }
+    }
+
     public MqttPacketFormatterAdapter PacketFormatterAdapter { get; }
 
+    public EndPoint RemoteEndPoint
+    {
+        get
+        {
+            // mqtt over tcp
+            if (_connection.RemoteEndPoint != null)
+            {
+                return _connection.RemoteEndPoint;
+            }
+
+            // mqtt over websocket
+            var httpFeature = _connection.Features.Get<IHttpConnectionFeature>();
+            if (httpFeature?.RemoteIpAddress != null)
+            {
+                return new IPEndPoint(httpFeature.RemoteIpAddress, httpFeature.RemotePort);
+            }
+
+            return null;
+        }
+    }
+
     public async Task ConnectAsync(CancellationToken cancellationToken)
     {
         if (_connection is SocketConnection tcp && !tcp.IsConnected)
@@ -232,8 +250,8 @@ public sealed class MqttConnectionContext : IMqttChannelAdapter
         var span = output.GetSpan(buffer.Length);
 
         buffer.Packet.AsSpan().CopyTo(span);
-        int offset = buffer.Packet.Count;
-        buffer.Payload.CopyTo(destination: span.Slice(offset));
+        var offset = buffer.Packet.Count;
+        buffer.Payload.CopyTo(span.Slice(offset));
         output.Advance(buffer.Length);
     }
 }

Source/MQTTnet.AspnetCore/MqttConnectionHandler.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Connections;
 using Microsoft.AspNetCore.Connections.Features;
 using MQTTnet.Adapter;
@@ -33,13 +31,11 @@ public sealed class MqttConnectionHandler : ConnectionHandler, IMqttServerAdapte
         }
 
         var formatter = new MqttPacketFormatterAdapter(new MqttBufferWriter(_serverOptions.WriterBufferSize, _serverOptions.WriterBufferSizeMax));
-        using (var adapter = new MqttConnectionContext(formatter, connection))
+        using var adapter = new MqttConnectionContext(formatter, connection);
+        var clientHandler = ClientHandler;
+        if (clientHandler != null)
         {
-            var clientHandler = ClientHandler;
-            if (clientHandler != null)
-            {
-                await clientHandler(adapter).ConfigureAwait(false);
-            }
+            await clientHandler(adapter).ConfigureAwait(false);
         }
     }
 

Source/MQTTnet.AspnetCore/MqttHostedServer.cs

@@ -2,10 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.Extensions.Hosting;
 using MQTTnet.Diagnostics.Logger;
 using MQTTnet.Server;

Source/MQTTnet.AspnetCore/MqttSubProtocolSelector.cs

@@ -2,9 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Microsoft.AspNetCore.Http;
 
 namespace MQTTnet.AspNetCore;
@@ -29,6 +26,6 @@ public static class MqttSubProtocolSelector
         ArgumentNullException.ThrowIfNull(requestedSubProtocolValues);
 
         // Order the protocols to also match "mqtt", "mqttv-3.1", "mqttv-3.11" etc.
-        return requestedSubProtocolValues.OrderByDescending(p => p.Length).FirstOrDefault(p => p.ToLower().StartsWith("mqtt"));
+        return requestedSubProtocolValues.OrderByDescending(p => p.Length).FirstOrDefault(p => p.ToLowerInvariant().StartsWith("mqtt", StringComparison.InvariantCulture));
     }
 }

Source/MQTTnet.AspnetCore/MqttWebSocketServerAdapter.cs

@@ -2,10 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Net;
 using System.Net.WebSockets;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
 using MQTTnet.Adapter;
 using MQTTnet.Diagnostics.Logger;
@@ -43,10 +41,8 @@ public sealed class MqttWebSocketServerAdapter : IMqttServerAdapter
                 var formatter = new MqttPacketFormatterAdapter(new MqttBufferWriter(4096, 65535));
                 var channel = new MqttWebSocketChannel(webSocket, remoteEndPoint, isSecureConnection, clientCertificate);
 
-                using (var channelAdapter = new MqttChannelAdapter(channel, formatter, _logger))
-                {
-                    await clientHandler(channelAdapter).ConfigureAwait(false);
-                }
+                using var channelAdapter = new MqttChannelAdapter(channel, formatter, _logger);
+                await clientHandler(channelAdapter).ConfigureAwait(false);
             }
         }
         finally

Source/MQTTnet.AspnetCore/ReaderExtensions.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Buffers;
 using System.Runtime.InteropServices;
 using MQTTnet.Adapter;

Source/MQTTnet.AspnetCore/ServiceCollectionExtensions.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Hosting;

Source/MQTTnet.AspnetCore/SocketAwaitable.cs

@@ -2,44 +2,35 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Diagnostics;
 using System.IO.Pipelines;
 using System.Net.Sockets;
 using System.Runtime.CompilerServices;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace MQTTnet.AspNetCore;
 
-public class SocketAwaitable : ICriticalNotifyCompletion
+public class SocketAwaitable(PipeScheduler ioScheduler) : ICriticalNotifyCompletion
 {
-    static readonly Action _callbackCompleted = () =>
+    static readonly Action CallbackCompleted = () =>
     {
     };
 
-    readonly PipeScheduler _ioScheduler;
     int _bytesTransferred;
 
     Action _callback;
     SocketError _error;
 
-    public SocketAwaitable(PipeScheduler ioScheduler)
-    {
-        _ioScheduler = ioScheduler;
-    }
-
-    public bool IsCompleted => ReferenceEquals(_callback, _callbackCompleted);
+    public bool IsCompleted => ReferenceEquals(_callback, CallbackCompleted);
 
     public void Complete(int bytesTransferred, SocketError socketError)
     {
         _error = socketError;
         _bytesTransferred = bytesTransferred;
-        var continuation = Interlocked.Exchange(ref _callback, _callbackCompleted);
+        var continuation = Interlocked.Exchange(ref _callback, CallbackCompleted);
 
         if (continuation != null)
         {
-            _ioScheduler.Schedule(state => ((Action)state)(), continuation);
+            ioScheduler.Schedule(state => ((Action)state)(), continuation);
         }
     }
 
@@ -50,7 +41,7 @@ public class SocketAwaitable : ICriticalNotifyCompletion
 
     public int GetResult()
     {
-        Debug.Assert(ReferenceEquals(_callback, _callbackCompleted));
+        Debug.Assert(ReferenceEquals(_callback, CallbackCompleted));
 
         _callback = null;
 
@@ -64,7 +55,7 @@ public class SocketAwaitable : ICriticalNotifyCompletion
 
     public void OnCompleted(Action continuation)
     {
-        if (ReferenceEquals(_callback, _callbackCompleted) || ReferenceEquals(Interlocked.CompareExchange(ref _callback, continuation, null), _callbackCompleted))
+        if (ReferenceEquals(_callback, CallbackCompleted) || ReferenceEquals(Interlocked.CompareExchange(ref _callback, continuation, null), CallbackCompleted))
         {
             Task.Run(continuation);
         }

Source/MQTTnet.AspnetCore/SocketConnection.cs

@@ -2,13 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.IO;
 using System.IO.Pipelines;
 using System.Net;
 using System.Net.Sockets;
-using System.Threading.Tasks;
 using Microsoft.AspNetCore.Connections;
 using Microsoft.AspNetCore.Http.Features;
 using MQTTnet.Exceptions;
@@ -18,11 +14,11 @@ namespace MQTTnet.AspNetCore;
 public sealed class SocketConnection : ConnectionContext
 {
     readonly EndPoint _endPoint;
+
     volatile bool _aborted;
     IDuplexPipe _application;
     SocketReceiver _receiver;
     SocketSender _sender;
-
     Socket _socket;
 
     public SocketConnection(EndPoint endPoint)
@@ -40,10 +36,13 @@ public sealed class SocketConnection : ConnectionContext
     }
 
     public override string ConnectionId { get; set; }
+
     public override IFeatureCollection Features { get; }
 
     public bool IsConnected { get; private set; }
+
     public override IDictionary<object, object> Items { get; set; }
+
     public override IDuplexPipe Transport { get; set; }
 
     public override ValueTask DisposeAsync()
@@ -78,7 +77,7 @@ public sealed class SocketConnection : ConnectionContext
         IsConnected = true;
     }
 
-    Exception ConnectionAborted()
+    static MqttCommunicationException ConnectionAborted()
     {
         return new MqttCommunicationException("Connection Aborted");
     }
@@ -95,8 +94,7 @@ public sealed class SocketConnection : ConnectionContext
         {
             error = new MqttCommunicationException(ex);
         }
-        catch (SocketException ex) when (ex.SocketErrorCode == SocketError.OperationAborted || ex.SocketErrorCode == SocketError.ConnectionAborted ||
-                                         ex.SocketErrorCode == SocketError.Interrupted || ex.SocketErrorCode == SocketError.InvalidArgument)
+        catch (SocketException ex) when (ex.SocketErrorCode is SocketError.OperationAborted or SocketError.ConnectionAborted or SocketError.Interrupted or SocketError.InvalidArgument)
         {
             if (!_aborted)
             {
@@ -123,10 +121,10 @@ public sealed class SocketConnection : ConnectionContext
         {
             if (_aborted)
             {
-                error = error ?? ConnectionAborted();
+                error ??= ConnectionAborted();
             }
 
-            _application.Output.Complete(error);
+            await _application.Output.CompleteAsync(error);
         }
     }
 
@@ -216,12 +214,16 @@ public sealed class SocketConnection : ConnectionContext
 
             var flushTask = _application.Output.FlushAsync();
 
+            FlushResult result;
             if (!flushTask.IsCompleted)
             {
-                await flushTask;
+                result = await flushTask;
+            }
+            else
+            {
+                result = flushTask.GetAwaiter().GetResult();
             }
 
-            var result = flushTask.GetAwaiter().GetResult();
             if (result.IsCompleted)
             {
                 // Pipe consumer is shut down, do we stop writing

Source/MQTTnet.AspnetCore/SocketReceiver.cs

@@ -2,13 +2,12 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.IO.Pipelines;
 using System.Net.Sockets;
 
 namespace MQTTnet.AspNetCore;
 
-public sealed class SocketReceiver
+public sealed class SocketReceiver : IDisposable
 {
     readonly SocketAwaitable _awaitable;
     readonly SocketAsyncEventArgs _eventArgs = new();
@@ -33,4 +32,9 @@ public sealed class SocketReceiver
 
         return _awaitable;
     }
+
+    public void Dispose()
+    {
+        _eventArgs.Dispose();
+    }
 }

Source/MQTTnet.AspnetCore/SocketSender.cs

@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Buffers;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO.Pipelines;
 using System.Net.Sockets;
@@ -12,7 +10,7 @@ using System.Runtime.InteropServices;
 
 namespace MQTTnet.AspNetCore;
 
-public sealed class SocketSender
+public sealed class SocketSender : IDisposable
 {
     readonly SocketAwaitable _awaitable;
     readonly SocketAsyncEventArgs _eventArgs = new();
@@ -28,6 +26,11 @@ public sealed class SocketSender
         _eventArgs.Completed += (_, e) => ((SocketAwaitable)e.UserToken).Complete(e.BytesTransferred, e.SocketError);
     }
 
+    public void Dispose()
+    {
+        _eventArgs.Dispose();
+    }
+
     public SocketAwaitable SendAsync(in ReadOnlySequence<byte> buffers)
     {
         if (buffers.IsSingleSegment)

Source/MQTTnet.Benchmarks/AssemblyInfo.cs

@@ -0,0 +1 @@
+[assembly: DoNotParallelize]

Source/MQTTnet.Benchmarks/AsyncLockBenchmark.cs

@@ -2,64 +2,58 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Internal;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[MemoryDiagnoser]
+public class AsyncLockBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [MemoryDiagnoser]
-    public class AsyncLockBenchmark : BaseBenchmark
+    [Benchmark]
+    public async Task Synchronize_100_Tasks()
     {
-        [Benchmark]
-        public async Task Synchronize_100_Tasks()
+        const int tasksCount = 100;
+
+        var tasks = new Task[tasksCount];
+        var asyncLock = new AsyncLock();
+        var globalI = 0;
+
+        for (var i = 0; i < tasksCount; i++)
         {
-            const int tasksCount = 100;
-
-            var tasks = new Task[tasksCount];
-            var asyncLock = new AsyncLock();
-            var globalI = 0;
-
-            for (var i = 0; i < tasksCount; i++)
-            {
-                tasks[i] = Task.Run(
-                    async () =>
-                    {
-                        using (await asyncLock.EnterAsync().ConfigureAwait(false))
-                        {
-                            var localI = globalI;
-                            await Task.Delay(5).ConfigureAwait(false); // Increase the chance for wrong data.
-                            localI++;
-                            globalI = localI;
-                        }
-                    });
-            }
-
-            await Task.WhenAll(tasks).ConfigureAwait(false);
-
-            if (globalI != tasksCount)
-            {
-                throw new Exception($"Code is broken ({globalI})!");
-            }
-        }
-        
-        [Benchmark]
-        public async Task Wait_100_000_Times()
-        {
-            var asyncLock = new AsyncLock();
-
-            using (var cancellationToken = new CancellationTokenSource())
-            {
-                for (var i = 0; i < 100000; i++)
+            tasks[i] = Task.Run(
+                async () =>
                 {
-                    using (await asyncLock.EnterAsync(cancellationToken.Token).ConfigureAwait(false))
+                    using (await asyncLock.EnterAsync().ConfigureAwait(false))
                     {
+                        var localI = globalI;
+                        await Task.Delay(5).ConfigureAwait(false); // Increase the chance for wrong data.
+                        localI++;
+                        globalI = localI;
                     }
-                }
+                });
+        }
+
+        await Task.WhenAll(tasks).ConfigureAwait(false);
+
+        if (globalI != tasksCount)
+        {
+            throw new InvalidOperationException($"Code is broken ({globalI})!");
+        }
+    }
+
+    [Benchmark]
+    public async Task Wait_100_000_Times()
+    {
+        var asyncLock = new AsyncLock();
+
+        using var cancellationToken = new CancellationTokenSource();
+        for (var i = 0; i < 100000; i++)
+        {
+            using (await asyncLock.EnterAsync(cancellationToken.Token).ConfigureAwait(false))
+            {
             }
         }
     }

Source/MQTTnet.Benchmarks/BaseBenchmark.cs

@@ -2,9 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+public abstract class BaseBenchmark
 {
-    public abstract class BaseBenchmark
-    {
-    }
 }

Source/MQTTnet.Benchmarks/ChannelAdapterBenchmark.cs

@@ -2,9 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.IO;
-using System.Threading;
 using BenchmarkDotNet.Attributes;
 using MQTTnet.Adapter;
 using MQTTnet.Diagnostics.Logger;
@@ -12,79 +9,84 @@ using MQTTnet.Formatter;
 using MQTTnet.Packets;
 using MQTTnet.Tests.Mockups;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[MemoryDiagnoser]
+public sealed class ChannelAdapterBenchmark : BaseBenchmark, IDisposable
 {
-    [MemoryDiagnoser]
-    public sealed class ChannelAdapterBenchmark : BaseBenchmark
+    MqttChannelAdapter _channelAdapter;
+    int _iterations;
+    MqttPublishPacket _packet;
+    MemoryStream _stream;
+
+    [Benchmark]
+    public void Receive_10000_Messages()
     {
-        MqttChannelAdapter _channelAdapter;
-        int _iterations;
-        MqttPublishPacket _packet;
-        MemoryStream _stream;
+        _stream.Position = 0;
 
-        [Benchmark]
-        public void Receive_10000_Messages()
+        for (var i = 0; i < 10000; i++)
         {
-            _stream.Position = 0;
-
-            for (var i = 0; i < 10000; i++)
-            {
-                _channelAdapter.ReceivePacketAsync(CancellationToken.None).GetAwaiter().GetResult();
-            }
-
-            _stream.Position = 0;
+            _channelAdapter.ReceivePacketAsync(CancellationToken.None).GetAwaiter().GetResult();
         }
 
-        [Benchmark]
-        public void Send_10000_Messages()
+        _stream.Position = 0;
+    }
+
+    [Benchmark]
+    public void Send_10000_Messages()
+    {
+        _stream.Position = 0;
+
+        for (var i = 0; i < 10000; i++)
         {
-            _stream.Position = 0;
-
-            for (var i = 0; i < 10000; i++)
-            {
-                _channelAdapter.SendPacketAsync(_packet, CancellationToken.None).GetAwaiter().GetResult();
-            }
-
-            _stream.Position = 0;
+            _channelAdapter.SendPacketAsync(_packet, CancellationToken.None).GetAwaiter().GetResult();
         }
 
-        [GlobalSetup]
-        public void Setup()
+        _stream.Position = 0;
+    }
+
+    [GlobalSetup]
+    public void Setup()
+    {
+        _packet = new MqttPublishPacket
         {
-            _packet = new MqttPublishPacket
-            {
-                Topic = "A"
-            };
+            Topic = "A"
+        };
 
-            var serializer = new MqttPacketFormatterAdapter(MqttProtocolVersion.V311, new MqttBufferWriter(4096, 65535));
+        var serializer = new MqttPacketFormatterAdapter(MqttProtocolVersion.V311, new MqttBufferWriter(4096, 65535));
 
-            var serializedPacket = Join(serializer.Encode(_packet).Join());
+        var serializedPacket = Join(serializer.Encode(_packet).Join());
 
-            _iterations = 10000;
+        _iterations = 10000;
 
-            _stream = new MemoryStream(_iterations * serializedPacket.Length);
+        _stream = new MemoryStream(_iterations * serializedPacket.Length);
 
-            for (var i = 0; i < _iterations; i++)
-            {
-                _stream.Write(serializedPacket, 0, serializedPacket.Length);
-            }
-
-            _stream.Position = 0;
-
-            var channel = new MemoryMqttChannel(_stream);
-
-            _channelAdapter = new MqttChannelAdapter(channel, serializer, new MqttNetEventLogger());
+        for (var i = 0; i < _iterations; i++)
+        {
+            _stream.Write(serializedPacket, 0, serializedPacket.Length);
         }
 
-        static byte[] Join(params ArraySegment<byte>[] chunks)
-        {
-            var buffer = new MemoryStream();
-            foreach (var chunk in chunks)
-            {
-                buffer.Write(chunk.Array, chunk.Offset, chunk.Count);
-            }
+        _stream.Position = 0;
 
-            return buffer.ToArray();
+        var channel = new MemoryMqttChannel(_stream);
+
+        _channelAdapter = new MqttChannelAdapter(channel, serializer, new MqttNetEventLogger());
+    }
+
+    static byte[] Join(params ArraySegment<byte>[] chunks)
+    {
+        var buffer = new MemoryStream();
+        foreach (var chunk in chunks)
+        {
+            buffer.Write(chunk.Array, chunk.Offset, chunk.Count);
         }
+
+        return buffer.ToArray();
+    }
+
+    public void Dispose()
+    {
+        _channelAdapter?.Dispose();
+        _stream?.Dispose();
     }
 }

Source/MQTTnet.Benchmarks/LoggerBenchmark.cs

@@ -2,90 +2,90 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System.Diagnostics;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Diagnostics.Logger;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter]
+[MemoryDiagnoser]
+public class LoggerBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter]
-    [MemoryDiagnoser]
-    public class LoggerBenchmark : BaseBenchmark
+    MqttNetNullLogger _nullLogger;
+    MqttNetSourceLogger _sourceNullLogger;
+
+    MqttNetEventLogger _eventLogger;
+    MqttNetSourceLogger _sourceEventLogger;
+
+    MqttNetEventLogger _eventLoggerNoListener;
+    MqttNetSourceLogger _sourceEventLoggerNoListener;
+
+    bool _useHandler;
+
+    [GlobalSetup]
+    public void Setup()
     {
-        MqttNetNullLogger _nullLogger;
-        MqttNetSourceLogger _sourceNullLogger;
+        _nullLogger = new MqttNetNullLogger();
+        _sourceNullLogger = _nullLogger.WithSource("Source");
 
-        MqttNetEventLogger _eventLogger;
-        MqttNetSourceLogger _sourceEventLogger;
+        _eventLogger = new MqttNetEventLogger();
+        _eventLogger.LogMessagePublished += OnLogMessagePublished;
+        _sourceEventLogger = _eventLogger.WithSource("Source");
 
-        MqttNetEventLogger _eventLoggerNoListener;
-        MqttNetSourceLogger _sourceEventLoggerNoListener;
+        _eventLoggerNoListener = new MqttNetEventLogger();
+        _sourceEventLoggerNoListener = _eventLoggerNoListener.WithSource("Source");
+    }
 
-        bool _useHandler;
-
-        [GlobalSetup]
-        public void Setup()
+    void OnLogMessagePublished(object sender, MqttNetLogMessagePublishedEventArgs eventArgs)
+    {
+        if (_useHandler)
         {
-            _nullLogger = new MqttNetNullLogger();
-            _sourceNullLogger = _nullLogger.WithSource("Source");
-
-            _eventLogger = new MqttNetEventLogger();
-            _eventLogger.LogMessagePublished += OnLogMessagePublished;
-            _sourceEventLogger = _eventLogger.WithSource("Source");
-
-            _eventLoggerNoListener = new MqttNetEventLogger();
-            _sourceEventLoggerNoListener = _eventLoggerNoListener.WithSource("Source");
-        }
-
-        void OnLogMessagePublished(object sender, MqttNetLogMessagePublishedEventArgs eventArgs)
-        {
-            if (_useHandler)
-            {
-                eventArgs.LogMessage.ToString();
-            }
-        }
-
-        [Benchmark]
-        public void Log_10000_Messages_No_Listener()
-        {
-            _useHandler = false;
-
-            for (var i = 0; i < 10000; i++)
-            {
-                _sourceEventLoggerNoListener.Verbose("test log message {0}", "parameter");
-            }
-        }
-
-        [Benchmark]
-        public void Log_10000_Messages_With_To_String()
-        {
-            _useHandler = true;
-
-            for (var i = 0; i < 10000; i++)
-            {
-                _sourceEventLogger.Verbose("test log message {0}", "parameter");
-            }
-        }
-
-        [Benchmark]
-        public void Log_10000_Messages_Without_To_String()
-        {
-            _useHandler = false;
-
-            for (var i = 0; i < 10000; i++)
-            {
-                _sourceEventLogger.Verbose("test log message {0}", "parameter");
-            }
-        }
-
-        [Benchmark]
-        public void Log_10000_Messages_With_NullLogger()
-        {
-            for (var i = 0; i < 10000; i++)
-            {
-                _sourceNullLogger.Verbose("test log message {0}", "parameter");
-            }
+            Debug.WriteLine(eventArgs.LogMessage.ToString());
         }
     }
-}
+
+    [Benchmark]
+    public void Log_10000_Messages_No_Listener()
+    {
+        _useHandler = false;
+
+        for (var i = 0; i < 10000; i++)
+        {
+            _sourceEventLoggerNoListener.Verbose("test log message {0}", "parameter");
+        }
+    }
+
+    [Benchmark]
+    public void Log_10000_Messages_With_To_String()
+    {
+        _useHandler = true;
+
+        for (var i = 0; i < 10000; i++)
+        {
+            _sourceEventLogger.Verbose("test log message {0}", "parameter");
+        }
+    }
+
+    [Benchmark]
+    public void Log_10000_Messages_Without_To_String()
+    {
+        _useHandler = false;
+
+        for (var i = 0; i < 10000; i++)
+        {
+            _sourceEventLogger.Verbose("test log message {0}", "parameter");
+        }
+    }
+
+    [Benchmark]
+    public void Log_10000_Messages_With_NullLogger()
+    {
+        for (var i = 0; i < 10000; i++)
+        {
+            _sourceNullLogger.Verbose("test log message {0}", "parameter");
+        }
+    }
+}

Source/MQTTnet.Benchmarks/MQTTnet.Benchmarks.csproj

@@ -1,24 +1,15 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
         <OutputType>Exe</OutputType>
         <DebugType>Full</DebugType>
-        <TargetFramework>net8.0</TargetFramework>
         <IsPackable>false</IsPackable>
-        <EnableNETAnalyzers>false</EnableNETAnalyzers>
-        <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
-        <DisableImplicitAspNetCoreAnalyzers>true</DisableImplicitAspNetCoreAnalyzers>
-        <NoWarn>1591;NETSDK1138;NU1803;NU1901;NU1902;CS8892</NoWarn>
+        <NoWarn>$(NoWarn);CS8892;CA1707;CA1051;CA1822</NoWarn>
         <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
-        <NuGetAuditMode>all</NuGetAuditMode>
-        <NuGetAudit>true</NuGetAudit>
-        <NuGetAuditLevel>low</NuGetAuditLevel>
-        <AnalysisLevel>latest-Recommended</AnalysisLevel>
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="BenchmarkDotNet" Version="0.14.0" />
+        <PackageReference Include="BenchmarkDotNet" Version="0.15.4" />
     </ItemGroup>
 
     <ItemGroup>

Source/MQTTnet.Benchmarks/MemoryCopyBenchmark.cs

@@ -1,40 +1,39 @@
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
-using System;
 
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter, RankColumn]
+[MemoryDiagnoser]
+public class MemoryCopyBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter, RankColumn]
-    [MemoryDiagnoser]
-    public class MemoryCopyBenchmark
+    const int MaxLength = 1024 * 8;
+
+    byte[] _source;
+    byte[] _target;
+
+    [Params(64 - 1, 128 - 1, 256 - 1, 512 - 1, 1024 - 1, 2048 - 1, 5096 - 1)]
+    public int Length { get; set; }
+
+    [GlobalSetup]
+    public void Setup()
     {
-        const int max_length = 1024 * 8;
-        private byte[] source;
-        private byte[] target;
-
-        [Params(64 - 1, 128 - 1, 256 - 1, 512 - 1, 1024 - 1, 2048 - 1, 5096 - 1)]
-        public int Length { get; set; }
-
-        [GlobalSetup]
-        public void Setup()
-        {
-            source = new byte[max_length];
-            target = new byte[max_length];
-        }
-
-        [Benchmark(Baseline = true)]
-        public void Array_Copy()
-        {
-            Array.Copy(source, 0, target, 0, Length);
-        }
-
-        [Benchmark]
-        public void Memory_Copy()
-        {
-            MQTTnet.Internal.MqttMemoryHelper.Copy(source, 0, target, 0, Length);
-        }
-
+        _source = new byte[MaxLength];
+        _target = new byte[MaxLength];
     }
+
+    [Benchmark(Baseline = true)]
+    public void Array_Copy()
+    {
+        Array.Copy(_source, 0, _target, 0, Length);
+    }
+
+    [Benchmark]
+    public void Memory_Copy()
+    {
+        Internal.MqttMemoryHelper.Copy(_source, 0, _target, 0, Length);
+    }
+
 }

Source/MQTTnet.Benchmarks/MessageDeliveryBenchmark.cs

@@ -2,11 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
 using MQTTnet.Packets;
 using MQTTnet.Server;
@@ -14,7 +9,7 @@ using MQTTnet.Server;
 namespace MQTTnet.Benchmarks;
 
 [MemoryDiagnoser]
-public class MessageDeliveryBenchmark : BaseBenchmark
+public sealed class MessageDeliveryBenchmark : BaseBenchmark, IDisposable
 {
     List<string> _allSubscribedTopics; // Keep track of the subset of topics that are subscribed
     CancellationTokenSource _cancellationTokenSource;
@@ -23,22 +18,19 @@ public class MessageDeliveryBenchmark : BaseBenchmark
     int _messagesExpectedCount;
     int _messagesReceivedCount;
     Dictionary<string, IMqttClient> _mqttPublisherClientsByPublisherName;
-
     MqttServer _mqttServer;
     List<IMqttClient> _mqttSubscriberClients;
+
+    [Params(1000, 10000)] public int _numPublishers;
+
+    [Params(5, 10, 20, 50)] public int _numSubscribedTopicsPerSubscriber;
+
+    [Params(10)] public int _numSubscribers;
+
+    [Params(1, 5)] public int _numTopicsPerPublisher;
     Dictionary<string, string> _publisherByTopic;
-    List<MqttApplicationMessage> _topicPublishMessages;
-
     Dictionary<string, List<string>> _topicsByPublisher;
 
-    [Params(1000, 10000)] public int NumPublishers;
-
-    [Params(5, 10, 20, 50)] public int NumSubscribedTopicsPerSubscriber;
-
-    [Params(10)] public int NumSubscribers;
-
-    [Params(1, 5)] public int NumTopicsPerPublisher;
-
     [GlobalCleanup]
     public void Cleanup()
     {
@@ -64,14 +56,11 @@ public class MessageDeliveryBenchmark : BaseBenchmark
         _mqttServer = null;
     }
 
-    /// <summary>
-    ///     Publish messages and wait for messages sent to subscribers
-    /// </summary>
     [Benchmark]
     public void DeliverMessages()
     {
         // There should be one message received per publish for each subscribed topic
-        _messagesExpectedCount = NumSubscribedTopicsPerSubscriber * NumSubscribers;
+        _messagesExpectedCount = _numSubscribedTopicsPerSubscriber * _numSubscribers;
 
         // Loop for a while and exchange messages
 
@@ -82,8 +71,6 @@ public class MessageDeliveryBenchmark : BaseBenchmark
         // same payload for all messages
         var payload = new byte[] { 1, 2, 3, 4 };
 
-        var tasks = new List<Task>();
-
         // publish a message for each subscribed topic
         foreach (var topic in _allSubscribedTopics)
         {
@@ -101,35 +88,29 @@ public class MessageDeliveryBenchmark : BaseBenchmark
         }
         catch
         {
+            // Ignore all errors.
         }
 
         _cancellationTokenSource.Dispose();
 
         if (_messagesReceivedCount < _messagesExpectedCount)
         {
-            throw new Exception(string.Format("Messages Received Count mismatch, expected {0}, received {1}", _messagesExpectedCount, _messagesReceivedCount));
+            throw new InvalidOperationException($"Messages Received Count mismatch, expected {_messagesExpectedCount}, received {_messagesReceivedCount}");
         }
     }
 
+    public void Dispose()
+    {
+        _cancellationTokenSource?.Dispose();
+        _mqttServer?.Dispose();
+    }
 
     [GlobalSetup]
     public void Setup()
     {
         _lockMsgCount = new object();
 
-        Dictionary<string, List<string>> singleWildcardTopicsByPublisher;
-        Dictionary<string, List<string>> multiWildcardTopicsByPublisher;
-
-        TopicGenerator.Generate(NumPublishers, NumTopicsPerPublisher, out _topicsByPublisher, out singleWildcardTopicsByPublisher, out multiWildcardTopicsByPublisher);
-
-        var topics = _topicsByPublisher.First().Value;
-        _topicPublishMessages = new List<MqttApplicationMessage>();
-        // Prepare messages, same for each publisher
-        foreach (var topic in topics)
-        {
-            var message = new MqttApplicationMessageBuilder().WithTopic(topic).WithPayload(new byte[] { 1, 2, 3, 4, 5, 6, 7, 8 }).Build();
-            _topicPublishMessages.Add(message);
-        }
+        TopicGenerator.Generate(_numPublishers, _numTopicsPerPublisher, out _topicsByPublisher, out _, out _);
 
         // Create server
         var serverFactory = new MqttServerFactory();
@@ -139,7 +120,7 @@ public class MessageDeliveryBenchmark : BaseBenchmark
         _mqttServer.StartAsync().GetAwaiter().GetResult();
 
         // Create publisher clients
-        _mqttPublisherClientsByPublisherName = new Dictionary<string, IMqttClient>();
+        _mqttPublisherClientsByPublisherName = [];
         foreach (var pt in _topicsByPublisher)
         {
             var publisherName = pt.Key;
@@ -151,13 +132,13 @@ public class MessageDeliveryBenchmark : BaseBenchmark
 
         // Create subscriber clients
         _mqttSubscriberClients = new List<IMqttClient>();
-        for (var i = 0; i < NumSubscribers; i++)
+        for (var i = 0; i < _numSubscribers; i++)
         {
             var mqttSubscriberClient = clientFactory.CreateMqttClient();
             _mqttSubscriberClients.Add(mqttSubscriberClient);
 
             var subscriberOptions = new MqttClientOptionsBuilder().WithTcpServer("localhost").WithClientId("subscriber" + i).Build();
-            mqttSubscriberClient.ApplicationMessageReceivedAsync += r =>
+            mqttSubscriberClient.ApplicationMessageReceivedAsync += _ =>
             {
                 // count messages and signal cancellation when expected message count is reached
                 lock (_lockMsgCount)
@@ -171,12 +152,13 @@ public class MessageDeliveryBenchmark : BaseBenchmark
 
                 return Task.CompletedTask;
             };
+
             mqttSubscriberClient.ConnectAsync(subscriberOptions).GetAwaiter().GetResult();
         }
 
 
         var allTopics = new List<string>();
-        _publisherByTopic = new Dictionary<string, string>();
+        _publisherByTopic = [];
         foreach (var t in _topicsByPublisher)
         {
             foreach (var topic in t.Value)
@@ -189,21 +171,18 @@ public class MessageDeliveryBenchmark : BaseBenchmark
         // Subscribe to NumSubscribedTopics topics spread across all topics
         _allSubscribedTopics = new List<string>();
 
-        var totalNumTopics = NumPublishers * NumTopicsPerPublisher;
-        var topicIndexStep = totalNumTopics / (NumSubscribedTopicsPerSubscriber * NumSubscribers);
-        if (topicIndexStep * NumSubscribedTopicsPerSubscriber * NumSubscribers != totalNumTopics)
+        var totalNumTopics = _numPublishers * _numTopicsPerPublisher;
+        var topicIndexStep = totalNumTopics / (_numSubscribedTopicsPerSubscriber * _numSubscribers);
+        if (topicIndexStep * _numSubscribedTopicsPerSubscriber * _numSubscribers != totalNumTopics)
         {
-            throw new Exception(
-                string.Format(
-                    "The total number of topics must be divisible by the number of subscribed topics across all subscribers. Total number of topics: {0}, topic step: {1}",
-                    totalNumTopics,
-                    topicIndexStep));
+            throw new InvalidOperationException(
+                $"The total number of topics must be divisible by the number of subscribed topics across all subscribers. Total number of topics: {totalNumTopics}, topic step: {topicIndexStep}");
         }
 
         var topicIndex = 0;
         foreach (var mqttSubscriber in _mqttSubscriberClients)
         {
-            for (var i = 0; i < NumSubscribedTopicsPerSubscriber; ++i, topicIndex += topicIndexStep)
+            for (var i = 0; i < _numSubscribedTopicsPerSubscriber; ++i, topicIndex += topicIndexStep)
             {
                 var topic = allTopics[topicIndex];
                 _allSubscribedTopics.Add(topic);

Source/MQTTnet.Benchmarks/MessageProcessingMqttConnectionContextBenchmark.cs

@@ -9,65 +9,64 @@ using Microsoft.AspNetCore.Hosting;
 using MQTTnet.AspNetCore;
 using MQTTnet.Diagnostics.Logger;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[MemoryDiagnoser]
+public class MessageProcessingMqttConnectionContextBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [MemoryDiagnoser]
-    public class MessageProcessingMqttConnectionContextBenchmark : BaseBenchmark
+    IWebHost _host;
+    IMqttClient _mqttClient;
+    MqttApplicationMessage _message;
+
+    [GlobalSetup]
+    public void Setup()
     {
-        IWebHost _host;
-        IMqttClient _mqttClient;
-        MqttApplicationMessage _message;
+        _host = WebHost.CreateDefaultBuilder()
+            .UseKestrel(o => o.ListenAnyIP(1883, l => l.UseMqtt()))
+            .ConfigureServices(services => {
+                services
+                    .AddHostedMqttServer(mqttServerOptions => mqttServerOptions.WithoutDefaultEndpoint())
+                    .AddMqttConnectionHandler();
+            })
+            .Configure(app => {
+                app.UseMqttServer(_ => {
 
-        [GlobalSetup]
-        public void Setup()
+                });
+            })
+            .Build();
+
+        var factory = new MqttClientFactory();
+        _mqttClient = factory.CreateMqttClient(new MqttNetEventLogger(), new MqttClientConnectionContextFactory());
+
+        _host.StartAsync().GetAwaiter().GetResult();
+
+        var clientOptions = new MqttClientOptionsBuilder()
+            .WithTcpServer("localhost").Build();
+
+        _mqttClient.ConnectAsync(clientOptions).GetAwaiter().GetResult();
+
+        _message = new MqttApplicationMessageBuilder()
+            .WithTopic("A")
+            .Build();
+    }
+
+    [GlobalCleanup]
+    public void Cleanup()
+    {
+        _mqttClient.DisconnectAsync().GetAwaiter().GetResult();
+        _mqttClient.Dispose();
+
+        _host.StopAsync().GetAwaiter().GetResult();
+        _host.Dispose();
+    }
+
+    [Benchmark]
+    public void Send_10000_Messages()
+    {
+        for (var i = 0; i < 10000; i++)
         {
-            _host = WebHost.CreateDefaultBuilder()
-                   .UseKestrel(o => o.ListenAnyIP(1883, l => l.UseMqtt()))
-                   .ConfigureServices(services => {
-                        services
-                            .AddHostedMqttServer(mqttServerOptions => mqttServerOptions.WithoutDefaultEndpoint())
-                            .AddMqttConnectionHandler();
-                   })
-                   .Configure(app => {
-                       app.UseMqttServer(s => {
-
-                       });
-                   })
-                   .Build();
-
-            var factory = new MqttClientFactory();
-            _mqttClient = factory.CreateMqttClient(new MqttNetEventLogger(), new MqttClientConnectionContextFactory());
-
-            _host.StartAsync().GetAwaiter().GetResult();
-
-            var clientOptions = new MqttClientOptionsBuilder()
-                .WithTcpServer("localhost").Build();
-
-            _mqttClient.ConnectAsync(clientOptions).GetAwaiter().GetResult();
-
-            _message = new MqttApplicationMessageBuilder()
-                .WithTopic("A")
-                .Build();
-        }
-
-        [GlobalCleanup]
-        public void Cleanup()
-        {
-            _mqttClient.DisconnectAsync().GetAwaiter().GetResult();
-            _mqttClient.Dispose();
-
-            _host.StopAsync().GetAwaiter().GetResult();
-            _host.Dispose();
-        }
-
-        [Benchmark]
-        public void Send_10000_Messages()
-        {
-            for (var i = 0; i < 10000; i++)
-            {
-                _mqttClient.PublishAsync(_message).GetAwaiter().GetResult();
-            }
+            _mqttClient.PublishAsync(_message).GetAwaiter().GetResult();
         }
     }
-}
+}

Source/MQTTnet.Benchmarks/MqttBufferReaderBenchmark.cs

@@ -2,42 +2,40 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Text;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Formatter;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[MemoryDiagnoser]
+public class MqttBufferReaderBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [MemoryDiagnoser]
-    public class MqttBufferReaderBenchmark
+    byte[] _buffer;
+    int _bufferLength;
+
+    [GlobalSetup]
+    public void GlobalSetup()
     {
-        byte[] _buffer;
-        int _bufferLength;
+        var writer = new MqttBufferWriter(1024, 1024);
+        writer.WriteString("hgfjkdfkjlghfdjghdfljkdfhgdlkjfshgsldkfjghsdflkjghdsflkjhrstiuoghlkfjbhnfbutghjoiöjhklötnbhtroliöuhbjntluiobkjzbhtdrlskbhtruhjkfthgbkftgjhgfiklhotriuöhbjtrsioöbtrsötrhträhtrühjtriüoätrhjtsrölbktrbnhtrulöbionhströloubinströoliubhnsöotrunbtöroisntröointröioujhgötiohjgötorshjnbgtöorihbnjtröoihbjntröobntröoibntrjhötrohjbtröoihntröoibnrtoiöbtrjnboöitrhjtnriohötrhjtöroihjtroöihjtroösibntsroönbotöirsbntöoihjntröoihntroöbtrboöitrnhoöitrhjntröoishbnjtröosbhtröbntriohjtröoijtöoitbjöotibjnhöotirhbjntroöibhnjrtoöibnhtroöibnhtörsbnhtöoirbnhtöroibntoörhjnbträöbtrbträbtrbtirbätrsibohjntrsöiobthnjiohjsrtoib");
 
-        [GlobalSetup]
-        public void GlobalSetup()
-        {
-            var writer = new MqttBufferWriter(1024, 1024);
-            writer.WriteString("hgfjkdfkjlghfdjghdfljkdfhgdlkjfshgsldkfjghsdflkjghdsflkjhrstiuoghlkfjbhnfbutghjoiöjhklötnbhtroliöuhbjntluiobkjzbhtdrlskbhtruhjkfthgbkftgjhgfiklhotriuöhbjtrsioöbtrsötrhträhtrühjtriüoätrhjtsrölbktrbnhtrulöbionhströloubinströoliubhnsöotrunbtöroisntröointröioujhgötiohjgötorshjnbgtöorihbnjtröoihbjntröobntröoibntrjhötrohjbtröoihntröoibnrtoiöbtrjnboöitrhjtnriohötrhjtöroihjtroöihjtroösibntsroönbotöirsbntöoihjntröoihntroöbtrboöitrnhoöitrhjntröoishbnjtröosbhtröbntriohjtröoijtöoitbjöotibjnhöotirhbjntroöibhnjrtoöibnhtroöibnhtörsbnhtöoirbnhtöroibntoörhjnbträöbtrbträbtrbtirbätrsibohjntrsöiobthnjiohjsrtoib");
+        _buffer = writer.GetBuffer();
+        _bufferLength = writer.Length;
+    }
 
-            _buffer = writer.GetBuffer();
-            _bufferLength = writer.Length;
-        }
+    [Benchmark]
+    public void Use_Span()
+    {
+        var span = _buffer.AsSpan(0, _bufferLength);
+        Encoding.UTF8.GetString(span);
+    }
 
-        [Benchmark]
-        public void Use_Span()
-        {
-            var span = _buffer.AsSpan(0, _bufferLength);
-            Encoding.UTF8.GetString(span);
-        }
-        
-        [Benchmark]
-        public void Use_Encoding()
-        {
-            Encoding.UTF8.GetString(_buffer, 0, _bufferLength);
-        }
+    [Benchmark]
+    public void Use_Encoding()
+    {
+        Encoding.UTF8.GetString(_buffer, 0, _bufferLength);
     }
 }

Source/MQTTnet.Benchmarks/MqttPacketReaderWriterBenchmark.cs

@@ -2,95 +2,93 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Formatter;
 using MQTTnet.Tests.Mockups;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[MemoryDiagnoser]
+public class MqttPacketReaderWriterBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [MemoryDiagnoser]
-    public class MqttPacketReaderWriterBenchmark : BaseBenchmark
+    readonly byte[] _demoPayload = new byte[1024];
+
+    byte[] _readPayload;
+
+    [GlobalCleanup]
+    public void GlobalCleanup()
     {
-        readonly byte[] _demoPayload = new byte[1024];
-        
-        byte[] _readPayload;
+    }
 
-        [GlobalCleanup]
-        public void GlobalCleanup()
+    [GlobalSetup]
+    public void GlobalSetup()
+    {
+        TestEnvironment.EnableLogger = false;
+
+        var writer = new MqttBufferWriter(4096, 65535);
+        writer.WriteString("A relative short string.");
+        writer.WriteBinary(_demoPayload);
+        writer.WriteByte(0x01);
+        writer.WriteByte(0x02);
+        writer.WriteVariableByteInteger(5647382);
+        writer.WriteString("A relative short string.");
+        writer.WriteVariableByteInteger(8574489);
+        writer.WriteBinary(_demoPayload);
+        writer.WriteByte(2);
+        writer.WriteByte(0x02);
+        writer.WriteString("fjgffiogfhgfhoihgoireghreghreguhreguireoghreouighreouighreughreguiorehreuiohruiorehreuioghreug");
+        writer.WriteBinary(_demoPayload);
+
+        _readPayload = new ArraySegment<byte>(writer.GetBuffer(), 0, writer.Length).ToArray();
+    }
+
+    [Benchmark]
+    public void Read_100_000_Messages()
+    {
+        var reader = new MqttBufferReader();
+        reader.SetBuffer(_readPayload, 0, _readPayload.Length);
+
+        for (var i = 0; i < 100000; i++)
         {
+            reader.Seek(0);
+
+            reader.ReadString();
+            reader.ReadBinaryData();
+            reader.ReadByte();
+            reader.ReadByte();
+            reader.ReadVariableByteInteger();
+            reader.ReadString();
+            reader.ReadVariableByteInteger();
+            reader.ReadBinaryData();
+            reader.ReadByte();
+            reader.ReadByte();
+            reader.ReadString();
+            reader.ReadBinaryData();
         }
+    }
 
-        [GlobalSetup]
-        public void GlobalSetup()
+    [Benchmark]
+    public void Write_100_000_Messages()
+    {
+        var writer = new MqttBufferWriter(4096, 65535);
+
+        for (var i = 0; i < 100000; i++)
         {
-            TestEnvironment.EnableLogger = false;
-            
-            var writer = new MqttBufferWriter(4096, 65535);
             writer.WriteString("A relative short string.");
-            writer.WriteBinary(_demoPayload);
             writer.WriteByte(0x01);
             writer.WriteByte(0x02);
             writer.WriteVariableByteInteger(5647382);
             writer.WriteString("A relative short string.");
-            writer.WriteVariableByteInteger(8574489);
+            writer.WriteVariableByteInteger(8574589);
             writer.WriteBinary(_demoPayload);
             writer.WriteByte(2);
             writer.WriteByte(0x02);
             writer.WriteString("fjgffiogfhgfhoihgoireghreghreguhreguireoghreouighreouighreughreguiorehreuiohruiorehreuioghreug");
             writer.WriteBinary(_demoPayload);
 
-            _readPayload = new ArraySegment<byte>(writer.GetBuffer(), 0, writer.Length).ToArray();
-        }
-
-        [Benchmark]
-        public void Read_100_000_Messages()
-        {
-            var reader = new MqttBufferReader();
-            reader.SetBuffer(_readPayload, 0, _readPayload.Length);
-
-            for (var i = 0; i < 100000; i++)
-            {
-                reader.Seek(0);
-
-                reader.ReadString();
-                reader.ReadBinaryData();
-                reader.ReadByte();
-                reader.ReadByte();
-                reader.ReadVariableByteInteger();
-                reader.ReadString();
-                reader.ReadVariableByteInteger();
-                reader.ReadBinaryData();
-                reader.ReadByte();
-                reader.ReadByte();
-                reader.ReadString();
-                reader.ReadBinaryData();
-            }
-        }
-        
-        [Benchmark]
-        public void Write_100_000_Messages()
-        {
-            var writer = new MqttBufferWriter(4096, 65535);
-
-            for (var i = 0; i < 100000; i++)
-            {
-                writer.WriteString("A relative short string.");
-                writer.WriteByte(0x01);
-                writer.WriteByte(0x02);
-                writer.WriteVariableByteInteger(5647382);
-                writer.WriteString("A relative short string.");
-                writer.WriteVariableByteInteger(8574589);
-                writer.WriteBinary(_demoPayload);
-                writer.WriteByte(2);
-                writer.WriteByte(0x02);
-                writer.WriteString("fjgffiogfhgfhoihgoireghreghreguhreguireoghreouighreouighreughreguiorehreuiohruiorehreuioghreug");
-                writer.WriteBinary(_demoPayload);
-
-                writer.Reset(0);
-            }
+            writer.Reset(0);
         }
     }
 }

Source/MQTTnet.Benchmarks/MqttTcpChannelBenchmark.cs

@@ -2,11 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Buffers;
 using System.Reflection;
-using System.Threading;
-using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Channel;
@@ -19,9 +16,9 @@ namespace MQTTnet.Benchmarks;
 
 [SimpleJob(RuntimeMoniker.Net60)]
 [MemoryDiagnoser]
-public class MqttTcpChannelBenchmark : BaseBenchmark
+public sealed class MqttTcpChannelBenchmark : BaseBenchmark, IDisposable
 {
-    IMqttChannel _clientChannel;
+    MqttTcpChannel _clientChannel;
     MqttServer _mqttServer;
     IMqttChannel _serverChannel;
 
@@ -85,4 +82,11 @@ public class MqttTcpChannelBenchmark : BaseBenchmark
             await _serverChannel.WriteAsync(buffer, true, CancellationToken.None).ConfigureAwait(false);
         }
     }
+
+    public void Dispose()
+    {
+        _clientChannel?.Dispose();
+        _mqttServer?.Dispose();
+        _serverChannel?.Dispose();
+    }
 }

Source/MQTTnet.Benchmarks/Program.cs

@@ -2,141 +2,135 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using BenchmarkDotNet.Loggers;
 using BenchmarkDotNet.Running;
-using MQTTnet.Diagnostics;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+public static class Program
 {
-    public static class Program
+    static int _selectedBenchmarkIndex;
+    static List<Type> _benchmarks;
+
+    public static void Main(string[] arguments)
     {
-        static int _selectedBenchmarkIndex;
-        static List<Type> _benchmarks;
+        _benchmarks = CollectBenchmarks();
+        HandleArguments(arguments);
 
-        public static void Main(string[] arguments)
+        while (true)
         {
-            _benchmarks = CollectBenchmarks();
-            HandleArguments(arguments);
+            RenderMenu();
 
-            while (true)
+            var key = Console.ReadKey(true);
+
+            if (key.Key == ConsoleKey.DownArrow)
             {
-                RenderMenu();
-
-                var key = Console.ReadKey(true);
-
-                if (key.Key == ConsoleKey.DownArrow)
+                _selectedBenchmarkIndex++;
+                if (_selectedBenchmarkIndex > _benchmarks.Count - 1)
                 {
-                    _selectedBenchmarkIndex++;
-                    if (_selectedBenchmarkIndex > _benchmarks.Count - 1)
-                    {
-                        _selectedBenchmarkIndex = 0;
-                    }
-                }
-                else if (key.Key == ConsoleKey.UpArrow)
-                {
-                    _selectedBenchmarkIndex--;
-                    if (_selectedBenchmarkIndex < 0)
-                    {
-                        _selectedBenchmarkIndex = _benchmarks.Count - 1;
-                    }
-                }
-                else if (key.Key == ConsoleKey.Escape)
-                {
-                    Environment.Exit(0);
-                }
-                else if (key.Key == ConsoleKey.Enter)
-                {
-                    break;
+                    _selectedBenchmarkIndex = 0;
                 }
             }
-
-            BenchmarkRunner.Run(_benchmarks[_selectedBenchmarkIndex]);
-
-            Console.ForegroundColor = ConsoleColor.Yellow;
-            Console.WriteLine("Press any key to exit");
-            Console.ReadLine();
-        }
-
-        static List<Type> CollectBenchmarks()
-        {
-            var benchmarks = new List<Type>();
-
-            var types = typeof(Program).Assembly.GetExportedTypes();
-            foreach (var type in types)
+            else if (key.Key == ConsoleKey.UpArrow)
             {
-                if (typeof(BaseBenchmark).IsAssignableFrom(type))
+                _selectedBenchmarkIndex--;
+                if (_selectedBenchmarkIndex < 0)
                 {
-                    if (type != typeof(BaseBenchmark))
-                    {
-                        benchmarks.Add(type);
-                    }
+                    _selectedBenchmarkIndex = _benchmarks.Count - 1;
                 }
             }
-
-            return benchmarks.OrderBy(b => b.Name).ToList();
-        }
-
-        static void HandleArguments(string[] arguments)
-        {
-            if (arguments.Length == 0)
+            else if (key.Key == ConsoleKey.Escape)
             {
-                return;
+                Environment.Exit(0);
             }
-
-            // Allow for preselection to avoid developer frustration.
-
-            if (int.TryParse(arguments[0], out var benchmarkIndex))
+            else if (key.Key == ConsoleKey.Enter)
             {
-                _selectedBenchmarkIndex = benchmarkIndex;
-                return;
-            }
-
-            _selectedBenchmarkIndex = _benchmarks.FindIndex(b => b.Name.Equals(arguments[0]));
-
-            if (_selectedBenchmarkIndex < 0)
-            {
-                _selectedBenchmarkIndex = 0;
-            }
-
-            if (_selectedBenchmarkIndex > _benchmarks.Count - 1)
-            {
-                _selectedBenchmarkIndex = _benchmarks.Count - 1;
+                break;
             }
         }
 
-        static void RenderMenu()
+        BenchmarkRunner.Run(_benchmarks[_selectedBenchmarkIndex]);
+
+        Console.ForegroundColor = ConsoleColor.Yellow;
+        Console.WriteLine("Press any key to exit");
+        Console.ReadLine();
+    }
+
+    static List<Type> CollectBenchmarks()
+    {
+        var benchmarks = new List<Type>();
+
+        var types = typeof(Program).Assembly.GetExportedTypes();
+        foreach (var type in types)
         {
-            Console.Clear();
-
-            Console.WriteLine($"MQTTnet - Benchmarks");
-            Console.WriteLine("-----------------------------------------------");
-            Console.ForegroundColor = ConsoleColor.Yellow;
-            Console.WriteLine("Press arrow keys for benchmark selection");
-            Console.WriteLine("Press Enter for benchmark execution");
-            Console.WriteLine("Press Esc for exit");
-            Console.ForegroundColor = ConsoleColor.White;
-            Console.WriteLine();
-
-            for (var index = 0; index < _benchmarks.Count; index++)
+            if (typeof(BaseBenchmark).IsAssignableFrom(type))
             {
-                var benchmark = _benchmarks[index];
-
-                if (_selectedBenchmarkIndex == index)
+                if (type != typeof(BaseBenchmark))
                 {
-                    Console.Write("-> ");
+                    benchmarks.Add(type);
                 }
-                else
-                {
-                    Console.Write("   ");
-                }
-
-                Console.WriteLine(benchmark.Name);
             }
+        }
 
-            Console.WriteLine();
+        return benchmarks.OrderBy(b => b.Name).ToList();
+    }
+
+    static void HandleArguments(string[] arguments)
+    {
+        if (arguments.Length == 0)
+        {
+            return;
+        }
+
+        // Allow for preselection to avoid developer frustration.
+
+        if (int.TryParse(arguments[0], out var benchmarkIndex))
+        {
+            _selectedBenchmarkIndex = benchmarkIndex;
+            return;
+        }
+
+        _selectedBenchmarkIndex = _benchmarks.FindIndex(b => b.Name.Equals(arguments[0], StringComparison.Ordinal));
+
+        if (_selectedBenchmarkIndex < 0)
+        {
+            _selectedBenchmarkIndex = 0;
+        }
+
+        if (_selectedBenchmarkIndex > _benchmarks.Count - 1)
+        {
+            _selectedBenchmarkIndex = _benchmarks.Count - 1;
         }
     }
+
+    static void RenderMenu()
+    {
+        Console.Clear();
+
+        Console.WriteLine($"MQTTnet - Benchmarks");
+        Console.WriteLine("-----------------------------------------------");
+        Console.ForegroundColor = ConsoleColor.Yellow;
+        Console.WriteLine("Press arrow keys for benchmark selection");
+        Console.WriteLine("Press Enter for benchmark execution");
+        Console.WriteLine("Press Esc for exit");
+        Console.ForegroundColor = ConsoleColor.White;
+        Console.WriteLine();
+
+        for (var index = 0; index < _benchmarks.Count; index++)
+        {
+            var benchmark = _benchmarks[index];
+
+            if (_selectedBenchmarkIndex == index)
+            {
+                Console.Write("-> ");
+            }
+            else
+            {
+                Console.Write("   ");
+            }
+
+            Console.WriteLine(benchmark.Name);
+        }
+
+        Console.WriteLine();
+    }
 }

Source/MQTTnet.Benchmarks/ReaderExtensionsBenchmark.cs

@@ -1,240 +1,97 @@
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
-using MQTTnet.Adapter;
 using MQTTnet.AspNetCore;
 using MQTTnet.Exceptions;
 using MQTTnet.Formatter;
-using MQTTnet.Packets;
-using System;
 using System.Buffers;
-using System.IO;
 using System.IO.Pipelines;
-using System.Linq;
-using System.Threading.Tasks;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter, RankColumn]
+[MemoryDiagnoser]
+public sealed class ReaderExtensionsBenchmark : IDisposable, IAsyncDisposable
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter, RankColumn]
-    [MemoryDiagnoser]
-    public class ReaderExtensionsBenchmark
-    {
-        MqttPacketFormatterAdapter mqttPacketFormatter;
-        MemoryStream stream;
+    MqttPacketFormatterAdapter _mqttPacketFormatter;
+    MemoryStream _stream;
 
-        [GlobalSetup]
-        public void GlobalSetup()
-        {
-            mqttPacketFormatter = new MqttPacketFormatterAdapter(MqttProtocolVersion.V311, new MqttBufferWriter(4096, 65535));
-            var mqttMessage = new MqttApplicationMessageBuilder()
+    [GlobalSetup]
+    public void GlobalSetup()
+    {
+        _mqttPacketFormatter = new MqttPacketFormatterAdapter(MqttProtocolVersion.V311, new MqttBufferWriter(4096, 65535));
+        var mqttMessage = new MqttApplicationMessageBuilder()
             .WithTopic("topic")
             .WithPayload(new byte[10 * 1024])
             .Build();
 
-            var packet = MqttPublishPacketFactory.Create(mqttMessage);
-
-            var buffer = mqttPacketFormatter.Encode(packet);
-            stream = new MemoryStream();
-            stream.Write(buffer.Packet);
-            stream.Write(buffer.Payload.ToArray());
-            mqttPacketFormatter.Cleanup();
-        }
-
-        [Benchmark(Baseline = true)]
-        public async Task Before()
-        {
-            stream.Position = 0;
-            var input = PipeReader.Create(stream);
-
-            while (true)
-            {
-                ReadResult readResult;
-                var readTask = input.ReadAsync();
-                if (readTask.IsCompleted)
-                {
-                    readResult = readTask.Result;
-                }
-                else
-                {
-                    readResult = await readTask.ConfigureAwait(false);
-                }
-
-                var buffer = readResult.Buffer;
-
-                var consumed = buffer.Start;
-                var observed = buffer.Start;
-
-                try
-                {
-                    if (!buffer.IsEmpty)
-                    {
-                        if (ReaderExtensions_Before.TryDecode(mqttPacketFormatter, buffer, out var packet, out consumed, out observed, out var received))
-                        {
-                            break;
-                        }
-                    }
-                    else if (readResult.IsCompleted)
-                    {
-                        throw new MqttCommunicationException("Connection Aborted");
-                    }
-                }
-                finally
-                {
-                    // The buffer was sliced up to where it was consumed, so we can just advance to the start.
-                    // We mark examined as buffer.End so that if we didn't receive a full frame, we'll wait for more data
-                    // before yielding the read again.
-                    input.AdvanceTo(consumed, observed);
-                }
-            }
-        }
-
-        [Benchmark]
-        public async Task After()
-        {
-            stream.Position = 0;
-            var input = PipeReader.Create(stream);
-
-            while (true)
-            {
-                ReadResult readResult;
-                var readTask = input.ReadAsync();
-                if (readTask.IsCompleted)
-                {
-                    readResult = readTask.Result;
-                }
-                else
-                {
-                    readResult = await readTask.ConfigureAwait(false);
-                }
-
-                var buffer = readResult.Buffer;
-
-                var consumed = buffer.Start;
-                var observed = buffer.Start;
-
-                try
-                {
-                    if (!buffer.IsEmpty)
-                    {
-                        if (ReaderExtensions.TryDecode(mqttPacketFormatter, buffer, out var packet, out consumed, out observed, out var received))
-                        {
-                            break;
-                        }
-                    }
-                    else if (readResult.IsCompleted)
-                    {
-                        throw new MqttCommunicationException("Connection Aborted");
-                    }
-                }
-                finally
-                {
-                    // The buffer was sliced up to where it was consumed, so we can just advance to the start.
-                    // We mark examined as buffer.End so that if we didn't receive a full frame, we'll wait for more data
-                    // before yielding the read again.
-                    input.AdvanceTo(consumed, observed);
-                }
-            }
-        }
-
-        public static class ReaderExtensions_Before
-        {
-            public static bool TryDecode(MqttPacketFormatterAdapter formatter,
-                in ReadOnlySequence<byte> input,
-                out MqttPacket packet,
-                out SequencePosition consumed,
-                out SequencePosition observed,
-                out int bytesRead)
-            {
-                ArgumentNullException.ThrowIfNull(formatter);
-
-                packet = null;
-                consumed = input.Start;
-                observed = input.End;
-                bytesRead = 0;
-                var copy = input;
-
-                if (copy.Length < 2)
-                {
-                    return false;
-                }
-
-                var fixedHeader = copy.First.Span[0];
-                if (!TryReadBodyLength(ref copy, out int headerLength, out var bodyLength))
-                {
-                    return false;
-                }
-
-                if (copy.Length < bodyLength)
-                {
-                    return false;
-                }
-
-                var bodySlice = copy.Slice(0, bodyLength);
-                var buffer = GetMemory(bodySlice).ToArray();
-
-                var receivedMqttPacket = new ReceivedMqttPacket(fixedHeader, new ArraySegment<byte>(buffer, 0, buffer.Length), buffer.Length + 2);
-
-                if (formatter.ProtocolVersion == MqttProtocolVersion.Unknown)
-                {
-                    formatter.DetectProtocolVersion(receivedMqttPacket);
-                }
-
-                packet = formatter.Decode(receivedMqttPacket);
-                consumed = bodySlice.End;
-                observed = bodySlice.End;
-                bytesRead = headerLength + bodyLength;
-                return true;
-            }
-
-            static ReadOnlyMemory<byte> GetMemory(in ReadOnlySequence<byte> input)
-            {
-                if (input.IsSingleSegment)
-                {
-                    return input.First;
-                }
-
-                // Should be rare
-                return input.ToArray();
-            }
-
-            static bool TryReadBodyLength(ref ReadOnlySequence<byte> input, out int headerLength, out int bodyLength)
-            {
-                // Alorithm taken from https://docs.oasis-open.org/mqtt/mqtt/v3.1.1/errata01/os/mqtt-v3.1.1-errata01-os-complete.html.
-                var multiplier = 1;
-                var value = 0;
-                byte encodedByte;
-                var index = 1;
-                headerLength = 0;
-                bodyLength = 0;
-
-                var temp = GetMemory(input.Slice(0, Math.Min(5, input.Length))).Span;
-
-                do
-                {
-                    if (index == temp.Length)
-                    {
-                        return false;
-                    }
-
-                    encodedByte = temp[index];
-                    index++;
-
-                    value += (byte)(encodedByte & 127) * multiplier;
-                    if (multiplier > 128 * 128 * 128)
-                    {
-                        throw new MqttProtocolViolationException($"Remaining length is invalid (Data={string.Join(",", temp.Slice(1, index).ToArray())}).");
-                    }
-
-                    multiplier *= 128;
-                } while ((encodedByte & 128) != 0);
-
-                input = input.Slice(index);
-
-                headerLength = index;
-                bodyLength = value;
-                return true;
-            }
-        }
+        var packet = MqttPublishPacketFactory.Create(mqttMessage);
 
+        var buffer = _mqttPacketFormatter.Encode(packet);
+        _stream = new MemoryStream();
+        _stream.Write(buffer.Packet);
+        _stream.Write(buffer.Payload.ToArray());
+        _mqttPacketFormatter.Cleanup();
     }
-}
+
+    [Benchmark]
+    public async Task After()
+    {
+        _stream.Position = 0;
+        var input = PipeReader.Create(_stream);
+
+        while (true)
+        {
+            ReadResult readResult;
+            var readTask = input.ReadAsync();
+            if (readTask.IsCompleted)
+            {
+                readResult = readTask.Result;
+            }
+            else
+            {
+                readResult = await readTask.ConfigureAwait(false);
+            }
+
+            var buffer = readResult.Buffer;
+
+            var consumed = buffer.Start;
+            var observed = buffer.Start;
+
+            try
+            {
+                if (!buffer.IsEmpty)
+                {
+                    if (_mqttPacketFormatter.TryDecode(buffer, out _, out consumed, out observed, out _))
+                    {
+                        break;
+                    }
+                }
+                else if (readResult.IsCompleted)
+                {
+                    throw new MqttCommunicationException("Connection Aborted");
+                }
+            }
+            finally
+            {
+                // The buffer was sliced up to where it was consumed, so we can just advance to the start.
+                // We mark examined as buffer.End so that if we didn't receive a full frame, we'll wait for more data
+                // before yielding the read again.
+                input.AdvanceTo(consumed, observed);
+            }
+        }
+    }
+
+    public void Dispose()
+    {
+        _stream?.Dispose();
+    }
+
+    public async ValueTask DisposeAsync()
+    {
+        if (_stream != null)
+        {
+            await _stream.DisposeAsync();
+        }
+    }
+}

Source/MQTTnet.Benchmarks/RoundtripProcessingBenchmark.cs

@@ -1,30 +1,28 @@
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Tests.Mockups;
-using MQTTnet.Tests.Server;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter, RankColumn]
+[MemoryDiagnoser]
+public class RoundtripProcessingBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter, RankColumn]
-    [MemoryDiagnoser]
-    public class RoundtripProcessingBenchmark : BaseBenchmark
+    [GlobalSetup]
+    public void GlobalSetup()
     {
-        [GlobalSetup]
-        public void GlobalSetup()
-        {
-            TestEnvironment.EnableLogger = false;
-        }
-        
-        [GlobalCleanup]
-        public void GlobalCleanup()
-        {
-        }
-        
-        [Benchmark]
-        public void Handle_100_000_Messages_In_Receiving_Client()
-        {
-            new Load_Tests().Handle_100_000_Messages_In_Receiving_Client().GetAwaiter().GetResult();
-        }
+        TestEnvironment.EnableLogger = false;
+    }
+
+    [GlobalCleanup]
+    public void GlobalCleanup()
+    {
+    }
+
+    [Benchmark]
+    public void Handle_100_000_Messages_In_Receiving_Client()
+    {
+        //new Load_Tests().Handle_100_000_Messages_In_Receiving_Client().GetAwaiter().GetResult();
     }
 }

Source/MQTTnet.Benchmarks/SendPacketAsyncBenchmark.cs

@@ -1,69 +1,78 @@
+using System.Buffers;
+using System.IO.Pipelines;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Formatter;
-using System;
-using System.Buffers;
-using System.IO;
-using System.IO.Pipelines;
-using System.Threading.Tasks;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter]
+[RankColumn]
+[MemoryDiagnoser]
+public sealed class SendPacketAsyncBenchmark : BaseBenchmark, IDisposable, IAsyncDisposable
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter, RankColumn]
-    [MemoryDiagnoser]
-    public class SendPacketAsyncBenchmark : BaseBenchmark
+    MqttPacketBuffer _buffer;
+    MemoryStream _stream;
+
+    [Benchmark]
+    public async ValueTask After()
     {
-        MemoryStream stream;
-        MqttPacketBuffer buffer;
+        _stream.Position = 0;
+        var output = PipeWriter.Create(_stream);
 
-        [GlobalSetup]
-        public void GlobalSetup()
+        if (_buffer.Payload.Length == 0)
         {
-            stream = new MemoryStream(1024);
-            var packet = new ArraySegment<byte>(new byte[10]);
-            buffer = new MqttPacketBuffer(packet);
+            await output.WriteAsync(_buffer.Packet).ConfigureAwait(false);
         }
-
-        [Benchmark(Baseline = true)]
-        public async ValueTask Before()
+        else
         {
-            stream.Position = 0;
-            var output = PipeWriter.Create(stream);
-
-            WritePacketBuffer(output, buffer);
-            await output.FlushAsync();
-        }
-
-        [Benchmark]
-        public async ValueTask After()
-        {
-            stream.Position = 0;
-            var output = PipeWriter.Create(stream);
-
-            if (buffer.Payload.Length == 0)
-            {
-                await output.WriteAsync(buffer.Packet).ConfigureAwait(false);
-            }
-            else
-            {
-                WritePacketBuffer(output, buffer);
-                await output.FlushAsync().ConfigureAwait(false);
-            }
-        }
-
-
-        static void WritePacketBuffer(PipeWriter output, MqttPacketBuffer buffer)
-        {
-            // copy MqttPacketBuffer's Packet and Payload to the same buffer block of PipeWriter
-            // MqttPacket will be transmitted within the bounds of a WebSocket frame after PipeWriter.FlushAsync
-
-            var span = output.GetSpan(buffer.Length);
-
-            buffer.Packet.AsSpan().CopyTo(span);
-            buffer.Payload.CopyTo(span.Slice(buffer.Packet.Count));
-
-            output.Advance(buffer.Length);
+            WritePacketBuffer(output, _buffer);
+            await output.FlushAsync().ConfigureAwait(false);
         }
     }
+
+    [Benchmark(Baseline = true)]
+    public async ValueTask Before()
+    {
+        _stream.Position = 0;
+        var output = PipeWriter.Create(_stream);
+
+        WritePacketBuffer(output, _buffer);
+        await output.FlushAsync();
+    }
+
+    public void Dispose()
+    {
+        _stream?.Dispose();
+    }
+
+    public async ValueTask DisposeAsync()
+    {
+        if (_stream != null)
+        {
+            await _stream.DisposeAsync();
+        }
+    }
+
+    [GlobalSetup]
+    public void GlobalSetup()
+    {
+        _stream = new MemoryStream(1024);
+        var packet = new ArraySegment<byte>(new byte[10]);
+        _buffer = new MqttPacketBuffer(packet);
+    }
+
+    static void WritePacketBuffer(PipeWriter output, MqttPacketBuffer buffer)
+    {
+        // copy MqttPacketBuffer's Packet and Payload to the same buffer block of PipeWriter
+        // MqttPacket will be transmitted within the bounds of a WebSocket frame after PipeWriter.FlushAsync
+
+        var span = output.GetSpan(buffer.Length);
+
+        buffer.Packet.AsSpan().CopyTo(span);
+        buffer.Payload.CopyTo(span[buffer.Packet.Count..]);
+
+        output.Advance(buffer.Length);
+    }
 }

Source/MQTTnet.Benchmarks/SerializerBenchmark.cs

@@ -4,10 +4,7 @@
 
 using BenchmarkDotNet.Attributes;
 using MQTTnet.Packets;
-using System;
 using System.Security.Cryptography.X509Certificates;
-using System.Threading;
-using System.Threading.Tasks;
 using MQTTnet.Adapter;
 using MQTTnet.Channel;
 using MQTTnet.Formatter;
@@ -17,103 +14,104 @@ using MQTTnet.Diagnostics.Logger;
 using System.Buffers;
 using System.Net;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter]
+[MemoryDiagnoser]
+public class SerializerBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter]
-    [MemoryDiagnoser]
-    public class SerializerBenchmark : BaseBenchmark
+    MqttPacket _packet;
+    ArraySegment<byte> _serializedPacket;
+    MqttV3PacketFormatter _serializer;
+    MqttBufferWriter _bufferWriter;
+
+    [GlobalSetup]
+    public void GlobalSetup()
     {
-        MqttPacket _packet;
-        ArraySegment<byte> _serializedPacket;
-        IMqttPacketFormatter _serializer;
-        MqttBufferWriter _bufferWriter;
-
-        [GlobalSetup]
-        public void GlobalSetup()
+        _packet = new MqttPublishPacket
         {
-            _packet = new MqttPublishPacket
-            {
-                Topic = "A"
-            };
+            Topic = "A"
+        };
 
-            _bufferWriter = new MqttBufferWriter(4096, 65535);
-            _serializer = new MqttV3PacketFormatter(_bufferWriter, MqttProtocolVersion.V311);
-            _serializedPacket = _serializer.Encode(_packet).Join();
-        }
+        _bufferWriter = new MqttBufferWriter(4096, 65535);
+        _serializer = new MqttV3PacketFormatter(_bufferWriter, MqttProtocolVersion.V311);
+        _serializedPacket = _serializer.Encode(_packet).Join();
+    }
 
-        [Benchmark]
-        public void Serialize_10000_Messages()
+    [Benchmark]
+    public void Serialize10000Messages()
+    {
+        for (var i = 0; i < 10000; i++)
         {
-            for (var i = 0; i < 10000; i++)
-            {
-                _serializer.Encode(_packet);
-                _bufferWriter.Cleanup();
-            }
-        }
-
-        [Benchmark]
-        public void Deserialize_10000_Messages()
-        {
-            var channel = new BenchmarkMqttChannel(_serializedPacket);
-            var reader = new MqttChannelAdapter(channel, new MqttPacketFormatterAdapter(new MqttBufferWriter(4096, 65535)), new MqttNetEventLogger());
-
-            for (var i = 0; i < 10000; i++)
-            {
-                channel.Reset();
-
-                var header = reader.ReceivePacketAsync(CancellationToken.None).GetAwaiter().GetResult();
-            }
-        }
-
-        class BenchmarkMqttChannel : IMqttChannel
-        {
-            readonly ArraySegment<byte> _buffer;
-            int _position;
-
-            public BenchmarkMqttChannel(ArraySegment<byte> buffer)
-            {
-                _buffer = buffer;
-                _position = _buffer.Offset;
-            }
-
-            public EndPoint RemoteEndPoint { get; set; }
-
-            public bool IsSecureConnection { get; } = false;
-
-            public X509Certificate2 ClientCertificate { get; }
-
-            public void Reset()
-            {
-                _position = _buffer.Offset;
-            }
-
-            public Task ConnectAsync(CancellationToken cancellationToken)
-            {
-                throw new NotSupportedException();
-            }
-
-            public Task DisconnectAsync(CancellationToken cancellationToken)
-            {
-                throw new NotSupportedException();
-            }
-
-            public Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
-            {
-                Array.Copy(_buffer.Array, _position, buffer, offset, count);
-                _position += count;
-
-                return Task.FromResult(count);
-            }
-
-            public Task WriteAsync(ReadOnlySequence<byte> buffer, bool isEndOfPacket, CancellationToken cancellationToken)
-            {
-                throw new NotSupportedException();
-            }
-
-            public void Dispose()
-            {
-            }
+            _serializer.Encode(_packet);
+            _bufferWriter.Cleanup();
         }
     }
-}
+
+    [Benchmark]
+    public void Deserialize10000Messages()
+    {
+        var channel = new BenchmarkMqttChannel(_serializedPacket);
+        var reader = new MqttChannelAdapter(channel, new MqttPacketFormatterAdapter(new MqttBufferWriter(4096, 65535)), new MqttNetEventLogger());
+
+        for (var i = 0; i < 10000; i++)
+        {
+            channel.Reset();
+
+            reader.ReceivePacketAsync(CancellationToken.None).GetAwaiter().GetResult();
+        }
+    }
+
+    sealed class BenchmarkMqttChannel : IMqttChannel
+    {
+        readonly ArraySegment<byte> _buffer;
+        int _position;
+
+        public BenchmarkMqttChannel(ArraySegment<byte> buffer)
+        {
+            _buffer = buffer;
+            _position = _buffer.Offset;
+        }
+
+        public EndPoint RemoteEndPoint { get; set; }
+
+        public EndPoint LocalEndPoint { get; set; }
+
+        public bool IsSecureConnection { get; }
+
+        public X509Certificate2 ClientCertificate { get; set; }
+
+        public void Reset()
+        {
+            _position = _buffer.Offset;
+        }
+
+        public Task ConnectAsync(CancellationToken cancellationToken)
+        {
+            throw new NotSupportedException();
+        }
+
+        public Task DisconnectAsync(CancellationToken cancellationToken)
+        {
+            throw new NotSupportedException();
+        }
+
+        public Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
+        {
+            Array.Copy(_buffer!.Array!, _position, buffer, offset, count);
+            _position += count;
+
+            return Task.FromResult(count);
+        }
+
+        public Task WriteAsync(ReadOnlySequence<byte> buffer, bool isEndOfPacket, CancellationToken cancellationToken)
+        {
+            throw new NotSupportedException();
+        }
+
+        public void Dispose()
+        {
+        }
+    }
+}

Source/MQTTnet.Benchmarks/ServerProcessingBenchmark.cs

@@ -5,36 +5,34 @@
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.Tests.Mockups;
-using MQTTnet.Tests.Server;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter, RankColumn]
+[MemoryDiagnoser]
+public class ServerProcessingBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter, RankColumn]
-    [MemoryDiagnoser]
-    public class ServerProcessingBenchmark : BaseBenchmark
+    [GlobalSetup]
+    public void GlobalSetup()
     {
-        [GlobalSetup]
-        public void GlobalSetup()
-        {
-            TestEnvironment.EnableLogger = false;
-        }
-        
-        [GlobalCleanup]
-        public void GlobalCleanup()
-        {
-        }
-        
-        [Benchmark]
-        public void Handle_100_000_Messages_In_Server_MqttClient()
-        {
-            new Load_Tests().Handle_100_000_Messages_In_Server().GetAwaiter().GetResult();
-        }
-        
-        //[Benchmark]
-        public void Handle_100_000_Messages_In_Server_LowLevelMqttClient()
-        {
-            new Load_Tests().Handle_100_000_Messages_In_Low_Level_Client().GetAwaiter().GetResult();
-        }
+        TestEnvironment.EnableLogger = false;
+    }
+
+    [GlobalCleanup]
+    public void GlobalCleanup()
+    {
+    }
+
+    [Benchmark]
+    public void Handle_100_000_Messages_In_Server_MqttClient()
+    {
+        //new Load_Tests().Handle_100_000_Messages_In_Server().GetAwaiter().GetResult();
+    }
+
+    [Benchmark]
+    public void Handle_100_000_Messages_In_Server_LowLevelMqttClient()
+    {
+        //new Load_Tests().Handle_100_000_Messages_In_Low_Level_Client().GetAwaiter().GetResult();
     }
 }

Source/MQTTnet.Benchmarks/SubscribeBenchmark.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System.Collections.Generic;
-using System.Linq;
 using BenchmarkDotNet.Attributes;
 using MQTTnet.Server;
 
@@ -30,7 +28,7 @@ public class SubscribeBenchmark : BaseBenchmark
     [GlobalSetup]
     public void Setup()
     {
-        TopicGenerator.Generate(NumPublishers, NumTopicsPerPublisher, out var topicsByPublisher, out var singleWildcardTopicsByPublisher, out var multiWildcardTopicsByPublisher);
+        TopicGenerator.Generate(NumPublishers, NumTopicsPerPublisher, out var topicsByPublisher, out _, out _);
         _topics = topicsByPublisher.Values.First();
 
         var serverOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();

Source/MQTTnet.Benchmarks/TcpPipesBenchmark.cs

@@ -5,76 +5,73 @@
 using System.IO.Pipelines;
 using System.Net;
 using System.Net.Sockets;
-using System.Threading;
-using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 using MQTTnet.AspNetCore;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[MemoryDiagnoser]
+public class TcpPipesBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [MemoryDiagnoser]
-    public class TcpPipesBenchmark : BaseBenchmark
+    IDuplexPipe _client;
+    IDuplexPipe _server;
+
+    [GlobalSetup]
+    public void Setup()
     {
-        IDuplexPipe _client;
-        IDuplexPipe _server;
+        var server = new TcpListener(IPAddress.Any, 1883);
 
-        [GlobalSetup]
-        public void Setup()
+        server.Start(1);
+
+        var task = Task.Run(() => server.AcceptSocket());
+
+        var clientConnection = new SocketConnection(new IPEndPoint(IPAddress.Loopback, 1883));
+
+        clientConnection.StartAsync().GetAwaiter().GetResult();
+        _client = clientConnection.Transport;
+
+        var serverConnection = new SocketConnection(task.GetAwaiter().GetResult());
+        serverConnection.StartAsync().GetAwaiter().GetResult();
+        _server = serverConnection.Transport;
+    }
+
+
+    [Benchmark]
+    public async Task Send_10000_Chunks_Pipe()
+    {
+        var size = 5;
+        var iterations = 10000;
+
+        await Task.WhenAll(WriteAsync(iterations, size), ReadAsync(iterations, size));
+    }
+
+    async Task ReadAsync(int iterations, int size)
+    {
+        await Task.Yield();
+
+        var expected = iterations * size;
+        long read = 0;
+        var input = _client.Input;
+
+        while (read < expected)
         {
-            var server = new TcpListener(IPAddress.Any, 1883);
-
-            server.Start(1);
-
-            var task = Task.Run(() => server.AcceptSocket());
-
-            var clientConnection = new SocketConnection(new IPEndPoint(IPAddress.Loopback, 1883));
-
-            clientConnection.StartAsync().GetAwaiter().GetResult();
-            _client = clientConnection.Transport;
-
-            var serverConnection = new SocketConnection(task.GetAwaiter().GetResult());
-            serverConnection.StartAsync().GetAwaiter().GetResult();
-            _server = serverConnection.Transport;
-        }
-
-
-        [Benchmark]
-        public async Task Send_10000_Chunks_Pipe()
-        {
-            var size = 5;
-            var iterations = 10000;
-
-            await Task.WhenAll(WriteAsync(iterations, size), ReadAsync(iterations, size));
-        }
-
-        async Task ReadAsync(int iterations, int size)
-        {
-            await Task.Yield();
-
-            var expected = iterations * size;
-            long read = 0;
-            var input = _client.Input;
-
-            while (read < expected)
-            {
-                var readresult = await input.ReadAsync(CancellationToken.None).ConfigureAwait(false);
-                input.AdvanceTo(readresult.Buffer.End);
-                read += readresult.Buffer.Length;
-            }
-        }
-
-        async Task WriteAsync(int iterations, int size)
-        {
-            await Task.Yield();
-
-            var output = _server.Output;
-
-            for (var i = 0; i < iterations; i++)
-            {
-                await output.WriteAsync(new byte[size], CancellationToken.None).ConfigureAwait(false);
-            }
+            var readresult = await input.ReadAsync(CancellationToken.None).ConfigureAwait(false);
+            input.AdvanceTo(readresult.Buffer.End);
+            read += readresult.Buffer.Length;
         }
     }
-}
+
+    async Task WriteAsync(int iterations, int size)
+    {
+        await Task.Yield();
+
+        var output = _server.Output;
+
+        for (var i = 0; i < iterations; i++)
+        {
+            await output.WriteAsync(new byte[size], CancellationToken.None).ConfigureAwait(false);
+        }
+    }
+}

Source/MQTTnet.Benchmarks/TopicFilterComparerBenchmark.cs

@@ -2,269 +2,32 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Jobs;
 
-namespace MQTTnet.Benchmarks
+namespace MQTTnet.Benchmarks;
+
+[SimpleJob(RuntimeMoniker.Net60)]
+[RPlotExporter]
+[MemoryDiagnoser]
+public class TopicFilterComparerBenchmark : BaseBenchmark
 {
-    [SimpleJob(RuntimeMoniker.Net60)]
-    [RPlotExporter]
-    [MemoryDiagnoser]
-    public class TopicFilterComparerBenchmark : BaseBenchmark
+    readonly string _longTopic =
+        "AAAAAAAAAAAAAssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssshhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkAAAAAAAAAAAAAAABBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC";
+
+    [Benchmark]
+    public void MqttTopicFilterComparer_10000_LoopMethod()
     {
-        static readonly char[] TopicLevelSeparator = { '/' };
-
-        readonly string _longTopic =
-            "AAAAAAAAAAAAAssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssshhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkAAAAAAAAAAAAAAABBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC";
-
-        [Benchmark]
-        public void MqttTopicFilterComparer_10000_LoopMethod()
+        for (var i = 0; i < 100000; i++)
         {
-            for (var i = 0; i < 100000; i++)
-            {
-                MqttTopicFilterComparer.Compare("sport/tennis/player1", "sport/#");
-                MqttTopicFilterComparer.Compare("sport/tennis/player1/ranking", "sport/#/ranking");
-                MqttTopicFilterComparer.Compare("sport/tennis/player1/score/wimbledon", "sport/+/player1/#");
-                MqttTopicFilterComparer.Compare("sport/tennis/player1", "sport/tennis/+");
-                MqttTopicFilterComparer.Compare("/finance", "+/+");
-                MqttTopicFilterComparer.Compare("/finance", "/+");
-                MqttTopicFilterComparer.Compare("/finance", "+");
-                MqttTopicFilterComparer.Compare(_longTopic, _longTopic);
-            }
-        }
-
-        [Benchmark]
-        public void MqttTopicFilterComparer_10000_LoopMethod_Without_Pointer()
-        {
-            for (var i = 0; i < 100000; i++)
-            {
-                MqttTopicFilterComparerWithoutPointer.Compare("sport/tennis/player1", "sport/#");
-                MqttTopicFilterComparerWithoutPointer.Compare("sport/tennis/player1/ranking", "sport/#/ranking");
-                MqttTopicFilterComparerWithoutPointer.Compare("sport/tennis/player1/score/wimbledon", "sport/+/player1/#");
-                MqttTopicFilterComparerWithoutPointer.Compare("sport/tennis/player1", "sport/tennis/+");
-                MqttTopicFilterComparerWithoutPointer.Compare("/finance", "+/+");
-                MqttTopicFilterComparerWithoutPointer.Compare("/finance", "/+");
-                MqttTopicFilterComparerWithoutPointer.Compare("/finance", "+");
-                MqttTopicFilterComparerWithoutPointer.Compare(_longTopic, _longTopic);
-            }
-        }
-
-        [Benchmark]
-        public void MqttTopicFilterComparer_10000_StringSplitMethod()
-        {
-            for (var i = 0; i < 100000; i++)
-            {
-                LegacyMethodByStringSplit("sport/tennis/player1", "sport/#");
-                LegacyMethodByStringSplit("sport/tennis/player1/ranking", "sport/#/ranking");
-                LegacyMethodByStringSplit("sport/tennis/player1/score/wimbledon", "sport/+/player1/#");
-                LegacyMethodByStringSplit("sport/tennis/player1", "sport/tennis/+");
-                LegacyMethodByStringSplit("/finance", "+/+");
-                LegacyMethodByStringSplit("/finance", "/+");
-                LegacyMethodByStringSplit("/finance", "+");
-                MqttTopicFilterComparer.Compare(_longTopic, _longTopic);
-            }
-        }
-
-        [GlobalSetup]
-        public void Setup()
-        {
-        }
-
-        static bool LegacyMethodByStringSplit(string topic, string filter)
-        {
-            ArgumentNullException.ThrowIfNull(topic);
-            ArgumentNullException.ThrowIfNull(filter);
-
-            if (string.Equals(topic, filter, StringComparison.Ordinal))
-            {
-                return true;
-            }
-
-            var fragmentsTopic = topic.Split(TopicLevelSeparator, StringSplitOptions.None);
-            var fragmentsFilter = filter.Split(TopicLevelSeparator, StringSplitOptions.None);
-
-            // # > In either case it MUST be the last character specified in the Topic Filter [MQTT-4.7.1-2].
-            for (var i = 0; i < fragmentsFilter.Length; i++)
-            {
-                if (fragmentsFilter[i] == "+")
-                {
-                    continue;
-                }
-
-                if (fragmentsFilter[i] == "#")
-                {
-                    return true;
-                }
-
-                if (i >= fragmentsTopic.Length)
-                {
-                    return false;
-                }
-
-                if (!string.Equals(fragmentsFilter[i], fragmentsTopic[i], StringComparison.Ordinal))
-                {
-                    return false;
-                }
-            }
-
-            return fragmentsTopic.Length == fragmentsFilter.Length;
-        }
-
-        public static class MqttTopicFilterComparerWithoutPointer
-        {
-            public const char LevelSeparator = '/';
-            public const char MultiLevelWildcard = '#';
-            public const char SingleLevelWildcard = '+';
-            public const char ReservedTopicPrefix = '$';
-
-            public static MqttTopicFilterCompareResult Compare(string topic, string filter)
-            {
-                if (string.IsNullOrEmpty(topic))
-                {
-                    return MqttTopicFilterCompareResult.TopicInvalid;
-                }
-
-                if (string.IsNullOrEmpty(filter))
-                {
-                    return MqttTopicFilterCompareResult.FilterInvalid;
-                }
-
-                var filterOffset = 0;
-                var filterLength = filter.Length;
-
-                var topicOffset = 0;
-                var topicLength = topic.Length;
-
-                var topicPointer = topic;
-                var filterPointer = filter;
-
-                var isMultiLevelFilter = filterPointer[filterLength - 1] == MultiLevelWildcard;
-                var isReservedTopic = topicPointer[0] == ReservedTopicPrefix;
-
-                if (isReservedTopic && filterLength == 1 && isMultiLevelFilter)
-                {
-                    // It is not allowed to receive i.e. '$foo/bar' with filter '#'.
-                    return MqttTopicFilterCompareResult.NoMatch;
-                }
-
-                if (isReservedTopic && filterPointer[0] == SingleLevelWildcard)
-                {
-                    // It is not allowed to receive i.e. '$SYS/monitor/Clients' with filter '+/monitor/Clients'.
-                    return MqttTopicFilterCompareResult.NoMatch;
-                }
-
-                if (filterLength == 1 && isMultiLevelFilter)
-                {
-                    // Filter '#' matches basically everything.
-                    return MqttTopicFilterCompareResult.IsMatch;
-                }
-
-                // Go through the filter char by char.
-                while (filterOffset < filterLength && topicOffset < topicLength)
-                {
-                    // Check if the current char is a multi level wildcard. The char is only allowed
-                    // at the very las position.
-                    if (filterPointer[filterOffset] == MultiLevelWildcard && filterOffset != filterLength - 1)
-                    {
-                        return MqttTopicFilterCompareResult.FilterInvalid;
-                    }
-
-                    if (filterPointer[filterOffset] == topicPointer[topicOffset])
-                    {
-                        if (topicOffset == topicLength - 1)
-                        {
-                            // Check for e.g. "foo" matching "foo/#"
-                            if (filterOffset == filterLength - 3 && filterPointer[filterOffset + 1] == LevelSeparator && isMultiLevelFilter)
-                            {
-                                return MqttTopicFilterCompareResult.IsMatch;
-                            }
-
-                            // Check for e.g. "foo/" matching "foo/#"
-                            if (filterOffset == filterLength - 2 && filterPointer[filterOffset] == LevelSeparator && isMultiLevelFilter)
-                            {
-                                return MqttTopicFilterCompareResult.IsMatch;
-                            }
-                        }
-
-                        filterOffset++;
-                        topicOffset++;
-
-                        // Check if the end was reached and i.e. "foo/bar" matches "foo/bar"
-                        if (filterOffset == filterLength && topicOffset == topicLength)
-                        {
-                            return MqttTopicFilterCompareResult.IsMatch;
-                        }
-
-                        var endOfTopic = topicOffset == topicLength;
-
-                        if (endOfTopic && filterOffset == filterLength - 1 && filterPointer[filterOffset] == SingleLevelWildcard)
-                        {
-                            if (filterOffset > 0 && filterPointer[filterOffset - 1] != LevelSeparator)
-                            {
-                                return MqttTopicFilterCompareResult.FilterInvalid;
-                            }
-
-                            return MqttTopicFilterCompareResult.IsMatch;
-                        }
-                    }
-                    else
-                    {
-                        if (filterPointer[filterOffset] == SingleLevelWildcard)
-                        {
-                            // Check for invalid "+foo" or "a/+foo" subscription
-                            if (filterOffset > 0 && filterPointer[filterOffset - 1] != LevelSeparator)
-                            {
-                                return MqttTopicFilterCompareResult.FilterInvalid;
-                            }
-
-                            // Check for bad "foo+" or "foo+/a" subscription
-                            if (filterOffset < filterLength - 1 && filterPointer[filterOffset + 1] != LevelSeparator)
-                            {
-                                return MqttTopicFilterCompareResult.FilterInvalid;
-                            }
-
-                            filterOffset++;
-                            while (topicOffset < topicLength && topicPointer[topicOffset] != LevelSeparator)
-                            {
-                                topicOffset++;
-                            }
-
-                            if (topicOffset == topicLength && filterOffset == filterLength)
-                            {
-                                return MqttTopicFilterCompareResult.IsMatch;
-                            }
-                        }
-                        else if (filterPointer[filterOffset] == MultiLevelWildcard)
-                        {
-                            if (filterOffset > 0 && filterPointer[filterOffset - 1] != LevelSeparator)
-                            {
-                                return MqttTopicFilterCompareResult.FilterInvalid;
-                            }
-
-                            if (filterOffset + 1 != filterLength)
-                            {
-                                return MqttTopicFilterCompareResult.FilterInvalid;
-                            }
-
-                            return MqttTopicFilterCompareResult.IsMatch;
-                        }
-                        else
-                        {
-                            // Check for e.g. "foo/bar" matching "foo/+/#".
-                            if (filterOffset > 0 && filterOffset + 2 == filterLength && topicOffset == topicLength && filterPointer[filterOffset - 1] == SingleLevelWildcard &&
-                                filterPointer[filterOffset] == LevelSeparator && isMultiLevelFilter)
-                            {
-                                return MqttTopicFilterCompareResult.IsMatch;
-                            }
-
-                            return MqttTopicFilterCompareResult.NoMatch;
-                        }
-                    }
-                }
-
-                return MqttTopicFilterCompareResult.NoMatch;
-            }
+            MqttTopicFilterComparer.Compare("sport/tennis/player1", "sport/#");
+            MqttTopicFilterComparer.Compare("sport/tennis/player1/ranking", "sport/#/ranking");
+            MqttTopicFilterComparer.Compare("sport/tennis/player1/score/wimbledon", "sport/+/player1/#");
+            MqttTopicFilterComparer.Compare("sport/tennis/player1", "sport/tennis/+");
+            MqttTopicFilterComparer.Compare("/finance", "+/+");
+            MqttTopicFilterComparer.Compare("/finance", "/+");
+            MqttTopicFilterComparer.Compare("/finance", "+");
+            MqttTopicFilterComparer.Compare(_longTopic, _longTopic);
         }
     }
 }

Source/MQTTnet.Benchmarks/TopicGenerator.cs

@@ -1,84 +1,80 @@
-using System;
-using System.Collections.Generic;
+namespace MQTTnet.Benchmarks;
 
-namespace MQTTnet.Benchmarks
+public class TopicGenerator
 {
-    public class TopicGenerator
+    public static void Generate(
+        int numPublishers,
+        int numTopicsPerPublisher,
+        out Dictionary<string, List<string>> topicsByPublisher,
+        out Dictionary<string, List<string>> singleWildcardTopicsByPublisher,
+        out Dictionary<string, List<string>> multiWildcardTopicsByPublisher)
     {
-        public static void Generate(
-            int numPublishers,
-            int numTopicsPerPublisher,
-            out Dictionary<string, List<string>> topicsByPublisher,
-            out Dictionary<string, List<string>> singleWildcardTopicsByPublisher,
-            out Dictionary<string, List<string>> multiWildcardTopicsByPublisher)
+        topicsByPublisher = new Dictionary<string, List<string>>();
+        singleWildcardTopicsByPublisher = new Dictionary<string, List<string>>();
+        multiWildcardTopicsByPublisher = new Dictionary<string, List<string>>();
+
+        // Find some reasonable distribution across three topic levels
+        var topicsPerLevel = (int)Math.Pow(numTopicsPerPublisher, 1.0 / 3.0);
+        if (topicsPerLevel <= 0)
         {
-            topicsByPublisher = new Dictionary<string, List<string>>();
-            singleWildcardTopicsByPublisher = new Dictionary<string, List<string>>();
-            multiWildcardTopicsByPublisher = new Dictionary<string, List<string>>();
+            topicsPerLevel = 1;
+        }
 
-            // Find some reasonable distribution across three topic levels
-            var topicsPerLevel = (int)Math.Pow(numTopicsPerPublisher, 1.0 / 3.0);
-            if (topicsPerLevel <= 0)
+        var numLevel1Topics = topicsPerLevel;
+        var numLevel2Topics = topicsPerLevel;
+
+        var maxNumLevel3Topics = 1 + (int)((double)numTopicsPerPublisher / numLevel1Topics / numLevel2Topics);
+        if (maxNumLevel3Topics <= 0)
+        {
+            maxNumLevel3Topics = 1;
+        }
+
+        for (var p = 0; p < numPublishers; ++p)
+        {
+            var publisherTopicCount = 0;
+            var publisherName = "pub" + p;
+            for (var l1 = 0; l1 < numLevel1Topics; ++l1)
             {
-                topicsPerLevel = 1;
-            }
-
-            var numLevel1Topics = topicsPerLevel;
-            var numLevel2Topics = topicsPerLevel;
-
-            var maxNumLevel3Topics = 1 + (int)((double)numTopicsPerPublisher / numLevel1Topics / numLevel2Topics);
-            if (maxNumLevel3Topics <= 0)
-            {
-                maxNumLevel3Topics = 1;
-            }
-
-            for (var p = 0; p < numPublishers; ++p)
-            {
-                var publisherTopicCount = 0;
-                var publisherName = "pub" + p;
-                for (var l1 = 0; l1 < numLevel1Topics; ++l1)
+                for (var l2 = 0; l2 < numLevel2Topics; ++l2)
                 {
-                    for (var l2 = 0; l2 < numLevel2Topics; ++l2)
+                    for (var l3 = 0; l3 < maxNumLevel3Topics; ++l3)
                     {
-                        for (var l3 = 0; l3 < maxNumLevel3Topics; ++l3)
+                        if (publisherTopicCount >= numTopicsPerPublisher)
                         {
-                            if (publisherTopicCount >= numTopicsPerPublisher)
-                            {
-                                break;
-                            }
-
-                            var topic = $"{publisherName}/building{l1 + 1}/level{l2 + 1}/sensor{l3 + 1}";
-                            AddPublisherTopic(publisherName, topic, topicsByPublisher);
-
-                            if (l2 == 0)
-                            {
-                                var singleWildcardTopic = $"{publisherName}/building{l1 + 1}/+/sensor{l3 + 1}";
-                                AddPublisherTopic(publisherName, singleWildcardTopic, singleWildcardTopicsByPublisher);
-                            }
-
-                            if (l1 == 0 && l3 == 0)
-                            {
-                                var multiWildcardTopic = $"{publisherName}/+/level{l2 + 1}/+";
-                                AddPublisherTopic(publisherName, multiWildcardTopic, multiWildcardTopicsByPublisher);
-                            }
-
-                            ++publisherTopicCount;
+                            break;
                         }
+
+                        var topic = $"{publisherName}/building{l1 + 1}/level{l2 + 1}/sensor{l3 + 1}";
+                        AddPublisherTopic(publisherName, topic, topicsByPublisher);
+
+                        if (l2 == 0)
+                        {
+                            var singleWildcardTopic = $"{publisherName}/building{l1 + 1}/+/sensor{l3 + 1}";
+                            AddPublisherTopic(publisherName, singleWildcardTopic, singleWildcardTopicsByPublisher);
+                        }
+
+                        if (l1 == 0 && l3 == 0)
+                        {
+                            var multiWildcardTopic = $"{publisherName}/+/level{l2 + 1}/+";
+                            AddPublisherTopic(publisherName, multiWildcardTopic, multiWildcardTopicsByPublisher);
+                        }
+
+                        ++publisherTopicCount;
                     }
                 }
             }
         }
+    }
 
-        static void AddPublisherTopic(string publisherName, string topic, Dictionary<string, List<string>> topicsByPublisher)
+    static void AddPublisherTopic(string publisherName, string topic, Dictionary<string, List<string>> topicsByPublisher)
+    {
+        List<string> topicList;
+        if (!topicsByPublisher.TryGetValue(publisherName, out topicList))
         {
-            List<string> topicList;
-            if (!topicsByPublisher.TryGetValue(publisherName, out topicList))
-            {
-                topicList = new List<string>();
-                topicsByPublisher.Add(publisherName, topicList);
-            }
-
-            topicList.Add(topic);
+            topicList = new List<string>();
+            topicsByPublisher.Add(publisherName, topicList);
         }
+
+        topicList.Add(topic);
     }
 }

Source/MQTTnet.Benchmarks/UnsubscribeBenchmark.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System.Collections.Generic;
-using System.Linq;
 using BenchmarkDotNet.Attributes;
 using MQTTnet.Server;
 
@@ -14,15 +12,15 @@ public class UnsubscribeBenchmark : BaseBenchmark
 {
     const int NumPublishers = 1;
     const int NumTopicsPerPublisher = 10000;
+
     IMqttClient _mqttClient;
     MqttServer _mqttServer;
-
     List<string> _topics;
 
     [GlobalSetup]
     public void Setup()
     {
-        TopicGenerator.Generate(NumPublishers, NumTopicsPerPublisher, out var topicsByPublisher, out var singleWildcardTopicsByPublisher, out var multiWildcardTopicsByPublisher);
+        TopicGenerator.Generate(NumPublishers, NumTopicsPerPublisher, out var topicsByPublisher, out _, out _);
         _topics = topicsByPublisher.Values.First();
 
         var serverOptions = new MqttServerOptionsBuilder().WithDefaultEndpoint().Build();

Source/MQTTnet.Extensions.Rpc/DefaultMqttRpcClientTopicGenerationStrategy.cs

@@ -2,29 +2,26 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
+namespace MQTTnet.Extensions.Rpc;
 
-namespace MQTTnet.Extensions.Rpc
+public sealed class DefaultMqttRpcClientTopicGenerationStrategy : IMqttRpcClientTopicGenerationStrategy
 {
-    public sealed class DefaultMqttRpcClientTopicGenerationStrategy : IMqttRpcClientTopicGenerationStrategy
+    public MqttRpcTopicPair CreateRpcTopics(TopicGenerationContext context)
     {
-        public MqttRpcTopicPair CreateRpcTopics(TopicGenerationContext context)
+        ArgumentNullException.ThrowIfNull(context);
+
+        if (context.MethodName.Contains('/') || context.MethodName.Contains('+') || context.MethodName.Contains('#'))
         {
-            ArgumentNullException.ThrowIfNull(context);
-
-            if (context.MethodName.Contains("/") || context.MethodName.Contains("+") || context.MethodName.Contains("#"))
-            {
-                throw new ArgumentException("The method name cannot contain /, + or #.");
-            }
-
-            var requestTopic = $"MQTTnet.RPC/{Guid.NewGuid():N}/{context.MethodName}";
-            var responseTopic = requestTopic + "/response";
-
-            return new MqttRpcTopicPair
-            {
-                RequestTopic = requestTopic,
-                ResponseTopic = responseTopic
-            };
+            throw new ArgumentException("The method name cannot contain /, + or #.");
         }
+
+        var requestTopic = $"MQTTnet.RPC/{Guid.NewGuid():N}/{context.MethodName}";
+        var responseTopic = requestTopic + "/response";
+
+        return new MqttRpcTopicPair
+        {
+            RequestTopic = requestTopic,
+            ResponseTopic = responseTopic
+        };
     }
-}
+}

Source/MQTTnet.Extensions.Rpc/IMqttRpcClient.cs

@@ -2,18 +2,13 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Extensions.Rpc
+namespace MQTTnet.Extensions.Rpc;
+
+public interface IMqttRpcClient : IDisposable
 {
-    public interface IMqttRpcClient : IDisposable
-    {
-        Task<byte[]> ExecuteAsync(TimeSpan timeout, string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string,object> parameters = null);
-        
-        Task<byte[]> ExecuteAsync(string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string, object> parameters = null, CancellationToken cancellationToken = default);
-    }
+    Task<byte[]> ExecuteAsync(TimeSpan timeout, string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string,object> parameters = null);
+
+    Task<byte[]> ExecuteAsync(string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string, object> parameters = null, CancellationToken cancellationToken = default);
 }

Source/MQTTnet.Extensions.Rpc/IMqttRpcClientTopicGenerationStrategy.cs

@@ -2,10 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-namespace MQTTnet.Extensions.Rpc
+namespace MQTTnet.Extensions.Rpc;
+
+public interface IMqttRpcClientTopicGenerationStrategy
 {
-    public interface IMqttRpcClientTopicGenerationStrategy
-    {
-        MqttRpcTopicPair CreateRpcTopics(TopicGenerationContext context);
-    }
-}
+    MqttRpcTopicPair CreateRpcTopics(TopicGenerationContext context);
+}

Source/MQTTnet.Extensions.Rpc/MQTTnet.Extensions.Rpc.csproj

@@ -1,54 +1,19 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net8.0</TargetFramework>
         <AssemblyName>MQTTnet.Extensions.Rpc</AssemblyName>
         <RootNamespace>MQTTnet.Extensions.Rpc</RootNamespace>
+        <IsAotCompatible>true</IsAotCompatible>
+
         <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-        <Company>The contributors of MQTTnet</Company>
-        <Product>MQTTnet</Product>
         <Description>This is an extension library which allows executing synchronous device calls including a response using MQTTnet.</Description>
-        <Authors>The contributors of MQTTnet</Authors>
         <PackageId>MQTTnet.Extensions.Rpc</PackageId>
-        <SignAssembly>false</SignAssembly>
-        <DelaySign>false</DelaySign>
-        <PublishRepositoryUrl>true</PublishRepositoryUrl>
-        <IncludeSymbols>true</IncludeSymbols>
-        <SymbolPackageFormat>snupkg</SymbolPackageFormat>
-        <Copyright>Copyright (c) .NET Foundation and Contributors</Copyright>
-        <PackageProjectUrl>https://github.com/dotnet/MQTTnet</PackageProjectUrl>
-        <RepositoryUrl>https://github.com/dotnet/MQTTnet.git</RepositoryUrl>
-        <RepositoryType>git</RepositoryType>
         <PackageTags>MQTT Message Queue Telemetry Transport MQTTClient MQTTServer Server MQTTBroker Broker NETStandard IoT InternetOfThings Messaging Hardware Arduino Sensor Actuator M2M ESP Smart Home Cities Automation Xamarin Blazor</PackageTags>
-        <NeutralLanguage>en-US</NeutralLanguage>
-        <EnableNETAnalyzers>false</EnableNETAnalyzers>
-        <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
-        <PackageIcon>nuget.png</PackageIcon>
         <EmbedUntrackedSources>true</EmbedUntrackedSources>
-        <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
-        <PackageLicenseExpression>MIT</PackageLicenseExpression>
         <PackageReleaseNotes>For release notes please go to MQTTnet release notes (https://www.nuget.org/packages/MQTTnet/).</PackageReleaseNotes>
-        <DisableImplicitAspNetCoreAnalyzers>true</DisableImplicitAspNetCoreAnalyzers>
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
-        <NoWarn>1591;NETSDK1138;NU1803;NU1901;NU1902</NoWarn>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-        <NuGetAuditMode>all</NuGetAuditMode>
-        <NuGetAudit>true</NuGetAudit>
-        <NuGetAuditLevel>low</NuGetAuditLevel>
-        <AnalysisLevel>latest-Recommended</AnalysisLevel>
     </PropertyGroup>
 
-    <ItemGroup>
-        <None Include="..\..\Images\nuget.png">
-            <Pack>True</Pack>
-            <PackagePath>\</PackagePath>
-        </None>
-    </ItemGroup>
-
-    <ItemGroup>
-        <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
-    </ItemGroup>
-
     <ItemGroup>
         <ProjectReference Include="..\MQTTnet\MQTTnet.csproj"/>
     </ItemGroup>

Source/MQTTnet.Extensions.Rpc/MqttFactoryExtensions.cs

@@ -2,28 +2,25 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
+namespace MQTTnet.Extensions.Rpc;
 
-namespace MQTTnet.Extensions.Rpc
+public static class MqttFactoryExtensions
 {
-    public static class MqttFactoryExtensions
+    public static IMqttRpcClient CreateMqttRpcClient(this MqttClientFactory clientFactory, IMqttClient mqttClient)
     {
-        public static IMqttRpcClient CreateMqttRpcClient(this MqttClientFactory clientFactory, IMqttClient mqttClient)
-        {
-            return clientFactory.CreateMqttRpcClient(
-                mqttClient,
-                new MqttRpcClientOptions
-                {
-                    TopicGenerationStrategy = new DefaultMqttRpcClientTopicGenerationStrategy()
-                });
-        }
+        return clientFactory.CreateMqttRpcClient(
+            mqttClient,
+            new MqttRpcClientOptions
+            {
+                TopicGenerationStrategy = new DefaultMqttRpcClientTopicGenerationStrategy()
+            });
+    }
 
-        public static IMqttRpcClient CreateMqttRpcClient(this MqttClientFactory _, IMqttClient mqttClient, MqttRpcClientOptions rpcClientOptions)
-        {
-            ArgumentNullException.ThrowIfNull(mqttClient);
-            ArgumentNullException.ThrowIfNull(rpcClientOptions);
+    public static IMqttRpcClient CreateMqttRpcClient(this MqttClientFactory _, IMqttClient mqttClient, MqttRpcClientOptions rpcClientOptions)
+    {
+        ArgumentNullException.ThrowIfNull(mqttClient);
+        ArgumentNullException.ThrowIfNull(rpcClientOptions);
 
-            return new MqttRpcClient(mqttClient, rpcClientOptions);
-        }
+        return new MqttRpcClient(mqttClient, rpcClientOptions);
     }
 }

Source/MQTTnet.Extensions.Rpc/MqttRpcClient.cs

@@ -2,140 +2,132 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Buffers;
 using System.Collections.Concurrent;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using MQTTnet.Exceptions;
 using MQTTnet.Formatter;
 using MQTTnet.Internal;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Extensions.Rpc
+namespace MQTTnet.Extensions.Rpc;
+
+public sealed class MqttRpcClient : IMqttRpcClient
 {
-    public sealed class MqttRpcClient : IMqttRpcClient
+    readonly IMqttClient _mqttClient;
+    readonly MqttRpcClientOptions _options;
+
+    readonly ConcurrentDictionary<string, AsyncTaskCompletionSource<byte[]>> _waitingCalls = new ConcurrentDictionary<string, AsyncTaskCompletionSource<byte[]>>();
+
+    public MqttRpcClient(IMqttClient mqttClient, MqttRpcClientOptions options)
     {
-        readonly IMqttClient _mqttClient;
-        readonly MqttRpcClientOptions _options;
+        _mqttClient = mqttClient ?? throw new ArgumentNullException(nameof(mqttClient));
+        _options = options ?? throw new ArgumentNullException(nameof(options));
 
-        readonly ConcurrentDictionary<string, AsyncTaskCompletionSource<byte[]>> _waitingCalls = new ConcurrentDictionary<string, AsyncTaskCompletionSource<byte[]>>();
+        _mqttClient.ApplicationMessageReceivedAsync += HandleApplicationMessageReceivedAsync;
+    }
 
-        public MqttRpcClient(IMqttClient mqttClient, MqttRpcClientOptions options)
+    public void Dispose()
+    {
+        _mqttClient.ApplicationMessageReceivedAsync -= HandleApplicationMessageReceivedAsync;
+
+        foreach (var tcs in _waitingCalls)
         {
-            _mqttClient = mqttClient ?? throw new ArgumentNullException(nameof(mqttClient));
-            _options = options ?? throw new ArgumentNullException(nameof(options));
-
-            _mqttClient.ApplicationMessageReceivedAsync += HandleApplicationMessageReceivedAsync;
+            tcs.Value.TrySetCanceled();
         }
 
-        public void Dispose()
+        _waitingCalls.Clear();
+    }
+
+    public async Task<byte[]> ExecuteAsync(TimeSpan timeout, string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string, object> parameters = null)
+    {
+        using var timeoutToken = new CancellationTokenSource(timeout);
+        try
         {
-            _mqttClient.ApplicationMessageReceivedAsync -= HandleApplicationMessageReceivedAsync;
-
-            foreach (var tcs in _waitingCalls)
-            {
-                tcs.Value.TrySetCanceled();
-            }
-
-            _waitingCalls.Clear();
+            return await ExecuteAsync(methodName, payload, qualityOfServiceLevel, parameters, timeoutToken.Token).ConfigureAwait(false);
         }
-
-        public async Task<byte[]> ExecuteAsync(TimeSpan timeout, string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string, object> parameters = null)
+        catch (OperationCanceledException exception)
         {
-            using (var timeoutToken = new CancellationTokenSource(timeout))
+            if (timeoutToken.IsCancellationRequested)
             {
-                try
-                {
-                    return await ExecuteAsync(methodName, payload, qualityOfServiceLevel, parameters, timeoutToken.Token).ConfigureAwait(false);
-                }
-                catch (OperationCanceledException exception)
-                {
-                    if (timeoutToken.IsCancellationRequested)
-                    {
-                        throw new MqttCommunicationTimedOutException(exception);
-                    }
-
-                    throw;
-                }
-            }
-        }
-
-        public async Task<byte[]> ExecuteAsync(string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string, object> parameters = null, CancellationToken cancellationToken = default)
-        {
-            ArgumentNullException.ThrowIfNull(methodName);
-
-            var context = new TopicGenerationContext(_mqttClient, _options, methodName, parameters, qualityOfServiceLevel);
-            var topicNames = _options.TopicGenerationStrategy.CreateRpcTopics(context);
-
-            var requestTopic = topicNames.RequestTopic;
-            var responseTopic = topicNames.ResponseTopic;
-
-            if (string.IsNullOrWhiteSpace(requestTopic))
-            {
-                throw new MqttProtocolViolationException("RPC request topic is empty.");
+                throw new MqttCommunicationTimedOutException(exception);
             }
 
-            if (string.IsNullOrWhiteSpace(responseTopic))
-            {
-                throw new MqttProtocolViolationException("RPC response topic is empty.");
-            }
-
-            var requestMessageBuilder = new MqttApplicationMessageBuilder().WithTopic(requestTopic).WithPayload(payload).WithQualityOfServiceLevel(qualityOfServiceLevel);
-
-            if (_mqttClient.Options.ProtocolVersion == MqttProtocolVersion.V500)
-            {
-                requestMessageBuilder.WithResponseTopic(responseTopic);
-            }
-
-            var requestMessage = requestMessageBuilder.Build();
-
-            try
-            {
-                var awaitable = new AsyncTaskCompletionSource<byte[]>();
-
-                if (!_waitingCalls.TryAdd(responseTopic, awaitable))
-                {
-                    throw new InvalidOperationException();
-                }
-
-                var subscribeOptions = new MqttClientSubscribeOptionsBuilder().WithTopicFilter(responseTopic, qualityOfServiceLevel).Build();
-
-                await _mqttClient.SubscribeAsync(subscribeOptions, cancellationToken).ConfigureAwait(false);
-                await _mqttClient.PublishAsync(requestMessage, cancellationToken).ConfigureAwait(false);
-
-                using (cancellationToken.Register(
-                           () =>
-                           {
-                               awaitable.TrySetCanceled();
-                           }))
-                {
-                    return await awaitable.Task.ConfigureAwait(false);
-                }
-            }
-            finally
-            {
-                _waitingCalls.TryRemove(responseTopic, out _);
-                await _mqttClient.UnsubscribeAsync(responseTopic, CancellationToken.None).ConfigureAwait(false);
-            }
-        }
-
-        Task HandleApplicationMessageReceivedAsync(MqttApplicationMessageReceivedEventArgs eventArgs)
-        {
-            if (!_waitingCalls.TryRemove(eventArgs.ApplicationMessage.Topic, out var awaitable))
-            {
-                return CompletedTask.Instance;
-            }
-
-            var payloadBuffer = eventArgs.ApplicationMessage.Payload.ToArray();
-            awaitable.TrySetResult(payloadBuffer);
-
-            // Set this message to handled to that other code can avoid execution etc.
-            eventArgs.IsHandled = true;
-
-            return CompletedTask.Instance;
+            throw;
         }
     }
+
+    public async Task<byte[]> ExecuteAsync(string methodName, byte[] payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string, object> parameters = null, CancellationToken cancellationToken = default)
+    {
+        ArgumentNullException.ThrowIfNull(methodName);
+
+        var context = new TopicGenerationContext(_mqttClient, _options, methodName, parameters, qualityOfServiceLevel);
+        var topicNames = _options.TopicGenerationStrategy.CreateRpcTopics(context);
+
+        var requestTopic = topicNames.RequestTopic;
+        var responseTopic = topicNames.ResponseTopic;
+
+        if (string.IsNullOrWhiteSpace(requestTopic))
+        {
+            throw new MqttProtocolViolationException("RPC request topic is empty.");
+        }
+
+        if (string.IsNullOrWhiteSpace(responseTopic))
+        {
+            throw new MqttProtocolViolationException("RPC response topic is empty.");
+        }
+
+        var requestMessageBuilder = new MqttApplicationMessageBuilder().WithTopic(requestTopic).WithPayload(payload).WithQualityOfServiceLevel(qualityOfServiceLevel);
+
+        if (_mqttClient.Options.ProtocolVersion == MqttProtocolVersion.V500)
+        {
+            requestMessageBuilder.WithResponseTopic(responseTopic);
+        }
+
+        var requestMessage = requestMessageBuilder.Build();
+
+        try
+        {
+            var awaitable = new AsyncTaskCompletionSource<byte[]>();
+
+            if (!_waitingCalls.TryAdd(responseTopic, awaitable))
+            {
+                throw new InvalidOperationException();
+            }
+
+            var subscribeOptions = new MqttClientSubscribeOptionsBuilder().WithTopicFilter(responseTopic, qualityOfServiceLevel).Build();
+
+            await _mqttClient.SubscribeAsync(subscribeOptions, cancellationToken).ConfigureAwait(false);
+            await _mqttClient.PublishAsync(requestMessage, cancellationToken).ConfigureAwait(false);
+
+            using (cancellationToken.Register(
+                       () =>
+                       {
+                           awaitable.TrySetCanceled();
+                       }))
+            {
+                return await awaitable.Task.ConfigureAwait(false);
+            }
+        }
+        finally
+        {
+            _waitingCalls.TryRemove(responseTopic, out _);
+            await _mqttClient.UnsubscribeAsync(responseTopic, CancellationToken.None).ConfigureAwait(false);
+        }
+    }
+
+    Task HandleApplicationMessageReceivedAsync(MqttApplicationMessageReceivedEventArgs eventArgs)
+    {
+        if (!_waitingCalls.TryRemove(eventArgs.ApplicationMessage.Topic, out var awaitable))
+        {
+            return CompletedTask.Instance;
+        }
+
+        var payloadBuffer = eventArgs.ApplicationMessage.Payload.ToArray();
+        awaitable.TrySetResult(payloadBuffer);
+
+        // Set this message to handled to that other code can avoid execution etc.
+        eventArgs.IsHandled = true;
+
+        return CompletedTask.Instance;
+    }
 }

Source/MQTTnet.Extensions.Rpc/MqttRpcClientExtensions.cs

@@ -2,23 +2,19 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
 using System.Text;
-using System.Threading.Tasks;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Extensions.Rpc
+namespace MQTTnet.Extensions.Rpc;
+
+public static class MqttRpcClientExtensions
 {
-    public static class MqttRpcClientExtensions
+    public static Task<byte[]> ExecuteAsync(this IMqttRpcClient client, TimeSpan timeout, string methodName, string payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string,object> parameters = null)
     {
-        public static Task<byte[]> ExecuteAsync(this IMqttRpcClient client, TimeSpan timeout, string methodName, string payload, MqttQualityOfServiceLevel qualityOfServiceLevel, IDictionary<string,object> parameters = null)
-        {
-            if (client == null) throw new ArgumentNullException(nameof(client));
+        ArgumentNullException.ThrowIfNull(client);
 
-            var buffer = Encoding.UTF8.GetBytes(payload ?? string.Empty);
+        var buffer = Encoding.UTF8.GetBytes(payload ?? string.Empty);
 
-            return client.ExecuteAsync(timeout, methodName, buffer, qualityOfServiceLevel, parameters);
-        }
+        return client.ExecuteAsync(timeout, methodName, buffer, qualityOfServiceLevel, parameters);
     }
 }

Source/MQTTnet.Extensions.Rpc/MqttRpcClientOptions.cs

@@ -2,10 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-namespace MQTTnet.Extensions.Rpc
+namespace MQTTnet.Extensions.Rpc;
+
+public sealed class MqttRpcClientOptions
 {
-    public sealed class MqttRpcClientOptions
-    {
-        public IMqttRpcClientTopicGenerationStrategy TopicGenerationStrategy { get; set; } = new DefaultMqttRpcClientTopicGenerationStrategy();
-    }
-}
+    public IMqttRpcClientTopicGenerationStrategy TopicGenerationStrategy { get; set; } = new DefaultMqttRpcClientTopicGenerationStrategy();
+}

Source/MQTTnet.Extensions.Rpc/MqttRpcClientOptionsBuilder.cs

@@ -2,27 +2,24 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
+namespace MQTTnet.Extensions.Rpc;
 
-namespace MQTTnet.Extensions.Rpc
+public sealed class MqttRpcClientOptionsBuilder
 {
-    public sealed class MqttRpcClientOptionsBuilder
+    IMqttRpcClientTopicGenerationStrategy _topicGenerationStrategy = new DefaultMqttRpcClientTopicGenerationStrategy();
+
+    public MqttRpcClientOptions Build()
     {
-        IMqttRpcClientTopicGenerationStrategy _topicGenerationStrategy = new DefaultMqttRpcClientTopicGenerationStrategy();
-
-        public MqttRpcClientOptions Build()
+        return new MqttRpcClientOptions
         {
-            return new MqttRpcClientOptions
-            {
-                TopicGenerationStrategy = _topicGenerationStrategy
-            };
-        }
+            TopicGenerationStrategy = _topicGenerationStrategy
+        };
+    }
 
-        public MqttRpcClientOptionsBuilder WithTopicGenerationStrategy(IMqttRpcClientTopicGenerationStrategy value)
-        {
-            _topicGenerationStrategy = value ?? throw new ArgumentNullException(nameof(value));
+    public MqttRpcClientOptionsBuilder WithTopicGenerationStrategy(IMqttRpcClientTopicGenerationStrategy value)
+    {
+        _topicGenerationStrategy = value ?? throw new ArgumentNullException(nameof(value));
 
-            return this;
-        }
+        return this;
     }
 }

Source/MQTTnet.Extensions.Rpc/MqttRpcTopicPair.cs

@@ -2,12 +2,11 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-namespace MQTTnet.Extensions.Rpc
-{
-    public sealed class MqttRpcTopicPair
-    {
-        public string RequestTopic { get; set; }
+namespace MQTTnet.Extensions.Rpc;
 
-        public string ResponseTopic { get; set; }
-    }
-}
+public sealed class MqttRpcTopicPair
+{
+    public string RequestTopic { get; set; }
+
+    public string ResponseTopic { get; set; }
+}

Source/MQTTnet.Extensions.Rpc/TopicGenerationContext.cs

@@ -2,41 +2,38 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Extensions.Rpc
+namespace MQTTnet.Extensions.Rpc;
+
+public sealed class TopicGenerationContext
 {
-    public sealed class TopicGenerationContext
+    public TopicGenerationContext(IMqttClient mqttClient, MqttRpcClientOptions options, string methodName,
+        IDictionary<string, object> parameters, MqttQualityOfServiceLevel qualityOfServiceLevel)
     {
-        public TopicGenerationContext(IMqttClient mqttClient, MqttRpcClientOptions options, string methodName,
-            IDictionary<string, object> parameters, MqttQualityOfServiceLevel qualityOfServiceLevel)
-        {
-            MethodName = methodName ?? throw new ArgumentNullException(nameof(methodName));
-            Parameters = parameters;
-            QualityOfServiceLevel = qualityOfServiceLevel;
-            MqttClient = mqttClient ?? throw new ArgumentNullException(nameof(mqttClient));
-            Options = options ?? throw new ArgumentNullException(nameof(options));
-        }
-
-        public string MethodName { get; }
-
-        public IDictionary<string, object> Parameters { get; }
-
-        public IMqttClient MqttClient { get; }
-
-        public MqttRpcClientOptions Options { get; }
-
-        /// <summary>
-        ///     Gets or sets the quality of service level.
-        ///     The Quality of Service (QoS) level is an agreement between the sender of a message and the receiver of a message
-        ///     that defines the guarantee of delivery for a specific message.
-        ///     There are 3 QoS levels in MQTT:
-        ///     - At most once  (0): Message gets delivered no time, once or multiple times.
-        ///     - At least once (1): Message gets delivered at least once (one time or more often).
-        ///     - Exactly once  (2): Message gets delivered exactly once (It's ensured that the message only comes once).
-        /// </summary>
-        public MqttQualityOfServiceLevel QualityOfServiceLevel { get; }
+        MethodName = methodName ?? throw new ArgumentNullException(nameof(methodName));
+        Parameters = parameters;
+        QualityOfServiceLevel = qualityOfServiceLevel;
+        MqttClient = mqttClient ?? throw new ArgumentNullException(nameof(mqttClient));
+        Options = options ?? throw new ArgumentNullException(nameof(options));
     }
+
+    public string MethodName { get; }
+
+    public IDictionary<string, object> Parameters { get; }
+
+    public IMqttClient MqttClient { get; }
+
+    public MqttRpcClientOptions Options { get; }
+
+    /// <summary>
+    ///     Gets or sets the quality of service level.
+    ///     The Quality of Service (QoS) level is an agreement between the sender of a message and the receiver of a message
+    ///     that defines the guarantee of delivery for a specific message.
+    ///     There are 3 QoS levels in MQTT:
+    ///     - At most once  (0): Message gets delivered no time, once or multiple times.
+    ///     - At least once (1): Message gets delivered at least once (one time or more often).
+    ///     - Exactly once  (2): Message gets delivered exactly once (It's ensured that the message only comes once).
+    /// </summary>
+    public MqttQualityOfServiceLevel QualityOfServiceLevel { get; }
 }

Source/MQTTnet.Extensions.TopicTemplate/MQTTnet.Extensions.TopicTemplate.csproj

@@ -1,53 +1,25 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net8.0</TargetFramework>
         <AssemblyName>MQTTnet.Extensions.TopicTemplate</AssemblyName>
         <RootNamespace>MQTTnet.Extensions.TopicTemplate</RootNamespace>
+        <IsAotCompatible>true</IsAotCompatible>
+
         <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
-        <Company>The contributors of MQTTnet</Company>
-        <Product>MQTTnet</Product>
         <Description>
            Provides mqtt topic templating logic to support dispatch,
            routing and similar functionality based on the well known moustache syntax (AsyncAPI compatible).
         </Description>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
-        <Authors>The contributors of MQTTnet</Authors>
         <PackageId>MQTTnet.Extensions.TopicTemplate</PackageId>
-        <SignAssembly>false</SignAssembly>
-        <DelaySign>false</DelaySign>
-        <PublishRepositoryUrl>true</PublishRepositoryUrl>
-        <IncludeSymbols>true</IncludeSymbols>
-        <SymbolPackageFormat>snupkg</SymbolPackageFormat>
-        <Copyright>Copyright (c) .NET Foundation and Contributors</Copyright>
-        <PackageProjectUrl>https://github.com/dotnet/MQTTnet</PackageProjectUrl>
-        <RepositoryUrl>https://github.com/dotnet/MQTTnet.git</RepositoryUrl>
-        <RepositoryType>git</RepositoryType>
         <PackageTags>MQTT Message Queue Telemetry MQTTClient Messaging Routing AsyncAPI Template</PackageTags>
-        <NeutralLanguage>en-US</NeutralLanguage>
-        <PackageIcon>nuget.png</PackageIcon>
-        <EmbedUntrackedSources>true</EmbedUntrackedSources>
-        <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
-        <PackageLicenseExpression>MIT</PackageLicenseExpression>
         <PackageReleaseNotes>For release notes please go to MQTTnet release notes (https://www.nuget.org/packages/MQTTnet/).</PackageReleaseNotes>
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
-        <NoWarn>1591;NETSDK1138</NoWarn>
+
     </PropertyGroup>
 
     <ItemGroup>
-        <None Include="README.md">
-            <Pack>True</Pack>
-            <PackagePath>\</PackagePath>
-        </None>
-        <None Include="..\..\Images\nuget.png">
-            <Pack>True</Pack>
-            <PackagePath>\</PackagePath>
-        </None>
-    </ItemGroup>
-
-    <ItemGroup>
-        <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
-        <PackageReference Include="System.ValueTuple" Version="4.5.0" />
+        <PackageReference Include="System.ValueTuple" Version="4.6.1" />
     </ItemGroup>
 
     <ItemGroup>

Source/MQTTnet.Extensions.TopicTemplate/MqttTopicTemplate.cs

@@ -2,11 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using System.Text.RegularExpressions;
-using System.Threading;
 using MQTTnet.Protocol;
 
 namespace MQTTnet.Extensions.TopicTemplate;
@@ -84,13 +80,13 @@ public sealed class MqttTopicTemplate : IEquatable<MqttTopicTemplate>
         {
             var filter = TopicFilter;
             // append slash if neccessary
-            if (filter.Length > 0 && !filter.EndsWith(MqttTopicFilterComparer.LevelSeparator.ToString()) && !filter.EndsWith(MqttTopicFilterComparer.MultiLevelWildcard.ToString()))
+            if (filter.Length > 0 && !filter.EndsWith(MqttTopicFilterComparer.LevelSeparator) && !filter.EndsWith(MqttTopicFilterComparer.MultiLevelWildcard))
             {
                 filter += MqttTopicFilterComparer.LevelSeparator;
             }
 
             // append hash if neccessary
-            if (!filter.EndsWith(MqttTopicFilterComparer.MultiLevelWildcard.ToString()))
+            if (!filter.EndsWith(MqttTopicFilterComparer.MultiLevelWildcard))
             {
                 filter += MqttTopicFilterComparer.MultiLevelWildcard;
             }
@@ -161,12 +157,12 @@ public sealed class MqttTopicTemplate : IEquatable<MqttTopicTemplate>
             return new MqttTopicTemplate(MqttTopicFilterComparer.MultiLevelWildcard.ToString());
         }
 
-        if (root.Contains(MqttTopicFilterComparer.LevelSeparator) && !root.EndsWith(MqttTopicFilterComparer.LevelSeparator.ToString()) && !root.EndsWith("}"))
+        if (root.Contains(MqttTopicFilterComparer.LevelSeparator) && !root.EndsWith(MqttTopicFilterComparer.LevelSeparator.ToString(), StringComparison.InvariantCulture) && !root.EndsWith('}'))
         {
             root = root.Substring(0, root.LastIndexOf(MqttTopicFilterComparer.LevelSeparator) + 1);
         }
 
-        if (root.EndsWith(MqttTopicFilterComparer.LevelSeparator.ToString()))
+        if (root.EndsWith(MqttTopicFilterComparer.LevelSeparator.ToString(), StringComparison.InvariantCulture))
         {
             root += MqttTopicFilterComparer.SingleLevelWildcard;
         }
@@ -230,7 +226,7 @@ public sealed class MqttTopicTemplate : IEquatable<MqttTopicTemplate>
             throw new ArgumentException("the topic has to match this template", nameof(topic));
         }
 
-        return parseParameterValuesInternal(topic);
+        return ParseParameterValuesInternal(topic);
     }
 
     /// <summary>
@@ -330,7 +326,7 @@ public sealed class MqttTopicTemplate : IEquatable<MqttTopicTemplate>
         return parameters.Aggregate(this, (t, p) => t.TrySetParameter(p.parameter, p.value));
     }
 
-    IEnumerable<(string parameter, int index, string value)> parseParameterValuesInternal(string topic)
+    IEnumerable<(string parameter, int index, string value)> ParseParameterValuesInternal(string topic)
     {
         // because we have a match, we know the segment array is at least the template's length
         var segments = topic.Split(MqttTopicFilterComparer.LevelSeparator);

Source/MQTTnet.Extensions.TopicTemplate/TopicTemplateExtensions.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Linq;
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 

Source/MQTTnet.Server/Disconnecting/MqttServerClientDisconnectOptions.cs

@@ -5,28 +5,27 @@
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class MqttServerClientDisconnectOptions
 {
-    public sealed class MqttServerClientDisconnectOptions
-    {
-        public MqttDisconnectReasonCode ReasonCode { get; set; } = MqttDisconnectReasonCode.NormalDisconnection;
+    public MqttDisconnectReasonCode ReasonCode { get; set; } = MqttDisconnectReasonCode.NormalDisconnection;
 
-        /// <summary>
-        ///     The reason string is sent to every client via a DISCONNECT packet.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public string ReasonString { get; set; }
+    /// <summary>
+    ///     The reason string is sent to every client via a DISCONNECT packet.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public string ReasonString { get; set; }
 
-        /// <summary>
-        ///     The server reference is sent to every client via a DISCONNECT packet.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public string ServerReference { get; set; }
+    /// <summary>
+    ///     The server reference is sent to every client via a DISCONNECT packet.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public string ServerReference { get; set; }
 
-        /// <summary>
-        ///     These user properties are sent to every client via a DISCONNECT packet.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public List<MqttUserProperty> UserProperties { get; set; }
-    }
+    /// <summary>
+    ///     These user properties are sent to every client via a DISCONNECT packet.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public List<MqttUserProperty> UserProperties { get; set; }
 }

Source/MQTTnet.Server/Disconnecting/MqttServerClientDisconnectOptionsBuilder.cs

@@ -5,50 +5,72 @@
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class MqttServerClientDisconnectOptionsBuilder
 {
-    public sealed class MqttServerClientDisconnectOptionsBuilder
+    readonly MqttServerClientDisconnectOptions _options = new MqttServerClientDisconnectOptions();
+
+    public MqttServerClientDisconnectOptions Build()
     {
-        readonly MqttServerClientDisconnectOptions _options = new MqttServerClientDisconnectOptions();
+        return _options;
+    }
 
-        public MqttServerClientDisconnectOptions Build()
+    public MqttServerClientDisconnectOptionsBuilder WithReasonCode(MqttDisconnectReasonCode value)
+    {
+        _options.ReasonCode = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithReasonString(string value)
+    {
+        _options.ReasonString = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithServerReference(string value)
+    {
+        _options.ServerReference = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithUserProperties(List<MqttUserProperty> value)
+    {
+        _options.UserProperties = value;
+        return this;
+    }
+
+    [Obsolete("Please use more performance `WithUserProperty` with ArraySegment<byte> or ReadOnlyMemory<byte> for the value.")]
+    public MqttServerClientDisconnectOptionsBuilder WithUserProperty(string name, string value)
+    {
+        if (_options.UserProperties == null)
         {
-            return _options;
+            _options.UserProperties = new List<MqttUserProperty>();
         }
 
-        public MqttServerClientDisconnectOptionsBuilder WithReasonCode(MqttDisconnectReasonCode value)
+        _options.UserProperties.Add(new MqttUserProperty(name, value));
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithUserProperty(string name, ReadOnlyMemory<byte> value)
+    {
+        if (_options.UserProperties == null)
         {
-            _options.ReasonCode = value;
-            return this;
+            _options.UserProperties = new List<MqttUserProperty>();
         }
 
-        public MqttServerClientDisconnectOptionsBuilder WithReasonString(string value)
+        _options.UserProperties.Add(new MqttUserProperty(name, value));
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithUserProperty(string name, ArraySegment<byte> value)
+    {
+        if (_options.UserProperties == null)
         {
-            _options.ReasonString = value;
-            return this;
+            _options.UserProperties = new List<MqttUserProperty>();
         }
 
-        public MqttServerClientDisconnectOptionsBuilder WithServerReference(string value)
-        {
-            _options.ServerReference = value;
-            return this;
-        }
-
-        public MqttServerClientDisconnectOptionsBuilder WithUserProperties(List<MqttUserProperty> value)
-        {
-            _options.UserProperties = value;
-            return this;
-        }
-
-        public MqttServerClientDisconnectOptionsBuilder WithUserProperty(string name, string value)
-        {
-            if (_options.UserProperties == null)
-            {
-                _options.UserProperties = new List<MqttUserProperty>();
-            }
-
-            _options.UserProperties.Add(new MqttUserProperty(name, value));
-            return this;
-        }
+        _options.UserProperties.Add(new MqttUserProperty(name, value));
+        return this;
     }
 }

Source/MQTTnet.Server/EnhancedAuthentication/ExchangeEnhancedAuthenticationOptionsFactory.cs

@@ -51,13 +51,39 @@ public sealed class ExchangeEnhancedAuthenticationOptionsFactory
         return this;
     }
 
+    [Obsolete("Please use more performance `WithUserProperty` with ArraySegment<byte> or ReadOnlyMemory<byte> for the value.")]
     public ExchangeEnhancedAuthenticationOptionsFactory WithUserProperty(string name, string value)
     {
-        if (name == null)
+        ArgumentNullException.ThrowIfNull(name);
+
+        if (_options.UserProperties == null)
         {
-            throw new ArgumentNullException(nameof(name));
+            _options.UserProperties = new List<MqttUserProperty>();
         }
 
+        _options.UserProperties.Add(new MqttUserProperty(name, value));
+
+        return this;
+    }
+
+    public ExchangeEnhancedAuthenticationOptionsFactory WithUserProperty(string name, ReadOnlyMemory<byte> value)
+    {
+        ArgumentNullException.ThrowIfNull(name);
+
+        if (_options.UserProperties == null)
+        {
+            _options.UserProperties = new List<MqttUserProperty>();
+        }
+
+        _options.UserProperties.Add(new MqttUserProperty(name, value));
+
+        return this;
+    }
+
+    public ExchangeEnhancedAuthenticationOptionsFactory WithUserProperty(string name, ArraySegment<byte> value)
+    {
+        ArgumentNullException.ThrowIfNull(name);
+
         if (_options.UserProperties == null)
         {
             _options.UserProperties = new List<MqttUserProperty>();

Source/MQTTnet.Server/Events/ApplicationMessageEnqueuedEventArgs.cs

@@ -2,26 +2,23 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
+namespace MQTTnet.Server;
 
-namespace MQTTnet.Server
+public sealed class ApplicationMessageEnqueuedEventArgs : EventArgs
 {
-    public sealed class ApplicationMessageEnqueuedEventArgs : EventArgs
+    public ApplicationMessageEnqueuedEventArgs(string senderClientId, string receiverClientId, MqttApplicationMessage applicationMessage, bool isDropped)
     {
-        public ApplicationMessageEnqueuedEventArgs(string senderClientId, string receiverClientId, MqttApplicationMessage applicationMessage, bool isDropped)
-        {
-            SenderClientId = senderClientId ?? throw new ArgumentNullException( nameof(senderClientId));
-            ReceiverClientId = receiverClientId ?? throw new ArgumentNullException(nameof(receiverClientId));
-            ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
-            IsDropped = isDropped;
-        }
-
-        public string SenderClientId { get; }
-
-        public string ReceiverClientId { get; }
-
-        public bool IsDropped { get; }
-
-        public MqttApplicationMessage ApplicationMessage { get; }
+        SenderClientId = senderClientId ?? throw new ArgumentNullException( nameof(senderClientId));
+        ReceiverClientId = receiverClientId ?? throw new ArgumentNullException(nameof(receiverClientId));
+        ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
+        IsDropped = isDropped;
     }
+
+    public string SenderClientId { get; }
+
+    public string ReceiverClientId { get; }
+
+    public bool IsDropped { get; }
+
+    public MqttApplicationMessage ApplicationMessage { get; }
 }

Source/MQTTnet.Server/Events/ApplicationMessageNotConsumedEventArgs.cs

@@ -2,26 +2,23 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
+namespace MQTTnet.Server;
 
-namespace MQTTnet.Server
+public sealed class ApplicationMessageNotConsumedEventArgs : EventArgs
 {
-    public sealed class ApplicationMessageNotConsumedEventArgs : EventArgs
+    public ApplicationMessageNotConsumedEventArgs(MqttApplicationMessage applicationMessage, string senderId)
     {
-        public ApplicationMessageNotConsumedEventArgs(MqttApplicationMessage applicationMessage, string senderId)
-        {
-            ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
-            SenderId = senderId;
-        }
-
-        /// <summary>
-        ///     Gets the application message which was not consumed by any client.
-        /// </summary>
-        public MqttApplicationMessage ApplicationMessage { get; }
-
-        /// <summary>
-        ///     Gets the ID of the client which has sent the affected application message.
-        /// </summary>
-        public string SenderId { get; }
+        ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
+        SenderId = senderId;
     }
+
+    /// <summary>
+    ///     Gets the application message which was not consumed by any client.
+    /// </summary>
+    public MqttApplicationMessage ApplicationMessage { get; }
+
+    /// <summary>
+    ///     Gets the ID of the client which has sent the affected application message.
+    /// </summary>
+    public string SenderId { get; }
 }

Source/MQTTnet.Server/Events/ClientAcknowledgedPublishPacketEventArgs.cs

@@ -2,51 +2,49 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class ClientAcknowledgedPublishPacketEventArgs : EventArgs
 {
-    public sealed class ClientAcknowledgedPublishPacketEventArgs : EventArgs
+    public ClientAcknowledgedPublishPacketEventArgs(string clientId, string userName, IDictionary sessionItems, MqttPublishPacket publishPacket, MqttPacketWithIdentifier acknowledgePacket)
     {
-        public ClientAcknowledgedPublishPacketEventArgs(string clientId, string userName, IDictionary sessionItems, MqttPublishPacket publishPacket, MqttPacketWithIdentifier acknowledgePacket)
-        {
-            ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
-            UserName = userName;
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-            PublishPacket = publishPacket ?? throw new ArgumentNullException(nameof(publishPacket));
-            AcknowledgePacket = acknowledgePacket ?? throw new ArgumentNullException(nameof(acknowledgePacket));
-        }
-        
-        /// <summary>
-        ///     Gets the packet which was used for acknowledge. This can be a PubAck or PubComp packet.
-        /// </summary>
-        public MqttPacketWithIdentifier AcknowledgePacket { get; }
-
-        /// <summary>
-        ///     Gets the ID of the client which acknowledged a PUBLISH packet.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; }
-
-        /// <summary>
-        ///     Gets whether the PUBLISH packet is fully acknowledged. This is the case for PUBACK (QoS 1) and PUBCOMP (QoS 2.
-        /// </summary>
-        public bool IsCompleted => AcknowledgePacket is MqttPubAckPacket || AcknowledgePacket is MqttPubCompPacket;
-
-        /// <summary>
-        ///     Gets the PUBLISH packet which was acknowledged.
-        /// </summary>
-        public MqttPublishPacket PublishPacket { get; }
-
-        /// <summary>
-        ///     Gets the session items which contain custom user data per session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
+        ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
+        UserName = userName;
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
+        PublishPacket = publishPacket ?? throw new ArgumentNullException(nameof(publishPacket));
+        AcknowledgePacket = acknowledgePacket ?? throw new ArgumentNullException(nameof(acknowledgePacket));
     }
+
+    /// <summary>
+    ///     Gets the packet which was used for acknowledge. This can be a PubAck or PubComp packet.
+    /// </summary>
+    public MqttPacketWithIdentifier AcknowledgePacket { get; }
+
+    /// <summary>
+    ///     Gets the ID of the client which acknowledged a PUBLISH packet.
+    /// </summary>
+    public string ClientId { get; }
+
+    /// <summary>
+    /// Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets whether the PUBLISH packet is fully acknowledged. This is the case for PUBACK (QoS 1) and PUBCOMP (QoS 2.
+    /// </summary>
+    public bool IsCompleted => AcknowledgePacket is MqttPubAckPacket || AcknowledgePacket is MqttPubCompPacket;
+
+    /// <summary>
+    ///     Gets the PUBLISH packet which was acknowledged.
+    /// </summary>
+    public MqttPublishPacket PublishPacket { get; }
+
+    /// <summary>
+    ///     Gets the session items which contain custom user data per session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
 }

Source/MQTTnet.Server/Events/ClientConnectedEventArgs.cs

@@ -2,70 +2,67 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
-using System.Collections.Generic;
 using System.Net;
 using System.Text;
 using MQTTnet.Formatter;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class ClientConnectedEventArgs : EventArgs
 {
-    public sealed class ClientConnectedEventArgs : EventArgs
+    readonly MqttConnectPacket _connectPacket;
+
+    public ClientConnectedEventArgs(MqttConnectPacket connectPacket, MqttProtocolVersion protocolVersion, EndPoint remoteEndPoint, IDictionary sessionItems)
     {
-        readonly MqttConnectPacket _connectPacket;
-
-        public ClientConnectedEventArgs(MqttConnectPacket connectPacket, MqttProtocolVersion protocolVersion, EndPoint remoteEndPoint, IDictionary sessionItems)
-        {
-            _connectPacket = connectPacket ?? throw new ArgumentNullException(nameof(connectPacket));
-            ProtocolVersion = protocolVersion;
-            RemoteEndPoint = remoteEndPoint;
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-        }
-
-        public byte[] AuthenticationData => _connectPacket.AuthenticationData;
-
-        public string AuthenticationMethod => _connectPacket.AuthenticationMethod;
-
-        /// <summary>
-        ///     Gets the client identifier of the connected client.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId => _connectPacket.ClientId;
-
-        /// <summary>
-        ///     Gets the endpoint of the connected client.
-        /// </summary>
-        public EndPoint RemoteEndPoint { get; }
-
-        [Obsolete("Use RemoteEndPoint instead.")]
-        public string Endpoint => RemoteEndPoint?.ToString();
-
-        /// <summary>
-        ///     Gets the protocol version which is used by the connected client.
-        /// </summary>
-        public MqttProtocolVersion ProtocolVersion { get; }
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
-
-        /// <summary>
-        ///     Gets the user name of the connected client.
-        /// </summary>
-        public string UserName => _connectPacket.Username;
-
-        /// <summary>
-        ///     Gets the password of the connected client.
-        /// </summary>
-        public string Password => Encoding.UTF8.GetString(_connectPacket.Password.AsSpan());
-
-        /// <summary>
-        ///     Gets the user properties sent by the client.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public List<MqttUserProperty> UserProperties => _connectPacket?.UserProperties;
+        _connectPacket = connectPacket ?? throw new ArgumentNullException(nameof(connectPacket));
+        ProtocolVersion = protocolVersion;
+        RemoteEndPoint = remoteEndPoint;
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
     }
+
+    public byte[] AuthenticationData => _connectPacket.AuthenticationData;
+
+    public string AuthenticationMethod => _connectPacket.AuthenticationMethod;
+
+    /// <summary>
+    ///     Gets the client identifier of the connected client.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId => _connectPacket.ClientId;
+
+    /// <summary>
+    ///     Gets the endpoint of the connected client.
+    /// </summary>
+    public EndPoint RemoteEndPoint { get; }
+
+    [Obsolete("Use RemoteEndPoint instead.")]
+    public string Endpoint => RemoteEndPoint?.ToString();
+
+    /// <summary>
+    ///     Gets the protocol version which is used by the connected client.
+    /// </summary>
+    public MqttProtocolVersion ProtocolVersion { get; }
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
+
+    /// <summary>
+    ///     Gets the user name of the connected client.
+    /// </summary>
+    public string UserName => _connectPacket.Username;
+
+    /// <summary>
+    ///     Gets the password of the connected client.
+    /// </summary>
+    public string Password => Encoding.UTF8.GetString(_connectPacket.Password.AsSpan());
+
+    /// <summary>
+    ///     Gets the user properties sent by the client.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public List<MqttUserProperty> UserProperties => _connectPacket?.UserProperties;
 }

Source/MQTTnet.Server/Events/ClientDisconnectedEventArgs.cs

@@ -2,91 +2,88 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
-using System.Collections.Generic;
 using System.Net;
 using System.Text;
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class ClientDisconnectedEventArgs : EventArgs
 {
-    public sealed class ClientDisconnectedEventArgs : EventArgs
+    readonly MqttConnectPacket _connectPacket;
+    readonly MqttDisconnectPacket _disconnectPacket;
+
+    public ClientDisconnectedEventArgs(
+        MqttConnectPacket connectPacket,
+        MqttDisconnectPacket disconnectPacket,
+        MqttClientDisconnectType disconnectType,
+        EndPoint remoteEndPoint,
+        IDictionary sessionItems)
     {
-        readonly MqttConnectPacket _connectPacket;
-        readonly MqttDisconnectPacket _disconnectPacket;
+        DisconnectType = disconnectType;
+        RemoteEndPoint = remoteEndPoint;
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
 
-        public ClientDisconnectedEventArgs(
-            MqttConnectPacket connectPacket,
-            MqttDisconnectPacket disconnectPacket,
-            MqttClientDisconnectType disconnectType,
-            EndPoint remoteEndPoint,
-            IDictionary sessionItems)
-        {
-            DisconnectType = disconnectType;
-            RemoteEndPoint = remoteEndPoint;
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-
-            _connectPacket = connectPacket;
-            // The DISCONNECT packet can be null in case of a non clean disconnect or session takeover.
-            _disconnectPacket = disconnectPacket;
-        }
-
-        /// <summary>
-        ///     Gets the client identifier.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId => _connectPacket.ClientId;
-
-        /// <summary>
-        ///     Gets the user name of the client.
-        /// </summary>
-        public string UserName => _connectPacket.Username;
-
-        /// <summary>
-        ///     Gets the password of the client.
-        /// </summary>
-        public string Password => Encoding.UTF8.GetString(_connectPacket.Password.AsSpan());
-
-        public MqttClientDisconnectType DisconnectType { get; }
-
-        public EndPoint RemoteEndPoint { get; }
-
-        [Obsolete("Use RemoteEndPoint instead.")]
-        public string Endpoint => RemoteEndPoint?.ToString();
-
-        /// <summary>
-        ///     Gets the reason code sent by the client.
-        ///     Only available for clean disconnects.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public MqttDisconnectReasonCode? ReasonCode => _disconnectPacket?.ReasonCode;
-
-        /// <summary>
-        ///     Gets the reason string sent by the client.
-        ///     Only available for clean disconnects.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public string ReasonString => _disconnectPacket?.ReasonString;
-
-        /// <summary>
-        ///     Gets the session expiry interval sent by the client.
-        ///     Only available for clean disconnects.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public uint SessionExpiryInterval => _disconnectPacket?.SessionExpiryInterval ?? 0;
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
-
-        /// <summary>
-        ///     Gets the user properties sent by the client.
-        ///     Only available for clean disconnects.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public List<MqttUserProperty> UserProperties => _disconnectPacket?.UserProperties;
+        _connectPacket = connectPacket;
+        // The DISCONNECT packet can be null in case of a non clean disconnect or session takeover.
+        _disconnectPacket = disconnectPacket;
     }
+
+    /// <summary>
+    ///     Gets the client identifier.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId => _connectPacket.ClientId;
+
+    /// <summary>
+    ///     Gets the user name of the client.
+    /// </summary>
+    public string UserName => _connectPacket.Username;
+
+    /// <summary>
+    ///     Gets the password of the client.
+    /// </summary>
+    public string Password => Encoding.UTF8.GetString(_connectPacket.Password.AsSpan());
+
+    public MqttClientDisconnectType DisconnectType { get; }
+
+    public EndPoint RemoteEndPoint { get; }
+
+    [Obsolete("Use RemoteEndPoint instead.")]
+    public string Endpoint => RemoteEndPoint?.ToString();
+
+    /// <summary>
+    ///     Gets the reason code sent by the client.
+    ///     Only available for clean disconnects.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public MqttDisconnectReasonCode? ReasonCode => _disconnectPacket?.ReasonCode;
+
+    /// <summary>
+    ///     Gets the reason string sent by the client.
+    ///     Only available for clean disconnects.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public string ReasonString => _disconnectPacket?.ReasonString;
+
+    /// <summary>
+    ///     Gets the session expiry interval sent by the client.
+    ///     Only available for clean disconnects.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public uint SessionExpiryInterval => _disconnectPacket?.SessionExpiryInterval ?? 0;
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
+
+    /// <summary>
+    ///     Gets the user properties sent by the client.
+    ///     Only available for clean disconnects.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public List<MqttUserProperty> UserProperties => _disconnectPacket?.UserProperties;
 }

Source/MQTTnet.Server/Events/ClientSubscribedTopicEventArgs.cs

@@ -2,42 +2,40 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class ClientSubscribedTopicEventArgs : EventArgs
 {
-    public sealed class ClientSubscribedTopicEventArgs : EventArgs
+    public ClientSubscribedTopicEventArgs(string clientId, string userName, MqttTopicFilter topicFilter, IDictionary sessionItems)
     {
-        public ClientSubscribedTopicEventArgs(string clientId, string userName, MqttTopicFilter topicFilter, IDictionary sessionItems)
-        {
-            ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
-            UserName = userName;
-            TopicFilter = topicFilter ?? throw new ArgumentNullException(nameof(topicFilter));
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-        }
-
-        /// <summary>
-        ///     Gets the client identifier.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; }
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
-
-        /// <summary>
-        ///     Gets the topic filter.
-        ///     The topic filter can contain topics and wildcards.
-        /// </summary>
-        public MqttTopicFilter TopicFilter { get; }
+        ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
+        UserName = userName;
+        TopicFilter = topicFilter ?? throw new ArgumentNullException(nameof(topicFilter));
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
     }
+
+    /// <summary>
+    ///     Gets the client identifier.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId { get; }
+
+    /// <summary>
+    /// Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
+
+    /// <summary>
+    ///     Gets the topic filter.
+    ///     The topic filter can contain topics and wildcards.
+    /// </summary>
+    public MqttTopicFilter TopicFilter { get; }
 }

Source/MQTTnet.Server/Events/ClientUnsubscribedTopicEventArgs.cs

@@ -2,41 +2,39 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class ClientUnsubscribedTopicEventArgs : EventArgs
 {
-    public sealed class ClientUnsubscribedTopicEventArgs : EventArgs
+    public ClientUnsubscribedTopicEventArgs(string clientId, string userName, string topicFilter, IDictionary sessionItems)
     {
-        public ClientUnsubscribedTopicEventArgs(string clientId, string userName, string topicFilter, IDictionary sessionItems)
-        {
-            ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
-            UserName = userName;
-            TopicFilter = topicFilter ?? throw new ArgumentNullException(nameof(topicFilter));
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-        }
-
-        /// <summary>
-        ///     Gets the client identifier.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; }
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
-
-        /// <summary>
-        ///     Gets or sets the topic filter.
-        ///     The topic filter can contain topics and wildcards.
-        /// </summary>
-        public string TopicFilter { get; }
+        ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
+        UserName = userName;
+        TopicFilter = topicFilter ?? throw new ArgumentNullException(nameof(topicFilter));
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
     }
+
+    /// <summary>
+    ///     Gets the client identifier.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId { get; }
+
+    /// <summary>
+    /// Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
+
+    /// <summary>
+    ///     Gets or sets the topic filter.
+    ///     The topic filter can contain topics and wildcards.
+    /// </summary>
+    public string TopicFilter { get; }
 }

Source/MQTTnet.Server/Events/InterceptingClientApplicationMessageEnqueueEventArgs.cs

@@ -2,34 +2,31 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
+namespace MQTTnet.Server;
 
-namespace MQTTnet.Server
+public sealed class InterceptingClientApplicationMessageEnqueueEventArgs : EventArgs
 {
-    public sealed class InterceptingClientApplicationMessageEnqueueEventArgs : EventArgs
+    public InterceptingClientApplicationMessageEnqueueEventArgs(string senderClientId, string receiverClientId, MqttApplicationMessage applicationMessage)
     {
-        public InterceptingClientApplicationMessageEnqueueEventArgs(string senderClientId, string receiverClientId, MqttApplicationMessage applicationMessage)
-        {
-            SenderClientId = senderClientId ?? throw new ArgumentNullException(nameof(senderClientId));
-            ReceiverClientId = receiverClientId ?? throw new ArgumentNullException(nameof(receiverClientId));
-            ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
-        }
-
-        /// <summary>
-        ///     Gets or sets whether the enqueue of the application message should be performed or not.
-        ///     If set to _False_ the client will not receive the application message.
-        /// </summary>
-        public bool AcceptEnqueue { get; set; } = true;
-
-        public MqttApplicationMessage ApplicationMessage { get; }
-
-        /// <summary>
-        ///     Indicates if the connection with the sender should be closed.
-        /// </summary>
-        public bool CloseSenderConnection { get; set; }
-
-        public string ReceiverClientId { get; }
-
-        public string SenderClientId { get; }
+        SenderClientId = senderClientId ?? throw new ArgumentNullException(nameof(senderClientId));
+        ReceiverClientId = receiverClientId ?? throw new ArgumentNullException(nameof(receiverClientId));
+        ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
     }
+
+    /// <summary>
+    ///     Gets or sets whether the enqueue of the application message should be performed or not.
+    ///     If set to _False_ the client will not receive the application message.
+    /// </summary>
+    public bool AcceptEnqueue { get; set; } = true;
+
+    public MqttApplicationMessage ApplicationMessage { get; }
+
+    /// <summary>
+    ///     Indicates if the connection with the sender should be closed.
+    /// </summary>
+    public bool CloseSenderConnection { get; set; }
+
+    public string ReceiverClientId { get; }
+
+    public string SenderClientId { get; }
 }

Source/MQTTnet.Server/Events/InterceptingPacketEventArgs.cs

@@ -2,63 +2,60 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
 using System.Net;
-using System.Threading;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class InterceptingPacketEventArgs : EventArgs
 {
-    public sealed class InterceptingPacketEventArgs : EventArgs
+    public InterceptingPacketEventArgs(string clientId, string userName, EndPoint remoteEndPoint, MqttPacket packet, IDictionary sessionItems, CancellationToken cancellationToken)
     {
-        public InterceptingPacketEventArgs(CancellationToken cancellationToken, string clientId, string userName, EndPoint remoteEndPoint, MqttPacket packet, IDictionary sessionItems)
-        {
-            CancellationToken = cancellationToken;
-            ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
-            UserName = userName;
-            RemoteEndPoint = remoteEndPoint;
-            Packet = packet ?? throw new ArgumentNullException(nameof(packet));
-            SessionItems = sessionItems;
-        }
-
-        /// <summary>
-        ///     Gets the cancellation token from the connection managing thread.
-        ///     Use this in further event processing.
-        /// </summary>
-        public CancellationToken CancellationToken { get; }
-
-        /// <summary>
-        ///     Gets the client ID which has sent the packet or will receive the packet.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; }
-
-        /// <summary>
-        ///     Gets the endpoint of the sending or receiving client.
-        /// </summary>
-        public EndPoint RemoteEndPoint { get; }
-
-        [Obsolete("Use RemoteEndPoint instead.")]
-        public string Endpoint => RemoteEndPoint?.ToString();
-
-        /// <summary>
-        ///     Gets or sets the MQTT packet which was received or will be sent.
-        /// </summary>
-        public MqttPacket Packet { get; set; }
-
-        /// <summary>
-        ///     Gets or sets whether the packet should be processed or not.
-        /// </summary>
-        public bool ProcessPacket { get; set; } = true;
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
+        CancellationToken = cancellationToken;
+        ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
+        UserName = userName;
+        RemoteEndPoint = remoteEndPoint;
+        Packet = packet ?? throw new ArgumentNullException(nameof(packet));
+        SessionItems = sessionItems;
     }
+
+    /// <summary>
+    ///     Gets the cancellation token from the connection managing thread.
+    ///     Use this in further event processing.
+    /// </summary>
+    public CancellationToken CancellationToken { get; }
+
+    /// <summary>
+    ///     Gets the client ID which has sent the packet or will receive the packet.
+    /// </summary>
+    public string ClientId { get; }
+
+    /// <summary>
+    /// Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets the endpoint of the sending or receiving client.
+    /// </summary>
+    public EndPoint RemoteEndPoint { get; }
+
+    [Obsolete("Use RemoteEndPoint instead.")]
+    public string Endpoint => RemoteEndPoint?.ToString();
+
+    /// <summary>
+    ///     Gets or sets the MQTT packet which was received or will be sent.
+    /// </summary>
+    public MqttPacket Packet { get; set; }
+
+    /// <summary>
+    ///     Gets or sets whether the packet should be processed or not.
+    /// </summary>
+    public bool ProcessPacket { get; set; } = true;
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
 }

Source/MQTTnet.Server/Events/InterceptingPublishEventArgs.cs

@@ -2,56 +2,53 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
-using System.Threading;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class InterceptingPublishEventArgs : EventArgs
 {
-    public sealed class InterceptingPublishEventArgs : EventArgs
+    public InterceptingPublishEventArgs(MqttApplicationMessage applicationMessage, string clientId, string userName, IDictionary sessionItems, CancellationToken cancellationToken)
     {
-        public InterceptingPublishEventArgs(MqttApplicationMessage applicationMessage, CancellationToken cancellationToken, string clientId, string userName, IDictionary sessionItems)
-        {
-            ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
-            CancellationToken = cancellationToken;
-            ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
-            UserName = userName;
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-        }
-
-        public MqttApplicationMessage ApplicationMessage { get; set; }
-
-        /// <summary>
-        ///     Gets the cancellation token which can indicate that the client connection gets down.
-        /// </summary>
-        public CancellationToken CancellationToken { get; }
-
-        /// <summary>
-        ///     Gets the client identifier.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; }
-
-        public bool CloseConnection { get; set; }
-
-        /// <summary>
-        ///     Gets or sets whether the publish should be processed internally.
-        /// </summary>
-        public bool ProcessPublish { get; set; } = true;
-
-        /// <summary>
-        ///     Gets the response which will be sent to the client via the PUBACK etc. packets.
-        /// </summary>
-        public PublishResponse Response { get; } = new PublishResponse();
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
+        ApplicationMessage = applicationMessage ?? throw new ArgumentNullException(nameof(applicationMessage));
+        CancellationToken = cancellationToken;
+        ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
+        UserName = userName;
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
     }
+
+    public MqttApplicationMessage ApplicationMessage { get; set; }
+
+    /// <summary>
+    ///     Gets the cancellation token which can indicate that the client connection gets down.
+    /// </summary>
+    public CancellationToken CancellationToken { get; }
+
+    /// <summary>
+    ///     Gets the client identifier.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId { get; }
+
+    public bool CloseConnection { get; set; }
+
+    /// <summary>
+    ///     Gets or sets whether the publish should be processed internally.
+    /// </summary>
+    public bool ProcessPublish { get; set; } = true;
+
+    /// <summary>
+    ///     Gets the response which will be sent to the client via the PUBACK etc. packets.
+    /// </summary>
+    public PublishResponse Response { get; } = new();
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
+
+    /// <summary>
+    ///     Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
 }

Source/MQTTnet.Server/Events/InterceptingSubscriptionEventArgs.cs

@@ -2,90 +2,86 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
-using System.Collections.Generic;
-using System.Threading;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class InterceptingSubscriptionEventArgs : EventArgs
 {
-    public sealed class InterceptingSubscriptionEventArgs : EventArgs
+    public InterceptingSubscriptionEventArgs(
+        string clientId,
+        string userName,
+        MqttSessionStatus session,
+        MqttTopicFilter topicFilter,
+        List<MqttUserProperty> userProperties,
+        CancellationToken cancellationToken)
     {
-        public InterceptingSubscriptionEventArgs(
-            CancellationToken cancellationToken,
-            string clientId,
-            string userName,
-            MqttSessionStatus session,
-            MqttTopicFilter topicFilter,
-            List<MqttUserProperty> userProperties)
-        {
-            CancellationToken = cancellationToken;
-            ClientId = clientId;
-            UserName = userName;
-            Session = session;
-            TopicFilter = topicFilter;
-            UserProperties = userProperties;
-        }
-
-        /// <summary>
-        ///     Gets the cancellation token which can indicate that the client connection gets down.
-        /// </summary>
-        public CancellationToken CancellationToken { get; }
-
-        /// <summary>
-        ///     Gets the client identifier.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; }
-
-        /// <summary>
-        ///     Gets or sets whether the broker should close the client connection.
-        /// </summary>
-        public bool CloseConnection { get; set; }
-
-        /// <summary>
-        ///     Gets or sets whether the broker should create an internal subscription for the client.
-        ///     The broker can also avoid this and return "success" to the client.
-        ///     This feature allows using the MQTT Broker as the Frontend and another system as the backend.
-        /// </summary>
-        public bool ProcessSubscription { get; set; } = true;
-
-        /// <summary>
-        ///     Gets or sets the reason string which will be sent to the client in the SUBACK packet.
-        /// </summary>
-        public string ReasonString { get; set; }
-
-        /// <summary>
-        ///     Gets the response which will be sent to the client via the SUBACK packet.
-        /// </summary>
-        public SubscribeResponse Response { get; } = new SubscribeResponse();
-
-        /// <summary>
-        ///     Gets the current client session.
-        /// </summary>
-        public MqttSessionStatus Session { get; }
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems => Session.Items;
-
-        /// <summary>
-        ///     Gets or sets the topic filter.
-        ///     The topic filter can contain topics and wildcards.
-        /// </summary>
-        public MqttTopicFilter TopicFilter { get; set; }
-
-        /// <summary>
-        ///     Gets or sets the user properties.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public List<MqttUserProperty> UserProperties { get; set; }
+        CancellationToken = cancellationToken;
+        ClientId = clientId;
+        UserName = userName;
+        Session = session;
+        TopicFilter = topicFilter;
+        UserProperties = userProperties;
     }
+
+    /// <summary>
+    ///     Gets the cancellation token which can indicate that the client connection gets down.
+    /// </summary>
+    public CancellationToken CancellationToken { get; }
+
+    /// <summary>
+    ///     Gets the client identifier.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId { get; }
+
+    /// <summary>
+    ///     Gets or sets whether the broker should close the client connection.
+    /// </summary>
+    public bool CloseConnection { get; set; }
+
+    /// <summary>
+    ///     Gets or sets whether the broker should create an internal subscription for the client.
+    ///     The broker can also avoid this and return "success" to the client.
+    ///     This feature allows using the MQTT Broker as the Frontend and another system as the backend.
+    /// </summary>
+    public bool ProcessSubscription { get; set; } = true;
+
+    /// <summary>
+    ///     Gets or sets the reason string which will be sent to the client in the SUBACK packet.
+    /// </summary>
+    public string ReasonString { get; set; }
+
+    /// <summary>
+    ///     Gets the response which will be sent to the client via the SUBACK packet.
+    /// </summary>
+    public SubscribeResponse Response { get; } = new();
+
+    /// <summary>
+    ///     Gets the current client session.
+    /// </summary>
+    public MqttSessionStatus Session { get; }
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems => Session.Items;
+
+    /// <summary>
+    ///     Gets or sets the topic filter.
+    ///     The topic filter can contain topics and wildcards.
+    /// </summary>
+    public MqttTopicFilter TopicFilter { get; set; }
+
+    /// <summary>
+    ///     Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets or sets the user properties.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public List<MqttUserProperty> UserProperties { get; set; }
 }

Source/MQTTnet.Server/Events/InterceptingUnsubscriptionEventArgs.cs

@@ -2,77 +2,73 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
-using System.Collections.Generic;
-using System.Threading;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class InterceptingUnsubscriptionEventArgs : EventArgs
 {
-    public sealed class InterceptingUnsubscriptionEventArgs : EventArgs
+    public InterceptingUnsubscriptionEventArgs(string clientId, string userName, IDictionary sessionItems, string topic, List<MqttUserProperty> userProperties, CancellationToken cancellationToken)
     {
-        public InterceptingUnsubscriptionEventArgs(CancellationToken cancellationToken, string clientId, string userName, IDictionary sessionItems, string topic, List<MqttUserProperty> userProperties)
-        {
-            CancellationToken = cancellationToken;
-            ClientId = clientId;
-            UserName = userName;
-            SessionItems = sessionItems;
-            Topic = topic;
-            UserProperties = userProperties;
-        }
-
-        /// <summary>
-        ///     Gets the cancellation token which can indicate that the client connection gets down.
-        /// </summary>
-        public CancellationToken CancellationToken { get; }
-
-        /// <summary>
-        ///     Gets the client identifier.
-        ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
-        /// </summary>
-        public string ClientId { get; }
-
-        /// <summary>
-        /// Gets the user name of the client.
-        /// </summary>
-        public string UserName { get; } 
-
-        /// <summary>
-        ///     Gets or sets whether the broker should close the client connection.
-        /// </summary>
-        public bool CloseConnection { get; set; }
-
-        /// <summary>
-        ///     Gets or sets whether the broker should remove an internal subscription for the client.
-        ///     The broker can also avoid this and return "success" to the client.
-        ///     This feature allows using the MQTT Broker as the Frontend and another system as the backend.
-        /// </summary>
-        public bool ProcessUnsubscription { get; set; } = true;
-
-        /// <summary>
-        ///     Gets the response which will be sent to the client via the UNSUBACK pocket.
-        /// </summary>
-        public UnsubscribeResponse Response { get; } = new UnsubscribeResponse();
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
-
-        /// <summary>
-        ///     Gets or sets the MQTT topic.
-        ///     In MQTT, the word topic refers to an UTF-8 string that the broker uses to filter messages for each connected
-        ///     client.
-        ///     The topic consists of one or more topic levels. Each topic level is separated by a forward slash (topic level
-        ///     separator).
-        /// </summary>
-        public string Topic { get; }
-
-        /// <summary>
-        ///     Gets or sets the user properties.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public List<MqttUserProperty> UserProperties { get; set; }
+        CancellationToken = cancellationToken;
+        ClientId = clientId;
+        UserName = userName;
+        SessionItems = sessionItems;
+        Topic = topic;
+        UserProperties = userProperties;
     }
+
+    /// <summary>
+    ///     Gets the cancellation token which can indicate that the client connection gets down.
+    /// </summary>
+    public CancellationToken CancellationToken { get; }
+
+    /// <summary>
+    ///     Gets the client identifier.
+    ///     Hint: This identifier needs to be unique over all used clients / devices on the broker to avoid connection issues.
+    /// </summary>
+    public string ClientId { get; }
+
+    /// <summary>
+    /// Gets the user name of the client.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets or sets whether the broker should close the client connection.
+    /// </summary>
+    public bool CloseConnection { get; set; }
+
+    /// <summary>
+    ///     Gets or sets whether the broker should remove an internal subscription for the client.
+    ///     The broker can also avoid this and return "success" to the client.
+    ///     This feature allows using the MQTT Broker as the Frontend and another system as the backend.
+    /// </summary>
+    public bool ProcessUnsubscription { get; set; } = true;
+
+    /// <summary>
+    ///     Gets the response which will be sent to the client via the UNSUBACK pocket.
+    /// </summary>
+    public UnsubscribeResponse Response { get; } = new UnsubscribeResponse();
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
+
+    /// <summary>
+    ///     Gets or sets the MQTT topic.
+    ///     In MQTT, the word topic refers to an UTF-8 string that the broker uses to filter messages for each connected
+    ///     client.
+    ///     The topic consists of one or more topic levels. Each topic level is separated by a forward slash (topic level
+    ///     separator).
+    /// </summary>
+    public string Topic { get; }
+
+    /// <summary>
+    ///     Gets or sets the user properties.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public List<MqttUserProperty> UserProperties { get; set; }
 }

Source/MQTTnet.Server/Events/LoadingRetainedMessagesEventArgs.cs

@@ -2,13 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
+namespace MQTTnet.Server;
 
-namespace MQTTnet.Server
+public sealed class LoadingRetainedMessagesEventArgs : EventArgs
 {
-    public sealed class LoadingRetainedMessagesEventArgs : EventArgs
-    {
-        public List<MqttApplicationMessage> LoadedRetainedMessages { get; set; } = new List<MqttApplicationMessage>();
-    }
+    public List<MqttApplicationMessage> LoadedRetainedMessages { get; set; } = new List<MqttApplicationMessage>();
 }

Source/MQTTnet.Server/Events/PreparingSessionEventArgs.cs

@@ -2,50 +2,47 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
 using MQTTnet.Packets;
 using MQTTnet.Server.Internal;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class PreparingSessionEventArgs : EventArgs
 {
-    public sealed class PreparingSessionEventArgs : EventArgs
-    {
-        public string Id { get; set; }
+    public string Id { get; set; }
 
-        // TODO: Allow adding of packets to the queue etc.
+    // TODO: Allow adding of packets to the queue etc.
 
-        /*
-         * The Session State in the Server consists of:
+    /*
+     * The Session State in the Server consists of:
 ·         The existence of a Session, even if the rest of the Session State is empty.
 ·         The Clients subscriptions, including any Subscription Identifiers.
 ·         QoS 1 and QoS 2 messages which have been sent to the Client, but have not been completely acknowledged.
 ·         QoS 1 and QoS 2 messages pending transmission to the Client and OPTIONALLY QoS 0 messages pending transmission to the Client.
 ·         QoS 2 messages which have been received from the Client, but have not been completely acknowledged.The Will Message and the Will Delay Interval
 ·         If the Session is currently not connected, the time at which the Session will end and Session State will be discarded.
-         */
+     */
 
-        public bool IsExistingSession { get; set; }
+    public bool IsExistingSession { get; set; }
 
-        public IDictionary<object, object> Items { get; set; }
+    public IDictionary<object, object> Items { get; set; }
 
-        public List<MqttPublishPacket> PublishPackets { get; } = new List<MqttPublishPacket>();
+    public List<MqttPublishPacket> PublishPackets { get; } = new List<MqttPublishPacket>();
 
-        DateTime? SessionExpiryTimestamp { get; set; }
+    DateTime? SessionExpiryTimestamp { get; set; }
 
-        public List<MqttSubscription> Subscriptions { get; } = new List<MqttSubscription>();
+    public List<MqttSubscription> Subscriptions { get; } = new List<MqttSubscription>();
 
-        /// <summary>
-        ///     Gets the will delay interval.
-        ///     This is the time between the client disconnect and the time the will message will be sent.
-        /// </summary>
-        public uint? WillDelayInterval { get; set; }
+    /// <summary>
+    ///     Gets the will delay interval.
+    ///     This is the time between the client disconnect and the time the will message will be sent.
+    /// </summary>
+    public uint? WillDelayInterval { get; set; }
 
-        // <summary>
-        //     Gets the last will message.
-        //     In MQTT, you use the last will message feature to notify other clients about an ungracefully disconnected client.
-        // </summary>
-        // TODO: Use single properties. No entire will message.
-        //MqttApplicationMessage WillMessage { get; set; }
-    }
+    // <summary>
+    //     Gets the last will message.
+    //     In MQTT, you use the last will message feature to notify other clients about an ungracefully disconnected client.
+    // </summary>
+    // TODO: Use single properties. No entire will message.
+    //MqttApplicationMessage WillMessage { get; set; }
 }

Source/MQTTnet.Server/Events/QueueMessageOverwrittenEventArgs.cs

@@ -2,21 +2,19 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using MQTTnet.Packets;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class QueueMessageOverwrittenEventArgs : EventArgs
 {
-    public sealed class QueueMessageOverwrittenEventArgs : EventArgs
+    public QueueMessageOverwrittenEventArgs(string receiverClientId, MqttPacket packet)
     {
-        public QueueMessageOverwrittenEventArgs(string receiverClientId, MqttPacket packet)
-        {
-            ReceiverClientId = receiverClientId ?? throw new ArgumentNullException(nameof(receiverClientId));
-            Packet = packet ?? throw new ArgumentNullException(nameof(packet));
-        }
-
-        public MqttPacket Packet { get; }
-
-        public string ReceiverClientId { get; }
+        ReceiverClientId = receiverClientId ?? throw new ArgumentNullException(nameof(receiverClientId));
+        Packet = packet ?? throw new ArgumentNullException(nameof(packet));
     }
+
+    public MqttPacket Packet { get; }
+
+    public string ReceiverClientId { get; }
 }

Source/MQTTnet.Server/Events/RetainedMessageChangedEventArgs.cs

@@ -2,24 +2,20 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
+namespace MQTTnet.Server;
 
-namespace MQTTnet.Server
+public sealed class RetainedMessageChangedEventArgs : EventArgs
 {
-    public sealed class RetainedMessageChangedEventArgs : EventArgs
+    public RetainedMessageChangedEventArgs(string clientId, MqttApplicationMessage changedRetainedMessage, List<MqttApplicationMessage> storedRetainedMessages)
     {
-        public RetainedMessageChangedEventArgs(string clientId, MqttApplicationMessage changedRetainedMessage, List<MqttApplicationMessage> storedRetainedMessages)
-        {
-            ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
-            ChangedRetainedMessage = changedRetainedMessage ?? throw new ArgumentNullException(nameof(changedRetainedMessage));
-            StoredRetainedMessages = storedRetainedMessages ?? throw new ArgumentNullException(nameof(storedRetainedMessages));
-        }
-
-        public MqttApplicationMessage ChangedRetainedMessage { get; }
-
-        public string ClientId { get; }
-
-        public List<MqttApplicationMessage> StoredRetainedMessages { get; }
+        ClientId = clientId ?? throw new ArgumentNullException(nameof(clientId));
+        ChangedRetainedMessage = changedRetainedMessage ?? throw new ArgumentNullException(nameof(changedRetainedMessage));
+        StoredRetainedMessages = storedRetainedMessages ?? throw new ArgumentNullException(nameof(storedRetainedMessages));
     }
+
+    public MqttApplicationMessage ChangedRetainedMessage { get; }
+
+    public string ClientId { get; }
+
+    public List<MqttApplicationMessage> StoredRetainedMessages { get; }
 }

Source/MQTTnet.Server/Events/SessionDeletedEventArgs.cs

@@ -2,33 +2,31 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class SessionDeletedEventArgs : EventArgs
 {
-    public sealed class SessionDeletedEventArgs : EventArgs
+    public SessionDeletedEventArgs(string id, string userName, IDictionary sessionItems)
     {
-        public SessionDeletedEventArgs(string id, string userName, IDictionary sessionItems)
-        {
-            Id = id ?? throw new ArgumentNullException(nameof(id));
-            UserName = userName;
-            SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
-        }
-
-        /// <summary>
-        ///     Gets the ID of the session.
-        /// </summary>
-        public string Id { get; }
-
-        /// <summary>
-        /// Gets the user name of the session.
-        /// </summary>
-        public string UserName { get; }
-
-        /// <summary>
-        ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
-        /// </summary>
-        public IDictionary SessionItems { get; }
+        Id = id ?? throw new ArgumentNullException(nameof(id));
+        UserName = userName;
+        SessionItems = sessionItems ?? throw new ArgumentNullException(nameof(sessionItems));
     }
+
+    /// <summary>
+    ///     Gets the ID of the session.
+    /// </summary>
+    public string Id { get; }
+
+    /// <summary>
+    /// Gets the user name of the session.
+    /// </summary>
+    public string UserName { get; }
+
+    /// <summary>
+    ///     Gets or sets a key/value collection that can be used to share data within the scope of this session.
+    /// </summary>
+    public IDictionary SessionItems { get; }
 }

Source/MQTTnet.Server/Exceptions/MqttPendingMessagesOverflowException.cs

@@ -0,0 +1,19 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+namespace MQTTnet.Server.Exceptions;
+
+public class MqttPendingMessagesOverflowException : Exception
+{
+    public MqttPendingMessagesOverflowException(string sessionId, MqttPendingMessagesOverflowStrategy overflowStrategy) : base(
+        $"Send buffer max pending messages overflow occurred for session '{sessionId}'. Strategy: {overflowStrategy}.")
+    {
+        SessionId = sessionId;
+        OverflowStrategy = overflowStrategy;
+    }
+
+    public MqttPendingMessagesOverflowStrategy OverflowStrategy { get; }
+
+    public string SessionId { get; }
+}