Fix some minor TODOs.

Source/MQTTnet.Server/Mqtt/MqttApplicationMessageInterceptor.cs

@@ -46,21 +46,5 @@ namespace MQTTnet.Server.Mqtt
 
             return Task.CompletedTask;
         }
-
-        // TODO: Create dump(object) method in wrapper (creates JSON and prints it).
-        public class PythonMqttApplicationMessageInterceptorContext
-        {
-            public bool accept_connection;
-
-            public bool accept_publish;
-
-            public string client_id;
-
-            public string topic;
-
-            public int qos;
-
-            public bool retain;
-        }
     }
 }

Source/MQTTnet/Formatter/IMqttDataConverter.cs

@@ -12,6 +12,8 @@ namespace MQTTnet.Formatter
     {
         MqttPublishPacket CreatePublishPacket(MqttApplicationMessage applicationMessage);
 
+        MqttPubAckPacket CreatePubAckPacket(MqttPublishPacket publishPacket);
+
         MqttApplicationMessage CreateApplicationMessage(MqttPublishPacket publishPacket);
 
         MqttClientAuthenticateResult CreateClientConnectResult(MqttConnAckPacket connAckPacket);

Source/MQTTnet/Formatter/MqttPacketWriter.cs

@@ -19,7 +19,6 @@ namespace MQTTnet.Formatter
         public static int InitialBufferSize = 128;
         public static int MaxBufferSize = 4096;
 
-        // TODO: Consider using the ArrayPool here together with FreeBuffer.
         private byte[] _buffer = new byte[InitialBufferSize];
 
         private int _offset;

Source/MQTTnet/Formatter/V3/MqttV310DataConverter.cs

@@ -33,6 +33,15 @@ namespace MQTTnet.Formatter.V3
             };
         }
 
+        public MqttPubAckPacket CreatePubAckPacket(MqttPublishPacket publishPacket)
+        {
+            return new MqttPubAckPacket
+            {
+                PacketIdentifier = publishPacket.PacketIdentifier,
+                ReasonCode = MqttPubAckReasonCode.Success
+            };
+        }
+
         public MqttApplicationMessage CreateApplicationMessage(MqttPublishPacket publishPacket)
         {
             if (publishPacket == null) throw new ArgumentNullException(nameof(publishPacket));

Source/MQTTnet/Formatter/V5/MqttV500DataConverter.cs

@@ -46,6 +46,15 @@ namespace MQTTnet.Formatter.V5
             return packet;
         }
 
+        public MqttPubAckPacket CreatePubAckPacket(MqttPublishPacket publishPacket)
+        {
+            return new MqttPubAckPacket
+            {
+                PacketIdentifier = publishPacket.PacketIdentifier,
+                ReasonCode = MqttPubAckReasonCode.Success
+            };
+        }
+
         public MqttApplicationMessage CreateApplicationMessage(MqttPublishPacket publishPacket)
         {
             return new MqttApplicationMessage
@@ -180,12 +189,10 @@ namespace MQTTnet.Formatter.V5
 
         public MqttClientPublishResult CreatePublishResult(MqttPubAckPacket pubAckPacket)
         {
-            var result = new MqttClientPublishResult();
-
-            if (pubAckPacket?.ReasonCode != null)
+            var result = new MqttClientPublishResult
             {
-                result.ReasonCode = (MqttClientPublishReasonCode)pubAckPacket.ReasonCode;
-            }
+                ReasonCode = (MqttClientPublishReasonCode)pubAckPacket.ReasonCode
+            };
 
             return result;
         }

Source/MQTTnet/Formatter/V5/MqttV500PacketEncoder.cs

@@ -285,7 +285,7 @@ namespace MQTTnet.Formatter.V5
 
             if (!packet.ReasonCode.HasValue)
             {
-                throw new MqttProtocolViolationException("PubAck packet must contain a connect reason.");
+                throw new MqttProtocolViolationException("PubAck packet must contain a reason code.");
             }
 
             packetWriter.Write(packet.PacketIdentifier.Value);

Source/MQTTnet/Server/MqttClientConnection.cs

@@ -330,15 +330,8 @@ namespace MQTTnet.Server
             var applicationMessage = _dataConverter.CreateApplicationMessage(publishPacket);
             _sessionsManager.DispatchApplicationMessage(applicationMessage, this);
 
-            // TODO: Create ACK packet.
-            
-            var response = new MqttPubAckPacket
-            {
-                PacketIdentifier = publishPacket.PacketIdentifier,
-                ReasonCode = MqttPubAckReasonCode.Success
-            };
-
-            return SendAsync(response);
+            var pubAckPacket = _dataConverter.CreatePubAckPacket(publishPacket);
+            return SendAsync(pubAckPacket);
         }
 
         private Task HandleIncomingPublishPacketWithQoS2Async(MqttPublishPacket publishPacket)

Tests/MQTTnet.Benchmarks/SerializerBenchmark.cs

@@ -84,12 +84,12 @@ namespace MQTTnet.Benchmarks
 
             public Task ConnectAsync(CancellationToken cancellationToken)
             {
-                throw new NotImplementedException();
+                throw new NotSupportedException();
             }
 
             public Task DisconnectAsync(CancellationToken cancellationToken)
             {
-                throw new NotImplementedException();
+                throw new NotSupportedException();
             }
 
             public Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
@@ -102,7 +102,7 @@ namespace MQTTnet.Benchmarks
 
             public Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
             {
-                throw new NotImplementedException();
+                throw new NotSupportedException();
             }
 
             public void Dispose()

Tests/MQTTnet.TestApp.UniversalWindows/App.xaml.cs

@@ -15,28 +15,14 @@ namespace MQTTnet.TestApp.UniversalWindows
             Suspending += OnSuspending;
         }
 
-        /// <summary>
-        /// Invoked when the application is launched normally by the end user.  Other entry points
-        /// will be used such as when the application is launched to open a specific file.
-        /// </summary>
-        /// <param name="e">Details about the launch request and process.</param>
         protected override void OnLaunched(LaunchActivatedEventArgs e)
         {
-            // Do not repeat app initialization when the Window already has content,
-            // just ensure that the window is active
             if (!(Window.Current.Content is Frame rootFrame))
             {
-                // Create a Frame to act as the navigation context and navigate to the first page
                 rootFrame = new Frame();
 
                 rootFrame.NavigationFailed += OnNavigationFailed;
 
-                if (e.PreviousExecutionState == ApplicationExecutionState.Terminated)
-                {
-                    //TODO: Load state from previously suspended application
-                }
-
-                // Place the frame in the current Window
                 Window.Current.Content = rootFrame;
             }
 
@@ -44,37 +30,21 @@ namespace MQTTnet.TestApp.UniversalWindows
             {
                 if (rootFrame.Content == null)
                 {
-                    // When the navigation stack isn't restored navigate to the first page,
-                    // configuring the new page by passing required information as a navigation
-                    // parameter
                     rootFrame.Navigate(typeof(MainPage), e.Arguments);
                 }
-                // Ensure the current window is active
+                
                 Window.Current.Activate();
             }
         }
-
-        /// <summary>
-        /// Invoked when Navigation to a certain page fails
-        /// </summary>
-        /// <param name="sender">The Frame which failed navigation</param>
-        /// <param name="e">Details about the navigation failure</param>
+        
         void OnNavigationFailed(object sender, NavigationFailedEventArgs e)
         {
             throw new Exception("Failed to load Page " + e.SourcePageType.FullName);
         }
 
-        /// <summary>
-        /// Invoked when application execution is being suspended.  Application state is saved
-        /// without knowing whether the application will be terminated or resumed with the contents
-        /// of memory still intact.
-        /// </summary>
-        /// <param name="sender">The source of the suspend request.</param>
-        /// <param name="e">Details about the suspend request.</param>
         private void OnSuspending(object sender, SuspendingEventArgs e)
         {
             var deferral = e.SuspendingOperation.GetDeferral();
-            //TODO: Save application state and stop any background activity
             deferral.Complete();
         }
     }