From bd2722f40884ecdab413076c939b49d4141e92a7 Mon Sep 17 00:00:00 2001 From: dijunkun Date: Thu, 16 Nov 2023 01:15:09 -0800 Subject: [PATCH] Disable FEC by default --- src/media/video/encode/openh264/openh264_encoder.h | 4 ++-- src/pc/peer_connection.cpp | 2 +- src/rtp/rtp_codec.h | 2 +- src/rtp/rtp_video_receiver.h | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/media/video/encode/openh264/openh264_encoder.h b/src/media/video/encode/openh264/openh264_encoder.h index bff16d1..05e37ca 100644 --- a/src/media/video/encode/openh264/openh264_encoder.h +++ b/src/media/video/encode/openh264/openh264_encoder.h @@ -38,9 +38,9 @@ class OpenH264Encoder : public VideoEncoder { private: int frame_width_ = 1280; int frame_height_ = 720; - int key_frame_interval_ = 1; + int key_frame_interval_ = 300; int target_bitrate_ = 1000; - int max_bitrate_ = 500000; + int max_bitrate_ = 2500000; int max_payload_size_ = 1400; int max_frame_rate_ = 30; std::vector> encoded_packets_; diff --git a/src/pc/peer_connection.cpp b/src/pc/peer_connection.cpp index 19de2ee..e1fbb66 100644 --- a/src/pc/peer_connection.cpp +++ b/src/pc/peer_connection.cpp @@ -429,7 +429,7 @@ int PeerConnection::SendVideoData(const char *data, size_t size) { int ret = video_encoder_->Encode( (uint8_t *)data, size, [this](char *encoded_frame, size_t size) -> int { for (auto &ice_trans : ice_transmission_list_) { - LOG_ERROR("H264 frame size: [{}]", size); + // LOG_ERROR("H264 frame size: [{}]", size); ice_trans.second->SendData(IceTransmission::DATA_TYPE::VIDEO, encoded_frame, size); } diff --git a/src/rtp/rtp_codec.h b/src/rtp/rtp_codec.h index eb7659c..a21d0ba 100644 --- a/src/rtp/rtp_codec.h +++ b/src/rtp/rtp_codec.h @@ -41,7 +41,7 @@ class RtpCodec { private: // RtpPacket* rtp_packet_ = nullptr; RtpPacket::FU_INDICATOR fu_indicator_; - bool fec_enable_ = true; + bool fec_enable_ = false; FecEncoder fec_encoder_; }; diff --git a/src/rtp/rtp_video_receiver.h b/src/rtp/rtp_video_receiver.h index 02b8702..c6cae4f 100644 --- a/src/rtp/rtp_video_receiver.h +++ b/src/rtp/rtp_video_receiver.h @@ -50,7 +50,7 @@ class RtpVideoReceiver : public ThreadBase { std::function data_send_func_ = nullptr; private: - bool fec_enable_ = true; + bool fec_enable_ = false; FecDecoder fec_decoder_; uint32_t last_packet_ts_ = 0; // std::map incomplete_fec_frame_list_;