YangWX/crossdesk
1
0
Fork 0
mirror of https://github.com/kunkundi/crossdesk.git synced 2025-10-26 20:25:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash during rejoin connection

Browse Source
This commit is contained in:
dijunkun
2023-10-10 17:09:24 +08:00
parent 4efaccd5e4
commit aba06f3289
7 changed files with 58 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/interface/x.h
View File

@@ -27,11 +27,11 @@ typedef struct {
PeerPtr* CreatePeer(const Params* params);
int CreateConnection(PeerPtr* peer_ptr, const char* transmission_id,
const char* user_id);
int Init(PeerPtr* peer_ptr, const char* user_id);
int JoinConnection(PeerPtr* peer_ptr, const char* transmission_id,
const char* user_id);
int CreateConnection(PeerPtr* peer_ptr, const char* transmission_id);
int JoinConnection(PeerPtr* peer_ptr, const char* transmission_id);
int LeaveConnection(PeerPtr* peer_ptr);

33
src/pc/peer_connection.cpp
View File

@@ -19,8 +19,11 @@ PeerConnection::~PeerConnection() {
}
int PeerConnection::Init(PeerConnectionParams params,
const std::string &transmission_id,
const std::string &user_id) {
if (inited_) {
LOG_INFO("Peer already inited");
return 0;
}
// Todo: checkout user_id unique or not
user_id_ = user_id;
@@ -116,6 +119,7 @@ int PeerConnection::Init(PeerConnectionParams params,
return -1;
}
inited_ = true;
return 0;
}
@@ -176,14 +180,11 @@ int PeerConnection::CreateVideoCodec(bool hardware_acceleration) {
}
int PeerConnection::Create(PeerConnectionParams params,
const std::string &transmission_id,
const std::string &user_id) {
const std::string &transmission_id) {
int ret = 0;
// ret = Init(params, transmission_id, user_id);
json message = {{"type", "create_transmission"},
{"user_id", user_id},
{"user_id", user_id_},
{"transmission_id", transmission_id}};
if (ws_transport_) {
ws_transport_->Send(message.dump());
@@ -194,24 +195,23 @@ int PeerConnection::Create(PeerConnectionParams params,
}
int PeerConnection::Join(PeerConnectionParams params,
const std::string &transmission_id,
const std::string &user_id) {
const std::string &transmission_id) {
int ret = 0;
// ret = Init(params, transmission_id, user_id);
transmission_id_ = transmission_id;
ret = RequestTransmissionMemberList(transmission_id_);
return ret;
}
int PeerConnection::Leave() {
for (auto &ice_transmission : ice_transmission_list_) {
ice_transmission.second->DestroyIceTransmission();
json message = {{"type", "leave_transmission"},
{"user_id", user_id_},
{"transmission_id", transmission_id_}};
if (ws_transport_) {
ws_transport_->Send(message.dump());
LOG_INFO("[{}] sends leave transmission [{}] notification ",
transmission_id_);
}
ice_transmission_list_.erase(ice_transmission_list_.begin(),
ice_transmission_list_.end());
return 0;
}
@@ -256,6 +256,9 @@ void PeerConnection::ProcessSignal(const std::string &signal) {
LOG_INFO("]");
for (auto &remote_user_id : user_id_list_) {
if (remote_user_id == user_id_) {
continue;
}
ice_transmission_list_[remote_user_id] =
std::make_unique<IceTransmission>(true, transmission_id, user_id_,
remote_user_id, ws_transport_,

10
src/pc/peer_connection.h
View File

@@ -31,15 +31,12 @@ class PeerConnection {
~PeerConnection();
public:
int Init(PeerConnectionParams params, const std::string &transmission_id,
const std::string &user_id);
int Init(PeerConnectionParams params, const std::string &user_id);
int Create(PeerConnectionParams params,
const std::string &transmission_id = "",
const std::string &user_id = "");
const std::string &transmission_id = "");
int Join(PeerConnectionParams params, const std::string &transmission_id,
const std::string &user_id = "");
int Join(PeerConnectionParams params, const std::string &transmission_id);
int Leave();
@@ -100,6 +97,7 @@ class PeerConnection {
OnReceiveBuffer on_receive_audio_buffer_;
OnReceiveBuffer on_receive_data_buffer_;
char *nv12_data_ = nullptr;
bool inited_ = false;
private:
std::unique_ptr<VideoEncoder> video_encoder_ = nullptr;

26
src/rtc/x_inner.cpp
View File

@@ -24,29 +24,19 @@ PeerPtr *CreatePeer(const Params *params) {
return peer_ptr;
}
// int CreateConnection(PeerPtr *peer_ptr) {
// peer_ptr->peer_connection->Create(peer_ptr->pc_params);
// return 0;
// }
int Init(PeerPtr *peer_ptr, const char *user_id) {
peer_ptr->peer_connection->Init(peer_ptr->pc_params, user_id);
return 0;
}
int CreateConnection(PeerPtr *peer_ptr, const char *transmission_id,
const char *user_id) {
peer_ptr->peer_connection->Init(peer_ptr->pc_params, transmission_id,
user_id);
peer_ptr->peer_connection->Create(peer_ptr->pc_params, transmission_id,
user_id);
int CreateConnection(PeerPtr *peer_ptr, const char *transmission_id) {
peer_ptr->peer_connection->Create(peer_ptr->pc_params, transmission_id);
LOG_INFO("CreateConnection");
return 0;
}
int JoinConnection(PeerPtr *peer_ptr, const char *transmission_id,
const char *user_id) {
peer_ptr->peer_connection->Init(peer_ptr->pc_params, transmission_id,
user_id);
peer_ptr->peer_connection->Join(peer_ptr->pc_params, transmission_id,
user_id);
int JoinConnection(PeerPtr *peer_ptr, const char *transmission_id) {
peer_ptr->peer_connection->Join(peer_ptr->pc_params, transmission_id);
LOG_INFO("JoinConnection");
return 0;
}

8
src/transmission/ice_transmission.cpp
View File

@@ -125,11 +125,13 @@ int IceTransmission::InitIceTransmission(std::string &stun_ip, int stun_port,
IceTransmission *ice_transmission_obj =
static_cast<IceTransmission *>(user_ptr);
LOG_INFO("[{}->{}] state_change: {}", ice_transmission_obj->user_id_,
ice_transmission_obj->remote_user_id_, ice_status[state]);
ice_transmission_obj->remote_user_id_,
juice_state_to_string(state));
ice_transmission_obj->state_ = state;
ice_transmission_obj->on_ice_status_change_(ice_status[state]);
ice_transmission_obj->on_ice_status_change_(
juice_state_to_string(state));
} else {
LOG_INFO("state_change: {}", ice_status[state]);
LOG_INFO("state_change: {}", juice_state_to_string(state));
}
},
[](juice_agent_t *agent, const char *sdp, void *user_ptr) {