From aa1bc1a936a23431cb226440f64d3c6bb4cc4fb7 Mon Sep 17 00:00:00 2001 From: dijunkun Date: Mon, 23 Sep 2024 14:31:07 +0800 Subject: [PATCH] [fix] fix the issue where created video codec is different from the one negotiated --- src/media/video/encode/video_encoder_factory.cpp | 1 + src/pc/peer_connection.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/media/video/encode/video_encoder_factory.cpp b/src/media/video/encode/video_encoder_factory.cpp index 2bac889..35d0470 100644 --- a/src/media/video/encode/video_encoder_factory.cpp +++ b/src/media/video/encode/video_encoder_factory.cpp @@ -23,6 +23,7 @@ std::unique_ptr VideoEncoderFactory::CreateVideoEncoder( return std::make_unique(AomAv1Encoder()); } else { #if __APPLE__ + LOG_INFO("Use OpenH264 encoder"); return std::make_unique(OpenH264Encoder()); #else if (hardware_acceleration) { diff --git a/src/pc/peer_connection.cpp b/src/pc/peer_connection.cpp index 30769f6..c16b3ef 100644 --- a/src/pc/peer_connection.cpp +++ b/src/pc/peer_connection.cpp @@ -261,7 +261,7 @@ int PeerConnection::CreateVideoCodec(bool av1, bool hardware_acceleration) { hardware_acceleration_ = hardware_acceleration; - if (av1_encoding_) { + if (av1) { if (hardware_acceleration_) { hardware_acceleration_ = false; LOG_WARN("Only support software codec for AV1");