mirror of
				https://github.com/kunkundi/crossdesk.git
				synced 2025-10-26 20:25:34 +08:00 
			
		
		
		
	[feat] clean rtp packet buffer queue when ice destroyed
This commit is contained in:
		| @@ -23,8 +23,8 @@ void AudioChannelReceive::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|         } | ||||
|       }); | ||||
|  | ||||
|   rtp_audio_receiver_->SetSendDataFunc( | ||||
|       [this](const char *data, size_t size) -> int { | ||||
|   rtp_audio_receiver_->SetSendDataFunc([this](const char *data, | ||||
|                                               size_t size) -> int { | ||||
|     if (!ice_agent_) { | ||||
|       LOG_ERROR("ice_agent_ is nullptr"); | ||||
|       return -1; | ||||
| @@ -32,10 +32,8 @@ void AudioChannelReceive::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|  | ||||
|     auto ice_state = ice_agent_->GetIceState(); | ||||
|  | ||||
|         if (ice_state != NICE_COMPONENT_STATE_CONNECTED && | ||||
|             ice_state != NICE_COMPONENT_STATE_READY) { | ||||
|           LOG_ERROR("Ice is not connected, state = [{}]", | ||||
|                     nice_component_state_to_string(ice_state)); | ||||
|     if (ICE_STATE_NULLPTR == ice_state || ICE_STATE_DESTROYED == ice_state) { | ||||
|       LOG_ERROR("Ice is not connected, state = [{}]", (int)ice_state); | ||||
|       return -2; | ||||
|     } | ||||
|  | ||||
|   | ||||
| @@ -25,10 +25,7 @@ void AudioChannelSend::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|  | ||||
|         auto ice_state = ice_agent_->GetIceState(); | ||||
|  | ||||
|         if (ice_state != NICE_COMPONENT_STATE_CONNECTED && | ||||
|             ice_state != NICE_COMPONENT_STATE_READY) { | ||||
|           LOG_ERROR("Ice is not connected, state = [{}]", | ||||
|                     nice_component_state_to_string(ice_state)); | ||||
|         if (ICE_STATE_DESTROYED == ice_state) { | ||||
|           return -2; | ||||
|         } | ||||
|  | ||||
|   | ||||
| @@ -23,8 +23,8 @@ void DataChannelReceive::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|         } | ||||
|       }); | ||||
|  | ||||
|   rtp_data_receiver_->SetSendDataFunc( | ||||
|       [this](const char *data, size_t size) -> int { | ||||
|   rtp_data_receiver_->SetSendDataFunc([this](const char *data, | ||||
|                                              size_t size) -> int { | ||||
|     if (!ice_agent_) { | ||||
|       LOG_ERROR("ice_agent_ is nullptr"); | ||||
|       return -1; | ||||
| @@ -32,10 +32,8 @@ void DataChannelReceive::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|  | ||||
|     auto ice_state = ice_agent_->GetIceState(); | ||||
|  | ||||
|         if (ice_state != NICE_COMPONENT_STATE_CONNECTED && | ||||
|             ice_state != NICE_COMPONENT_STATE_READY) { | ||||
|           LOG_ERROR("Ice is not connected, state = [{}]", | ||||
|                     nice_component_state_to_string(ice_state)); | ||||
|     if (ICE_STATE_NULLPTR == ice_state || ICE_STATE_DESTROYED == ice_state) { | ||||
|       LOG_ERROR("Ice is not connected, state = [{}]", (int)ice_state); | ||||
|       return -2; | ||||
|     } | ||||
|  | ||||
|   | ||||
| @@ -25,10 +25,7 @@ void DataChannelSend::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|  | ||||
|         auto ice_state = ice_agent_->GetIceState(); | ||||
|  | ||||
|         if (ice_state != NICE_COMPONENT_STATE_CONNECTED && | ||||
|             ice_state != NICE_COMPONENT_STATE_READY) { | ||||
|           LOG_ERROR("Ice is not connected, state = [{}]", | ||||
|                     nice_component_state_to_string(ice_state)); | ||||
|         if (ICE_STATE_DESTROYED == ice_state) { | ||||
|           return -2; | ||||
|         } | ||||
|  | ||||
|   | ||||
| @@ -23,8 +23,8 @@ void VideoChannelReceive::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|         on_receive_complete_frame_(video_frame); | ||||
|       }); | ||||
|  | ||||
|   rtp_video_receiver_->SetSendDataFunc( | ||||
|       [this](const char *data, size_t size) -> int { | ||||
|   rtp_video_receiver_->SetSendDataFunc([this](const char *data, | ||||
|                                               size_t size) -> int { | ||||
|     if (!ice_agent_) { | ||||
|       LOG_ERROR("ice_agent_ is nullptr"); | ||||
|       return -1; | ||||
| @@ -32,10 +32,8 @@ void VideoChannelReceive::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|  | ||||
|     auto ice_state = ice_agent_->GetIceState(); | ||||
|  | ||||
|         if (ice_state != NICE_COMPONENT_STATE_CONNECTED && | ||||
|             ice_state != NICE_COMPONENT_STATE_READY) { | ||||
|           LOG_ERROR("Ice is not connected, state = [{}]", | ||||
|                     nice_component_state_to_string(ice_state)); | ||||
|     if (ICE_STATE_NULLPTR == ice_state || ICE_STATE_DESTROYED == ice_state) { | ||||
|       LOG_ERROR("Ice is not connected, state = [{}]", (int)ice_state); | ||||
|       return -2; | ||||
|     } | ||||
|  | ||||
|   | ||||
| @@ -31,10 +31,7 @@ void VideoChannelSend::Initialize(rtp::PAYLOAD_TYPE payload_type) { | ||||
|  | ||||
|         auto ice_state = ice_agent_->GetIceState(); | ||||
|  | ||||
|         if (ice_state != NICE_COMPONENT_STATE_CONNECTED && | ||||
|             ice_state != NICE_COMPONENT_STATE_READY) { | ||||
|           // LOG_ERROR("Ice is not connected, state = [{}]", | ||||
|           //           nice_component_state_to_string(ice_state)); | ||||
|         if (ICE_STATE_DESTROYED == ice_state) { | ||||
|           return -2; | ||||
|         } | ||||
|  | ||||
|   | ||||
| @@ -45,9 +45,10 @@ int RtpAudioSender::SendRtpPacket(std::shared_ptr<RtpPacket> rtp_packet) { | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   if (0 != data_send_func_((const char*)rtp_packet->Buffer().data(), | ||||
|                            rtp_packet->Size())) { | ||||
|     LOG_ERROR("Send rtp packet failed"); | ||||
|   int ret = data_send_func_((const char*)rtp_packet->Buffer().data(), | ||||
|                             rtp_packet->Size()); | ||||
|   if (-2 == ret) { | ||||
|     rtp_packet_queue_.clear(); | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   | ||||
| @@ -45,9 +45,10 @@ int RtpDataSender::SendRtpPacket(std::shared_ptr<RtpPacket> rtp_packet) { | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   if (0 != data_send_func_((const char*)rtp_packet->Buffer().data(), | ||||
|                            rtp_packet->Size())) { | ||||
|     LOG_ERROR("Send rtp packet failed"); | ||||
|   int ret = data_send_func_((const char*)rtp_packet->Buffer().data(), | ||||
|                             rtp_packet->Size()); | ||||
|   if (-2 == ret) { | ||||
|     rtp_packet_queue_.clear(); | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   | ||||
| @@ -85,9 +85,11 @@ int RtpVideoSender::SendRtpPacket( | ||||
|   } | ||||
|  | ||||
|   last_rtp_timestamp_ = rtp_packet_to_send->capture_time().ms(); | ||||
|   if (0 != data_send_func_((const char*)rtp_packet_to_send->Buffer().data(), | ||||
|                            rtp_packet_to_send->Size())) { | ||||
|     // LOG_ERROR("Send rtp packet failed"); | ||||
|  | ||||
|   int ret = data_send_func_((const char*)rtp_packet_to_send->Buffer().data(), | ||||
|                             rtp_packet_to_send->Size()); | ||||
|   if (-2 == ret) { | ||||
|     rtp_packet_queue_.clear(); | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
| @@ -131,8 +133,9 @@ int RtpVideoSender::SendRtcpSR(SenderReport& rtcp_sr) { | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   if (data_send_func_((const char*)rtcp_sr.Buffer(), rtcp_sr.Size())) { | ||||
|     LOG_ERROR("Send SR failed"); | ||||
|   int ret = data_send_func_((const char*)rtcp_sr.Buffer(), rtcp_sr.Size()); | ||||
|   if (ret != 0) { | ||||
|     LOG_ERROR("Send rtcp sr failed"); | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   | ||||
| @@ -335,23 +335,20 @@ int IceAgent::GatherCandidates() { | ||||
|   return 0; | ||||
| } | ||||
|  | ||||
| NiceComponentState IceAgent::GetIceState() { | ||||
| ICE_STATE IceAgent::GetIceState() { | ||||
|   if (!nice_inited_) { | ||||
|     LOG_ERROR("Nice agent has not been initialized"); | ||||
|     return NiceComponentState::NICE_COMPONENT_STATE_LAST; | ||||
|     return ICE_STATE_NOT_INITIALIZED; | ||||
|   } | ||||
|  | ||||
|   if (nullptr == agent_) { | ||||
|     LOG_ERROR("Nice agent is nullptr"); | ||||
|     return NiceComponentState::NICE_COMPONENT_STATE_LAST; | ||||
|     return ICE_STATE_NULLPTR; | ||||
|   } | ||||
|  | ||||
|   if (destroyed_) { | ||||
|     LOG_ERROR("Nice agent is destroyed"); | ||||
|     return NiceComponentState::NICE_COMPONENT_STATE_LAST; | ||||
|     return ICE_STATE_DESTROYED; | ||||
|   } | ||||
|  | ||||
|   state_ = nice_agent_get_component_state(agent_, stream_id_, 1); | ||||
|   state_ = (ICE_STATE)nice_agent_get_component_state(agent_, stream_id_, 1); | ||||
|  | ||||
|   return state_; | ||||
| } | ||||
| @@ -377,7 +374,7 @@ int IceAgent::Send(const char *data, size_t size) { | ||||
|     return -1; | ||||
|   } | ||||
|  | ||||
|   // if (NiceComponentState::NICE_COMPONENT_STATE_READY != | ||||
|   // if (ICE_STATE_READY != | ||||
|   //     nice_agent_get_component_state(agent_, stream_id_, 1)) { | ||||
|   //   LOG_ERROR("Nice agent not ready"); | ||||
|   //   return -1; | ||||
|   | ||||
| @@ -9,6 +9,19 @@ | ||||
| #include "glib.h" | ||||
| #include "nice/agent.h" | ||||
|  | ||||
| typedef enum { | ||||
|   ICE_STATE_DISCONNECTED, | ||||
|   ICE_STATE_GATHERING, | ||||
|   ICE_STATE_CONNECTING, | ||||
|   ICE_STATE_CONNECTED, | ||||
|   ICE_STATE_READY, | ||||
|   ICE_STATE_FAILED, | ||||
|   ICE_STATE_NOT_INITIALIZED, | ||||
|   ICE_STATE_DESTROYED, | ||||
|   ICE_STATE_NULLPTR, | ||||
|   ICE_STATE_LAST | ||||
| } ICE_STATE; | ||||
|  | ||||
| typedef void (*nice_cb_state_changed_t)(NiceAgent* agent, guint stream_id, | ||||
|                                         guint component_id, | ||||
|                                         NiceComponentState state, | ||||
| @@ -56,7 +69,7 @@ class IceAgent { | ||||
|  | ||||
|   int GatherCandidates(); | ||||
|  | ||||
|   NiceComponentState GetIceState(); | ||||
|   ICE_STATE GetIceState(); | ||||
|  | ||||
|   int SetRemoteGatheringDone(); | ||||
|  | ||||
| @@ -99,7 +112,7 @@ class IceAgent { | ||||
|   uint32_t n_components_ = 1; | ||||
|   // char* local_sdp_ = nullptr; | ||||
|   std::string local_sdp_ = ""; | ||||
|   NiceComponentState state_ = NiceComponentState::NICE_COMPONENT_STATE_LAST; | ||||
|   ICE_STATE state_ = ICE_STATE_LAST; | ||||
|   bool destroyed_ = false; | ||||
|   gboolean agent_closed_ = false; | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user