Use latest language features (#2176)

* Make use of language features line AsyncDispose, init etc. * Fix build errors * Improve Unit Tests * Improve Unit Tests * Improve Unit Tests * Update samples * Remove obsolete benchmarks * Code cleanup * Improve unit tests * Improve Unit Tests * Fix Unit Tests * Improve Unit Tests * Improve Unit Tests * Restore unit tests * Exclude load tests from unit tests
2026-10-19 19:13:11 +08:00 · 2025-08-30 10:52:59 +02:00
parent 247988e633
commit e43e7f8e36
330 changed files with 21417 additions and 22919 deletions
@@ -4,101 +4,100 @@

 using MQTTnet.Packets;

-namespace MQTTnet.Server.Internal
+namespace MQTTnet.Server.Internal;
+
+public sealed class MqttClientStatistics
 {
-    public sealed class MqttClientStatistics
+    Statistics _statistics = new Statistics     // mutable struct, don't make readonly!
    {
-        Statistics _statistics = new Statistics     // mutable struct, don't make readonly!
+        // Start with 1 because the CONNACK packet is not counted here.
+        _receivedPacketsCount = 1,
+
+        // Start with 1 because the CONNECT packet is not counted here.
+        _sentPacketsCount = 1
+    };
+
+    public MqttClientStatistics()
+    {
+        ConnectedTimestamp = DateTime.UtcNow;
+
+        LastPacketReceivedTimestamp = ConnectedTimestamp;
+        LastPacketSentTimestamp = ConnectedTimestamp;
+
+        LastNonKeepAlivePacketReceivedTimestamp = ConnectedTimestamp;
+    }
+
+    public DateTime ConnectedTimestamp { get; }
+    public DateTime LastNonKeepAlivePacketReceivedTimestamp { get; private set; }
+
+    /// <summary>
+    ///     Timestamp of the last package that has been sent to the client ("received" from the client's perspective)
+    /// </summary>
+    public DateTime LastPacketReceivedTimestamp { get; private set; }
+
+    /// <summary>
+    ///     Timestamp of the last package that has been received from the client ("sent" from the client's perspective)
+    /// </summary>
+    public DateTime LastPacketSentTimestamp { get; private set; }
+
+    public long SentApplicationMessagesCount => Volatile.Read(ref _statistics._sentApplicationMessagesCount);
+
+    public long ReceivedApplicationMessagesCount => Volatile.Read(ref _statistics._receivedApplicationMessagesCount);
+
+    public long SentPacketsCount => Volatile.Read(ref _statistics._sentPacketsCount);
+
+    public long ReceivedPacketsCount => Volatile.Read(ref _statistics._receivedPacketsCount);
+
+    public void HandleReceivedPacket(MqttPacket packet)
+    {
+        ArgumentNullException.ThrowIfNull(packet);
+
+        // This class is tracking all values from Clients perspective!
+        LastPacketSentTimestamp = DateTime.UtcNow;
+
+        Interlocked.Increment(ref _statistics._sentPacketsCount);
+
+        if (packet is MqttPublishPacket)
        {
-            // Start with 1 because the CONNACK packet is not counted here.
-            _receivedPacketsCount = 1,
-
-            // Start with 1 because the CONNECT packet is not counted here.
-            _sentPacketsCount = 1
-        };
-
-        public MqttClientStatistics()
-        {
-            ConnectedTimestamp = DateTime.UtcNow;
-
-            LastPacketReceivedTimestamp = ConnectedTimestamp;
-            LastPacketSentTimestamp = ConnectedTimestamp;
-
-            LastNonKeepAlivePacketReceivedTimestamp = ConnectedTimestamp;
+            Interlocked.Increment(ref _statistics._sentApplicationMessagesCount);
        }

-        public DateTime ConnectedTimestamp { get; }
-        public DateTime LastNonKeepAlivePacketReceivedTimestamp { get; private set; }
-
-        /// <summary>
-        ///     Timestamp of the last package that has been sent to the client ("received" from the client's perspective)
-        /// </summary>
-        public DateTime LastPacketReceivedTimestamp { get; private set; }
-
-        /// <summary>
-        ///     Timestamp of the last package that has been received from the client ("sent" from the client's perspective)
-        /// </summary>
-        public DateTime LastPacketSentTimestamp { get; private set; }
-
-        public long SentApplicationMessagesCount => Volatile.Read(ref _statistics._sentApplicationMessagesCount);
-
-        public long ReceivedApplicationMessagesCount => Volatile.Read(ref _statistics._receivedApplicationMessagesCount);
-
-        public long SentPacketsCount => Volatile.Read(ref _statistics._sentPacketsCount);
-
-        public long ReceivedPacketsCount => Volatile.Read(ref _statistics._receivedPacketsCount);
-
-        public void HandleReceivedPacket(MqttPacket packet)
+        if (!(packet is MqttPingReqPacket || packet is MqttPingRespPacket))
        {
-            ArgumentNullException.ThrowIfNull(packet);
-
-            // This class is tracking all values from Clients perspective!
-            LastPacketSentTimestamp = DateTime.UtcNow;
-
-            Interlocked.Increment(ref _statistics._sentPacketsCount);
-
-            if (packet is MqttPublishPacket)
-            {
-                Interlocked.Increment(ref _statistics._sentApplicationMessagesCount);
-            }
-
-            if (!(packet is MqttPingReqPacket || packet is MqttPingRespPacket))
-            {
-                LastNonKeepAlivePacketReceivedTimestamp = LastPacketReceivedTimestamp;
-            }
+            LastNonKeepAlivePacketReceivedTimestamp = LastPacketReceivedTimestamp;
        }
-        public void ResetStatistics() => _statistics.Reset();
+    }
+    public void ResetStatistics() => _statistics.Reset();

-        public void HandleSentPacket(MqttPacket packet)
+    public void HandleSentPacket(MqttPacket packet)
+    {
+        ArgumentNullException.ThrowIfNull(packet);
+
+        // This class is tracking all values from Clients perspective!
+        LastPacketReceivedTimestamp = DateTime.UtcNow;
+
+        Interlocked.Increment(ref _statistics._receivedPacketsCount);
+
+        if (packet is MqttPublishPacket)
        {
-            ArgumentNullException.ThrowIfNull(packet);
-
-            // This class is tracking all values from Clients perspective!
-            LastPacketReceivedTimestamp = DateTime.UtcNow;
-
-            Interlocked.Increment(ref _statistics._receivedPacketsCount);
-
-            if (packet is MqttPublishPacket)
-            {
-                Interlocked.Increment(ref _statistics._receivedApplicationMessagesCount);
-            }
+            Interlocked.Increment(ref _statistics._receivedApplicationMessagesCount);
        }
+    }

-        struct Statistics
+    struct Statistics
+    {
+        public long _receivedPacketsCount;
+        public long _sentPacketsCount;
+
+        public long _receivedApplicationMessagesCount;
+        public long _sentApplicationMessagesCount;
+
+        public void Reset()
        {
-            public long _receivedPacketsCount;
-            public long _sentPacketsCount;
-
-            public long _receivedApplicationMessagesCount;
-            public long _sentApplicationMessagesCount;
-
-            public void Reset()
-            {
-                Volatile.Write(ref _receivedPacketsCount, 0);
-                Volatile.Write(ref _sentPacketsCount, 0);
-                Volatile.Write(ref _receivedApplicationMessagesCount, 0);
-                Volatile.Write(ref _sentApplicationMessagesCount, 0);
-            }
+            Volatile.Write(ref _receivedPacketsCount, 0);
+            Volatile.Write(ref _sentPacketsCount, 0);
+            Volatile.Write(ref _receivedApplicationMessagesCount, 0);
+            Volatile.Write(ref _sentApplicationMessagesCount, 0);
        }
    }
 }