Use latest language features (#2176)

* Make use of language features line AsyncDispose, init etc.

* Fix build errors

* Improve Unit Tests

* Improve Unit Tests

* Improve Unit Tests

* Update samples

* Remove obsolete benchmarks

* Code cleanup

* Improve unit tests

* Improve Unit Tests

* Fix Unit Tests

* Improve Unit Tests

* Improve Unit Tests

* Restore unit tests

* Exclude load tests from unit tests

Source/MQTTnet.Server/Disconnecting/MqttServerClientDisconnectOptions.cs

@@ -5,28 +5,27 @@
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class MqttServerClientDisconnectOptions
 {
-    public sealed class MqttServerClientDisconnectOptions
-    {
-        public MqttDisconnectReasonCode ReasonCode { get; set; } = MqttDisconnectReasonCode.NormalDisconnection;
+    public MqttDisconnectReasonCode ReasonCode { get; set; } = MqttDisconnectReasonCode.NormalDisconnection;
 
-        /// <summary>
-        ///     The reason string is sent to every client via a DISCONNECT packet.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public string ReasonString { get; set; }
+    /// <summary>
+    ///     The reason string is sent to every client via a DISCONNECT packet.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public string ReasonString { get; set; }
 
-        /// <summary>
-        ///     The server reference is sent to every client via a DISCONNECT packet.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public string ServerReference { get; set; }
+    /// <summary>
+    ///     The server reference is sent to every client via a DISCONNECT packet.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public string ServerReference { get; set; }
 
-        /// <summary>
-        ///     These user properties are sent to every client via a DISCONNECT packet.
-        ///     <remarks>MQTT 5.0.0+ feature.</remarks>
-        /// </summary>
-        public List<MqttUserProperty> UserProperties { get; set; }
-    }
+    /// <summary>
+    ///     These user properties are sent to every client via a DISCONNECT packet.
+    ///     <remarks>MQTT 5.0.0+ feature.</remarks>
+    /// </summary>
+    public List<MqttUserProperty> UserProperties { get; set; }
 }

Source/MQTTnet.Server/Disconnecting/MqttServerClientDisconnectOptionsBuilder.cs

@@ -5,50 +5,49 @@
 using MQTTnet.Packets;
 using MQTTnet.Protocol;
 
-namespace MQTTnet.Server
+namespace MQTTnet.Server;
+
+public sealed class MqttServerClientDisconnectOptionsBuilder
 {
-    public sealed class MqttServerClientDisconnectOptionsBuilder
+    readonly MqttServerClientDisconnectOptions _options = new MqttServerClientDisconnectOptions();
+
+    public MqttServerClientDisconnectOptions Build()
     {
-        readonly MqttServerClientDisconnectOptions _options = new MqttServerClientDisconnectOptions();
+        return _options;
+    }
 
-        public MqttServerClientDisconnectOptions Build()
+    public MqttServerClientDisconnectOptionsBuilder WithReasonCode(MqttDisconnectReasonCode value)
+    {
+        _options.ReasonCode = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithReasonString(string value)
+    {
+        _options.ReasonString = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithServerReference(string value)
+    {
+        _options.ServerReference = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithUserProperties(List<MqttUserProperty> value)
+    {
+        _options.UserProperties = value;
+        return this;
+    }
+
+    public MqttServerClientDisconnectOptionsBuilder WithUserProperty(string name, string value)
+    {
+        if (_options.UserProperties == null)
         {
-            return _options;
+            _options.UserProperties = new List<MqttUserProperty>();
         }
 
-        public MqttServerClientDisconnectOptionsBuilder WithReasonCode(MqttDisconnectReasonCode value)
-        {
-            _options.ReasonCode = value;
-            return this;
-        }
-
-        public MqttServerClientDisconnectOptionsBuilder WithReasonString(string value)
-        {
-            _options.ReasonString = value;
-            return this;
-        }
-
-        public MqttServerClientDisconnectOptionsBuilder WithServerReference(string value)
-        {
-            _options.ServerReference = value;
-            return this;
-        }
-
-        public MqttServerClientDisconnectOptionsBuilder WithUserProperties(List<MqttUserProperty> value)
-        {
-            _options.UserProperties = value;
-            return this;
-        }
-
-        public MqttServerClientDisconnectOptionsBuilder WithUserProperty(string name, string value)
-        {
-            if (_options.UserProperties == null)
-            {
-                _options.UserProperties = new List<MqttUserProperty>();
-            }
-
-            _options.UserProperties.Add(new MqttUserProperty(name, value));
-            return this;
-        }
+        _options.UserProperties.Add(new MqttUserProperty(name, value));
+        return this;
     }
 }