YangWX/MQTTnet
1
0
Fork 0
mirror of https://github.com/dotnet/MQTTnet.git synced 2026-10-16 09:13:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Issues #2091 Improve the performance of RetainedMessages without subs… (#2093)

Browse Source 
* Issues #2091 Improve the performance of RetainedMessages without subscribing to RetainedMessageChangedEvent.

* Fix build errors

* Update release notes

---------

Co-authored-by: Christian <6939810+chkr1011@users.noreply.github.com>
This commit is contained in:
zhaowgit
2025-10-17 19:04:11 +02:00
committed by GitHub
co-authored by Christian
parent 75ebf116cf
commit c97bd82334
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/MQTTnet.Server/Internal/MqttRetainedMessagesManager.cs
+8 -3
View File
@@ -9,8 +9,8 @@ namespace MQTTnet.Server.Internal;
public sealed class MqttRetainedMessagesManager public sealed class MqttRetainedMessagesManager
{ {
readonly Dictionary<string, MqttApplicationMessage> _messages = new Dictionary<string, MqttApplicationMessage>(4096); readonly Dictionary<string, MqttApplicationMessage> _messages = new(4096);
readonly AsyncLock _storageAccessLock = new AsyncLock(); readonly AsyncLock _storageAccessLock = new();
readonly MqttServerEventContainer _eventContainer; readonly MqttServerEventContainer _eventContainer;
readonly MqttNetSourceLogger _logger; readonly MqttNetSourceLogger _logger;
@@ -61,6 +61,7 @@ public sealed class MqttRetainedMessagesManager
lock (_messages) lock (_messages)
{ {
var hasHandlers = _eventContainer.RetainedMessageChangedEvent.HasHandlers;
var payload = applicationMessage.Payload; var payload = applicationMessage.Payload;
var hasPayload = payload.Length > 0; var hasPayload = payload.Length > 0;
@@ -86,10 +87,14 @@ public sealed class MqttRetainedMessagesManager
} }
} }
if (saveIsRequired && hasHandlers)
{
messagesForSave = new List<MqttApplicationMessage>(_messages.Values);
}
_logger.Verbose("Client '{0}' set retained message for topic '{1}'.", clientId, applicationMessage.Topic); _logger.Verbose("Client '{0}' set retained message for topic '{1}'.", clientId, applicationMessage.Topic);
} }
if (saveIsRequired) if (saveIsRequired && hasHandlers)
{ {
messagesForSave = new List<MqttApplicationMessage>(_messages.Values); messagesForSave = new List<MqttApplicationMessage>(_messages.Values);
} }
Source/ReleaseNotes.md
+1
View File
@@ -1,2 +1,3 @@
* Core: Used new language features across the entire library * Core: Used new language features across the entire library
* Core: Performance improvements * Core: Performance improvements
* Server: Improved performance of retained messages when no event handler is attached (#2093, thanks to @zhaowgit)