Add warning

This commit is contained in:
Christian
2023-05-06 14:17:39 +02:00
parent 533b8e22c2
commit addf812d58
2 changed files with 4 additions and 2 deletions
@@ -19,7 +19,6 @@ namespace MQTTnet.Client.Internal
{ {
readonly MqttClient _client; readonly MqttClient _client;
readonly MqttNetSourceLogger _logger; readonly MqttNetSourceLogger _logger;
readonly MqttClientConnectResultFactory _clientConnectResultFactory = new MqttClientConnectResultFactory();
public MqttClientAuthenticationHandler(MqttClient client, IMqttNetLogger logger) public MqttClientAuthenticationHandler(MqttClient client, IMqttNetLogger logger)
{ {
@@ -86,7 +85,7 @@ namespace MQTTnet.Client.Internal
} }
} }
result = _clientConnectResultFactory.Create(connAckPacket, channelAdapter.PacketFormatterAdapter.ProtocolVersion); result = MqttClientResultFactory.ConnectResult.Create(connAckPacket, channelAdapter.PacketFormatterAdapter.ProtocolVersion);
} }
catch (Exception exception) catch (Exception exception)
{ {
@@ -98,6 +97,8 @@ namespace MQTTnet.Client.Internal
// did send a proper ACK packet. // did send a proper ACK packet.
if (options.ThrowOnNonSuccessfulResponseFromServer) if (options.ThrowOnNonSuccessfulResponseFromServer)
{ {
_logger.Warning("Client will now throw an _MqttConnectingFailedException_. This is obsolete and will be removed in the future. Consider setting _ThrowOnNonSuccessfulResponseFromServer=False_ in client options.");
if (result.ResultCode != MqttClientConnectResultCode.Success) if (result.ResultCode != MqttClientConnectResultCode.Success)
{ {
throw new MqttConnectingFailedException($"Connecting with MQTT server failed ({result.ResultCode}).", null, result); throw new MqttConnectingFailedException($"Connecting with MQTT server failed ({result.ResultCode}).", null, result);
@@ -6,6 +6,7 @@ namespace MQTTnet.Client.Internal
{ {
public static class MqttClientResultFactory public static class MqttClientResultFactory
{ {
public static readonly MqttClientConnectResultFactory ConnectResult = new MqttClientConnectResultFactory();
public static readonly MqttClientPublishResultFactory PublishResult = new MqttClientPublishResultFactory(); public static readonly MqttClientPublishResultFactory PublishResult = new MqttClientPublishResultFactory();
public static readonly MqttClientSubscribeResultFactory SubscribeResult = new MqttClientSubscribeResultFactory(); public static readonly MqttClientSubscribeResultFactory SubscribeResult = new MqttClientSubscribeResultFactory();
public static readonly MqttClientUnsubscribeResultFactory UnsubscribeResult = new MqttClientUnsubscribeResultFactory(); public static readonly MqttClientUnsubscribeResultFactory UnsubscribeResult = new MqttClientUnsubscribeResultFactory();