From 8cf5537043b42050abe791fd18b1f9493a910d7c Mon Sep 17 00:00:00 2001 From: Christian <6939810+chkr1011@users.noreply.github.com> Date: Sun, 23 Oct 2022 08:45:16 +0200 Subject: [PATCH] Improve unit tests --- .../Client/ManagedMqttClient_Tests.cs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Source/MQTTnet.Tests/Client/ManagedMqttClient_Tests.cs b/Source/MQTTnet.Tests/Client/ManagedMqttClient_Tests.cs index e161b212..554cc663 100644 --- a/Source/MQTTnet.Tests/Client/ManagedMqttClient_Tests.cs +++ b/Source/MQTTnet.Tests/Client/ManagedMqttClient_Tests.cs @@ -279,7 +279,7 @@ namespace MQTTnet.Tests.Client }); // Wait a bit for the retained message to be available - await Task.Delay(1000); + await LongTestDelay(); await sendingClient.DisconnectAsync(); @@ -288,7 +288,8 @@ namespace MQTTnet.Tests.Client var clientOptions = new MqttClientOptionsBuilder().WithTcpServer("127.0.0.1", testEnvironment.ServerPort); var receivedManagedMessages = new List(); - var managedClient = new ManagedMqttClient(testEnvironment.CreateClient(), new MqttNetEventLogger()); + + var managedClient = testEnvironment.Factory.CreateManagedMqttClient(testEnvironment.CreateClient()); managedClient.ApplicationMessageReceivedAsync += e => { receivedManagedMessages.Add(e.ApplicationMessage); @@ -299,17 +300,17 @@ namespace MQTTnet.Tests.Client await managedClient.StartAsync(new ManagedMqttClientOptionsBuilder().WithClientOptions(clientOptions).WithAutoReconnectDelay(TimeSpan.FromSeconds(1)).Build()); - await Task.Delay(1000); + await LongTestDelay(); Assert.AreEqual(1, receivedManagedMessages.Count); await managedClient.StopAsync(); - await Task.Delay(500); + await LongTestDelay(); await managedClient.StartAsync(new ManagedMqttClientOptionsBuilder().WithClientOptions(clientOptions).WithAutoReconnectDelay(TimeSpan.FromSeconds(1)).Build()); - await Task.Delay(1000); + await LongTestDelay(); // After reconnect and then some delay, the retained message must not be received, // showing that the subscriptions were cleared @@ -317,7 +318,9 @@ namespace MQTTnet.Tests.Client // Make sure that it gets received after subscribing again. await managedClient.SubscribeAsync("topic"); - await Task.Delay(500); + + await LongTestDelay(); + Assert.AreEqual(2, receivedManagedMessages.Count); } }