Improve allocations for AsyncSignal.

.github/workflows/ReleaseNotes.md

@@ -1 +1 @@
-
+[Core] Fixed a memory leak in _AsyncSignal_ implementation (#1586, thanks to @mario-zelger).

Source/MQTTnet/Internal/AsyncSignal.cs

@@ -34,7 +34,7 @@ namespace MQTTnet.Internal
                 _isSignaled = true;
 
                 Cleanup();
-                
+
                 // If there is already a waiting task let it run.
                 if (_waiter != null)
                 {
@@ -103,6 +103,8 @@ namespace MQTTnet.Internal
             // ReSharper disable once FieldCanBeMadeReadOnly.Local
             CancellationTokenRegistration _cancellationTokenRegistration;
 
+            volatile bool _isCompleted;
+
             public AsyncSignalWaiter(CancellationToken cancellationToken)
             {
                 if (cancellationToken.CanBeCanceled)
@@ -115,18 +117,37 @@ namespace MQTTnet.Internal
 
             public void Approve()
             {
+                if (_isCompleted)
+                {
+                    return;
+                }
+
+                _isCompleted = true;
                 _promise.TrySetResult(true);
             }
 
             public void Dispose()
             {
                 _cancellationTokenRegistration.Dispose();
+                
+                if (_isCompleted)
+                {
+                    // Avoid allocation of _ObjectDisposedException_ which may not be used.
+                    return;
+                }
 
+                _isCompleted = true;
                 _promise.TrySetException(new ObjectDisposedException(nameof(AsyncSignalWaiter)));
             }
 
             void Cancel()
             {
+                if (_isCompleted)
+                {
+                    return;
+                }
+
+                _isCompleted = true;
                 _promise.TrySetCanceled();
             }
         }

Source/MQTTnet/Server/InjectedMqttApplicationMessage.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Threading;
 
 namespace MQTTnet.Server
 {