YangWX/MQTTnet
1
0
Fork 0
mirror of https://github.com/dotnet/MQTTnet.git synced 2026-10-25 07:41:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change behavior of NoMatchingSubscribers (#1975)

Browse Source 
Change behavior of NoMatchingSubscribers.
This commit is contained in:
Christian
2024-04-26 18:35:39 +02:00
committed by GitHub
parent 1aa91e3828
commit 4ab956abd1
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ReleaseNotes.md
+1
View File
@@ -1,5 +1,6 @@
* [Core] Optimized packet serialization of PUBACK and PUBREC packets for protocol version 5.0.0 (#1939, thanks to @Y-Sindo). * [Core] Optimized packet serialization of PUBACK and PUBREC packets for protocol version 5.0.0 (#1939, thanks to @Y-Sindo).
* [Core] The package inspector is now fully async (#1941). * [Core] The package inspector is now fully async (#1941).
* [Client] Added a dedicated exception when the client is not connected (#1954, thanks to @marcpiulachs). * [Client] Added a dedicated exception when the client is not connected (#1954, thanks to @marcpiulachs).
* [Server] The server will no longer send _NoMatchingSubscribers_ when the actual subscription was non success (#1965, BREAKING CHANGE!).
* [ManagedClient] Added a new event (SubscriptionsChangedAsync) which is fired when a subscription or unsubscription was made (#1894, thanks to @pdufrene). * [ManagedClient] Added a new event (SubscriptionsChangedAsync) which is fired when a subscription or unsubscription was made (#1894, thanks to @pdufrene).
* [TopicTemplate] Added new extension which provides a template engine for topics (#1932, thanks to @simonthum). * [TopicTemplate] Added new extension which provides a template engine for topics (#1932, thanks to @simonthum).
Source/MQTTnet/Server/Internal/MqttClientSessionsManager.cs
+6 -1
View File
@@ -257,7 +257,12 @@ namespace MQTTnet.Server
if (matchingSubscribersCount == 0) if (matchingSubscribersCount == 0)
{ {
reasonCode = (int)MqttPubAckReasonCode.NoMatchingSubscribers; if (reasonCode == (int)MqttPubAckReasonCode.Success)
{
// Only change the value if it was success. Otherwise, we would hide an error or not authorized status.
reasonCode = (int)MqttPubAckReasonCode.NoMatchingSubscribers;
}
await FireApplicationMessageNotConsumedEvent(applicationMessage, senderId).ConfigureAwait(false); await FireApplicationMessageNotConsumedEvent(applicationMessage, senderId).ConfigureAwait(false);
} }
} }